From: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
To: Bjorn Helgaas <helgaas@kernel•org>
Cc: "Krzysztof Wilczyński" <kw@linux•com>,
"Rich Felker" <dalias@libc•org>,
linux-sh@vger•kernel.org, linux-pci@vger•kernel.org,
"Dominik Brodowski" <linux@dominikbrodowski•net>,
linux-mips@vger•kernel.org, "Bjorn Helgaas" <bhelgaas@google•com>,
"Andrew Lunn" <andrew@lunn•ch>,
sparclinux@vger•kernel.org,
"Stefano Stabellini" <sstabellini@kernel•org>,
"Yoshinori Sato" <ysato@users•sourceforge.jp>,
"Gregory Clement" <gregory.clement@bootlin•com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel•com>,
"Russell King" <linux@armlinux•org.uk>,
linux-acpi@vger•kernel.org, "Miguel Ojeda" <ojeda@kernel•org>,
xen-devel@lists•xenproject.org,
"Matt Turner" <mattst88@gmail•com>,
"Anatolij Gustschin" <agust@denx•de>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail•com>,
"Arnd Bergmann" <arnd@arndb•de>,
"Niklas Schnelle" <schnelle@linux•ibm.com>,
"Richard Henderson" <richard.henderson@linaro•org>,
"Nicholas Piggin" <npiggin@gmail•com>,
"Ivan Kokshaysky" <ink@jurassic•park.msu.ru>,
"John Paul Adrian Glaubitz" <glaubitz@physik•fu-berlin.de>,
"Mickaël Salaün" <mic@digikod•net>,
"Mika Westerberg" <mika.westerberg@linux•intel.com>,
linux-arm-kernel@lists•infradead.org,
"Juergen Gross" <jgross@suse•com>,
"Thomas Bogendoerfer" <tsbogend@alpha•franken.de>,
linuxppc-dev@lists•ozlabs.org,
"Randy Dunlap" <rdunlap@infradead•org>,
linux-kernel@vger•kernel.org,
"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam•com>,
linux-alpha@vger•kernel.org, "Pali Rohár" <pali@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
"Maciej W. Rozycki" <macro@orcam•me.uk>
Subject: Re: [PATCH v6 1/4] PCI: Introduce pci_dev_for_each_resource()
Date: Thu, 23 Mar 2023 16:30:01 +0200 [thread overview]
Message-ID: <ZBxiaflGTeK8Jlgx@smile.fi.intel.com> (raw)
In-Reply-To: <20230322192804.GA2485349@bhelgaas>
On Wed, Mar 22, 2023 at 02:28:04PM -0500, Bjorn Helgaas wrote:
> On Mon, Mar 20, 2023 at 03:16:30PM +0200, Andy Shevchenko wrote:
...
> > + pci_dev_for_each_resource_p(dev, r) {
> > /* zap the 2nd function of the winbond chip */
> > - if (dev->resource[i].flags & IORESOURCE_IO
> > - && dev->bus->number == 0 && dev->devfn == 0x81)
> > - dev->resource[i].flags &= ~IORESOURCE_IO;
> > - if (dev->resource[i].start == 0 && dev->resource[i].end) {
> > - dev->resource[i].flags = 0;
> > - dev->resource[i].end = 0;
> > + if (dev->bus->number == 0 && dev->devfn == 0x81 &&
> > + r->flags & IORESOURCE_IO)
>
> This is a nice literal conversion, but it's kind of lame to test
> bus->number and devfn *inside* the loop here, since they can't change
> inside the loop.
Hmm... why are you asking me, even if I may agree on that? It's
in the original code and out of scope of this series.
> > + r->flags &= ~IORESOURCE_IO;
> > + if (r->start == 0 && r->end) {
> > + r->flags = 0;
> > + r->end = 0;
> > }
> > }
...
> > #define pci_resource_len(dev,bar) \
> > ((pci_resource_end((dev), (bar)) == 0) ? 0 : \
> > \
> > - (pci_resource_end((dev), (bar)) - \
> > - pci_resource_start((dev), (bar)) + 1))
> > + resource_size(pci_resource_n((dev), (bar))))
>
> I like this change, but it's unrelated to pci_dev_for_each_resource()
> and unmentioned in the commit log.
And as you rightfully noticed this either. I can split it to a separate one.
...
> > +#define __pci_dev_for_each_resource(dev, res, __i, vartype) \
> > + for (vartype __i = 0; \
> > + res = pci_resource_n(dev, __i), __i < PCI_NUM_RESOURCES; \
> > + __i++)
> > +
> > +#define pci_dev_for_each_resource(dev, res, i) \
> > + __pci_dev_for_each_resource(dev, res, i, )
> > +
> > +#define pci_dev_for_each_resource_p(dev, res) \
> > + __pci_dev_for_each_resource(dev, res, __i, unsigned int)
>
> This series converts many cases to drop the iterator variable ("i"),
> which is fantastic.
>
> Several of the remaining places need the iterator variable only to
> call pci_claim_resource(), which could be converted to take a "struct
> resource *" directly without much trouble.
>
> We don't have to do that pci_claim_resource() conversion now,
Exactly, it's definitely should be separate change.
> but
> since we're converging on the "(dev, res)" style, I think we should
> reverse the names so we have something like:
>
> pci_dev_for_each_resource(dev, res)
> pci_dev_for_each_resource_idx(dev, res, i)
Wouldn't it be more churn, including pci_bus_for_each_resource() correction?
...
> Not sure __pci_dev_for_each_resource() is worthwhile since it only
> avoids repeating that single "for" statement, and passing in "vartype"
> (sometimes empty to implicitly avoid the declaration) is a little
> complicated to read. I think it'd be easier to read like this:
No objections here.
> #define pci_dev_for_each_resource(dev, res) \
> for (unsigned int __i = 0; \
> res = pci_resource_n(dev, __i), __i < PCI_NUM_RESOURCES; \
> __i++)
>
> #define pci_dev_for_each_resource_idx(dev, res, idx) \
> for (idx = 0; \
> res = pci_resource_n(dev, idx), idx < PCI_NUM_RESOURCES; \
> idx++)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-23 14:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 13:16 [PATCH v6 0/4] Add pci_dev_for_each_resource() helper and update users Andy Shevchenko
2023-03-20 13:16 ` [PATCH v6 1/4] PCI: Introduce pci_dev_for_each_resource() Andy Shevchenko
2023-03-22 19:28 ` Bjorn Helgaas
2023-03-23 14:30 ` Andy Shevchenko [this message]
2023-03-23 15:02 ` Bjorn Helgaas
2023-03-23 15:08 ` Andy Shevchenko
2023-03-23 16:28 ` Geert Uytterhoeven
2023-03-20 13:16 ` [PATCH v6 2/4] PCI: Split pci_bus_for_each_resource_p() out of pci_bus_for_each_resource() Andy Shevchenko
2023-03-22 19:35 ` Bjorn Helgaas
2023-03-20 13:16 ` [PATCH v6 3/4] EISA: Convert to use pci_bus_for_each_resource_p() Andy Shevchenko
2023-03-20 13:16 ` [PATCH v6 4/4] pcmcia: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBxiaflGTeK8Jlgx@smile.fi.intel.com \
--to=andriy.shevchenko@linux$(echo .)intel.com \
--cc=agust@denx$(echo .)de \
--cc=andrew@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=bhelgaas@google$(echo .)com \
--cc=dalias@libc$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=glaubitz@physik$(echo .)fu-berlin.de \
--cc=gregory.clement@bootlin$(echo .)com \
--cc=helgaas@kernel$(echo .)org \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=jgross@suse$(echo .)com \
--cc=kw@linux$(echo .)com \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linux@dominikbrodowski$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=macro@orcam$(echo .)me.uk \
--cc=mattst88@gmail$(echo .)com \
--cc=mic@digikod$(echo .)net \
--cc=mika.westerberg@linux$(echo .)intel.com \
--cc=npiggin@gmail$(echo .)com \
--cc=ojeda@kernel$(echo .)org \
--cc=oleksandr_tyshchenko@epam$(echo .)com \
--cc=pali@kernel$(echo .)org \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=richard.henderson@linaro$(echo .)org \
--cc=schnelle@linux$(echo .)ibm.com \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=sstabellini@kernel$(echo .)org \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=xen-devel@lists$(echo .)xenproject.org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox