From: Oliver Upton <oliver.upton@linux•dev>
To: David Matlack <dmatlack@google•com>
Cc: kvm@vger•kernel.org, "David Hildenbrand" <david@redhat•com>,
"Anup Patel" <anup@brainfault•org>,
"Paul Walmsley" <paul.walmsley@sifive•com>,
linux-riscv@lists•infradead.org,
"Claudio Imbrenda" <imbrenda@linux•ibm.com>,
"Janosch Frank" <frankja@linux•ibm.com>,
"Marc Zyngier" <maz@kernel•org>,
"Huacai Chen" <chenhuacai@kernel•org>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail•com>,
"Zenghui Yu" <yuzenghui@huawei•com>,
"Palmer Dabbelt" <palmer@dabbelt•com>,
"Christian Borntraeger" <borntraeger@linux•ibm.com>,
"Eric Farman" <farman@linux•ibm.com>,
"Albert Ou" <aou@eecs•berkeley.edu>,
"Suzuki K Poulose" <suzuki.poulose@arm•com>,
"Nicholas Piggin" <npiggin@gmail•com>,
"Sathvika Vasireddy" <sv@linux•ibm.com>,
"Atish Patra" <atishp@atishpatra•org>,
kvmarm@lists•linux.dev, linux-arm-kernel@lists•infradead.org,
"Philippe Mathieu-Daudé" <philmd@linaro•org>,
"Sean Christopherson" <seanjc@google•com>,
linux-mips@vger•kernel.org, "James Morse" <james.morse@arm•com>,
kvm-riscv@lists•infradead.org,
"Paolo Bonzi ni" <pbonzini@redhat•com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2 0/4] KVM: Refactor KVM stats macros and enable custom stat names
Date: Wed, 26 Apr 2023 17:21:58 +0000 [thread overview]
Message-ID: <ZEldtrUVBgmlrFOl@linux.dev> (raw)
In-Reply-To: <20230306190156.434452-1-dmatlack@google.com>
On Mon, Mar 06, 2023 at 11:01:52AM -0800, David Matlack wrote:
> This series refactors the KVM stats macros to reduce duplication and
> adds the support for choosing custom names for stats.
>
> Custom name makes it possible to decouple the userspace-visible stat
> names from their internal representation in C. This can allow future
> commits to refactor the various stats structs without impacting
> userspace tools that read KVM stats.
>
> This also allows stats to be stored in data structures such as arrays,
> without needing unions to access specific stats. Case in point, the last
> patch in this series removes the pages_{4k,2m,1g} union, which is a
> useful cleanup to prepare for sharing paging code across architectures
> [1].
>
> And for full transparency, another motivation for this series it that at
> Google we have several out-of-tree stats that use arrays. Custom name
> support is something we added internally and it reduces our technical
> debt to get the support merged upstream.
For the series:
Reviewed-by: Oliver Upton <oliver.upton@linux•dev>
--
Thanks,
Oliver
next prev parent reply other threads:[~2023-04-26 17:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 19:01 [PATCH v2 0/4] KVM: Refactor KVM stats macros and enable custom stat names David Matlack
2023-03-06 19:01 ` [PATCH v2 1/4] KVM: Refactor stats descriptor generation macros David Matlack
2023-04-06 4:42 ` Anup Patel
2023-03-06 19:01 ` [PATCH v2 2/4] KVM: Refactor designated initializer macros for struct _kvm_stats_desc David Matlack
2023-03-06 19:01 ` [PATCH v2 3/4] KVM: Allow custom names for KVM_STAT() David Matlack
2023-03-06 19:01 ` [PATCH v2 4/4] KVM: x86: Drop union for pages_{4k,2m,1g} stats David Matlack
2023-04-07 23:30 ` [PATCH v2 0/4] KVM: Refactor KVM stats macros and enable custom stat names Sean Christopherson
2023-04-26 17:21 ` Oliver Upton [this message]
2023-05-09 20:51 ` David Matlack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEldtrUVBgmlrFOl@linux.dev \
--to=oliver.upton@linux$(echo .)dev \
--cc=aleksandar.qemu.devel@gmail$(echo .)com \
--cc=anup@brainfault$(echo .)org \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=atishp@atishpatra$(echo .)org \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=david@redhat$(echo .)com \
--cc=dmatlack@google$(echo .)com \
--cc=farman@linux$(echo .)ibm.com \
--cc=frankja@linux$(echo .)ibm.com \
--cc=imbrenda@linux$(echo .)ibm.com \
--cc=james.morse@arm$(echo .)com \
--cc=kvm-riscv@lists$(echo .)infradead.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kvmarm@lists$(echo .)linux.dev \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maz@kernel$(echo .)org \
--cc=npiggin@gmail$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=pbonzini@redhat$(echo .)com \
--cc=philmd@linaro$(echo .)org \
--cc=seanjc@google$(echo .)com \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=sv@linux$(echo .)ibm.com \
--cc=yuzenghui@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox