From: Jason Gunthorpe <jgg@nvidia•com>
To: Robin Murphy <robin.murphy@arm•com>
Cc: Heiko Stuebner <heiko@sntech•de>,
Matthew Rosato <mjrosato@linux•ibm.com>,
Matthias Brugger <matthias.bgg@gmail•com>,
Thierry Reding <thierry.reding@gmail•com>,
Jernej Skrabec <jernej.skrabec@gmail•com>,
Alim Akhtar <alim.akhtar@samsung•com>,
Dmitry Osipenko <digetx@gmail•com>,
Steven Price <steven.price@arm•com>,
Will Deacon <will@kernel•org>,
Marek Szyprowski <m.szyprowski@samsung•com>,
linux-s390@vger•kernel.org, linux-samsung-soc@vger•kernel.org,
Samuel Holland <samuel@sholland•org>,
Joerg Roedel <joro@8bytes•org>,
Russell King <linux@armlinux•org.uk>,
Jonathan Hunter <jonathanh@nvidia•com>,
linux-rockchip@lists•infradead.org, iommu@lists•linux.dev,
Andy Gross <agross@kernel•org>,
Nicolin Chen <nicolinc@nvidia•com>,
Yong Wu <yong.wu@mediatek•com>, Orson Zhai <orsonzhai@gmail•com>,
Gerald Schaefer <gerald.schaefer@linux•ibm.com>,
Thierry Reding <treding@nvidia•com>,
linux-sunxi@lists•linux.dev, Rob Clark <robdclark@gmail•com>,
Kevin Tian <kevin.tian@intel•com>,
Niklas Schnelle <schnelle@linux•ibm.com>,
linux-arm-msm@vger•kernel.org,
Nicholas Piggin <npiggin@gmail•com>,
Krishna Reddy <vdumpa@nvidia•com>,
linux-mediatek@lists•infradead.org,
Baolin Wang <baolin.wang@linux•alibaba.com>,
linux-tegra@vger•kernel.org, Chen-Yu Tsai <wens@csie•org>,
linux-arm-kernel@lists•infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora•com>,
Bjorn Andersson <andersson@kernel•org>,
Konrad Dybcio <konrad.dybcio@linaro•org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro•org>,
Chunyan Zhang <zhang.lyra@gmail•com>,
linuxppc-dev@lists•ozlabs.org,
Lu Baolu <baolu.lu@linux•intel.com>
Subject: Re: [PATCH v2 09/25] iommu/fsl_pamu: Implement an IDENTITY domain
Date: Thu, 1 Jun 2023 16:46:25 -0300 [thread overview]
Message-ID: <ZHj1kXMMf5iqxXOV@nvidia.com> (raw)
In-Reply-To: <84aa0f5e-f13d-40f5-abe6-e8ac231e2d95@arm.com>
On Thu, Jun 01, 2023 at 08:37:45PM +0100, Robin Murphy wrote:
> On 2023-05-16 01:00, Jason Gunthorpe wrote:
> > Robin was able to check the documentation and what fsl_pamu has
> > historically called detach_dev() is really putting the IOMMU into an
> > IDENTITY mode.
>
> Unfortunately it was the other way around - it's the call to
> fsl_setup_liodns() from fsl_pamu_probe() which leaves everything in bypass
> by default (the PAACE_ATM_NO_XLATE part, IIRC), whereas the detach_device()
> call here ends up disabling the given device's LIODN altogether
Er, I see.. Let me think about it, you convinced me to change it from
PLATFORM, so maybe we should go back to that if it is all wonky.
> There doesn't appear to have ever been any code anywhere for putting
> things *back* into bypass after using a VFIO domain, so as-is these
> default domains would probably break all DMA :(
Sounds like it just never worked right.
ie going to VFIO mode was always a one way trip and you can't go back
to a kernel driver.
I don't think this patch makes it worse because we call the identity
attach_dev in all the same places we called detach_dev in the first
place.
We add an extra call at the start of time, but that call is NOP'd
by this:
> > if (domain == platform_domain || !domain)
> > + return 0;
> > +
(bah, and the variable name needs updating too)
Honestly, I don't really want to fix FSL since it seems abandoned, so
either this patch or going back to PLATFORM seems like the best option.
Jason
next prev parent reply other threads:[~2023-06-01 19:47 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230516000132eucas1p2d20a1c49d4711fda942a3c3a842384e6@eucas1p2.samsung.com>
2023-05-16 0:00 ` [PATCH v2 00/25] iommu: Make default_domain's mandatory Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 01/25] iommu: Add iommu_ops->identity_domain Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 02/25] iommu: Add IOMMU_DOMAIN_PLATFORM Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 03/25] powerpc/iommu: Setup a default domain and remove set_platform_dma_ops Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 04/25] iommu: Add IOMMU_DOMAIN_PLATFORM for S390 Jason Gunthorpe
2023-06-01 18:25 ` Robin Murphy
2023-06-01 19:58 ` Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 05/25] iommu/tegra-gart: Remove tegra-gart Jason Gunthorpe
2023-06-01 16:51 ` Thierry Reding
2023-05-16 0:00 ` [PATCH v2 06/25] iommu/mtk_iommu_v1: Implement an IDENTITY domain Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 07/25] iommu: Reorganize iommu_get_default_domain_type() to respect def_domain_type() Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 08/25] iommu: Allow an IDENTITY domain as the default_domain in ARM32 Jason Gunthorpe
2023-06-01 18:57 ` Robin Murphy
2023-05-16 0:00 ` [PATCH v2 09/25] iommu/fsl_pamu: Implement an IDENTITY domain Jason Gunthorpe
2023-06-01 19:37 ` Robin Murphy
2023-06-01 19:46 ` Jason Gunthorpe [this message]
2023-06-01 19:53 ` Robin Murphy
2023-06-01 20:17 ` Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 10/25] iommu/exynos: " Jason Gunthorpe
2023-05-17 22:41 ` Marek Szyprowski
2023-05-16 0:00 ` [PATCH v2 11/25] iommu/tegra-smmu: " Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 12/25] iommu/tegra-smmu: Support DMA domains in tegra Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 13/25] iommu/omap: Implement an IDENTITY domain Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 14/25] iommu/msm: " Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 15/25] iommufd/selftest: Make the mock iommu driver into a real driver Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 16/25] iommu: Remove ops->set_platform_dma_ops() Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 17/25] iommu/qcom_iommu: Add an IOMMU_IDENTITIY_DOMAIN Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 18/25] iommu/ipmmu: " Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 19/25] iommu/mtk_iommu: " Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 20/25] iommu/sun50i: " Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 21/25] iommu: Require a default_domain for all iommu drivers Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 22/25] iommu: Add __iommu_group_domain_alloc() Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 23/25] iommu: Add ops->domain_alloc_paging() Jason Gunthorpe
2023-06-01 19:17 ` Robin Murphy
2023-06-01 20:47 ` Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 24/25] iommu: Convert simple drivers with DOMAIN_DMA to domain_alloc_paging() Jason Gunthorpe
2023-05-16 0:00 ` [PATCH v2 25/25] iommu: Convert remaining simple drivers " Jason Gunthorpe
2023-06-01 19:47 ` Robin Murphy
2023-06-01 20:37 ` Jason Gunthorpe
2023-06-09 19:26 ` Jason Gunthorpe
2023-05-17 22:42 ` [PATCH v2 00/25] iommu: Make default_domain's mandatory Marek Szyprowski
2023-05-17 23:32 ` Nicolin Chen
2023-05-18 10:56 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHj1kXMMf5iqxXOV@nvidia.com \
--to=jgg@nvidia$(echo .)com \
--cc=agross@kernel$(echo .)org \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=andersson@kernel$(echo .)org \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=baolin.wang@linux$(echo .)alibaba.com \
--cc=baolu.lu@linux$(echo .)intel.com \
--cc=digetx@gmail$(echo .)com \
--cc=gerald.schaefer@linux$(echo .)ibm.com \
--cc=heiko@sntech$(echo .)de \
--cc=iommu@lists$(echo .)linux.dev \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=kevin.tian@intel$(echo .)com \
--cc=konrad.dybcio@linaro$(echo .)org \
--cc=krzysztof.kozlowski@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mjrosato@linux$(echo .)ibm.com \
--cc=nicolinc@nvidia$(echo .)com \
--cc=npiggin@gmail$(echo .)com \
--cc=orsonzhai@gmail$(echo .)com \
--cc=robdclark@gmail$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=samuel@sholland$(echo .)org \
--cc=schnelle@linux$(echo .)ibm.com \
--cc=steven.price@arm$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=treding@nvidia$(echo .)com \
--cc=vdumpa@nvidia$(echo .)com \
--cc=wens@csie$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=yong.wu@mediatek$(echo .)com \
--cc=zhang.lyra@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox