From: Catalin Marinas <catalin.marinas@arm•com>
To: Yicong Yang <yangyicong@huawei•com>
Cc: mark.rutland@arm•com, wangkefeng.wang@huawei•com,
prime.zeng@hisilicon•com, realmz6@gmail•com,
linux-doc@vger•kernel.org, peterz@infradead•org,
linux-kernel@vger•kernel.org, linux-mm@kvack•org,
Nadav Amit <namit@vmware•com>,
punit.agrawal@bytedance•com, linux-riscv@lists•infradead.org,
will@kernel•org, linux-s390@vger•kernel.org,
zhangshiming@oppo•com, lipeifeng@oppo•com, corbet@lwn•net,
x86@kernel•org, Barry Song <21cnbao@gmail•com>,
Mel Gorman <mgorman@suse•de>,
ryan.roberts@arm•com, arnd@arndb•de, anshuman.khandual@arm•com,
Barry Song <v-songbaohua@oppo•com>,
openrisc@lists•librecores.org, darren@os•amperecomputing.com,
Jonathan.Cameron@huawei•com, yangyicong@hisilicon•com,
linux-arm-kernel@lists•infradead.org, guojian@oppo•com,
xhao@linux•alibaba.com, linux-mips@vger•kernel.org,
huzhanyuan@oppo•com, akpm@linux-foundation•org,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v11 4/4] arm64: support batched/deferred tlb shootdown during page reclamation/migration
Date: Fri, 21 Jul 2023 19:25:05 +0100 [thread overview]
Message-ID: <ZLrNgfDNyZGWx5bG@arm.com> (raw)
In-Reply-To: <20230717131004.12662-5-yangyicong@huawei.com>
On Mon, Jul 17, 2023 at 09:10:04PM +0800, Yicong Yang wrote:
> +static inline void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *batch,
> + struct mm_struct *mm,
> + unsigned long uaddr)
> +{
> + __flush_tlb_page_nosync(mm, uaddr);
> +}
> +
> +static inline void arch_flush_tlb_batched_pending(struct mm_struct *mm)
> +{
> + dsb(ish);
> +}
> +
> +static inline void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch)
> +{
> + dsb(ish);
> +}
Nitpick: as an additional patch, I'd add some comment for these two
functions that the TLBI has already been issued and only a DSB is needed
to synchronise its effect on the other CPUs.
Reviewed-by: Catalin Marinas <catalin.marinas@arm•com>
prev parent reply other threads:[~2023-07-21 18:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 13:10 [PATCH v11 0/4] arm64: support batched/deferred tlb shootdown during page reclamation/migration Yicong Yang
2023-07-17 13:10 ` [PATCH v11 1/4] mm/tlbbatch: Introduce arch_tlbbatch_should_defer() Yicong Yang
2023-07-21 18:23 ` Catalin Marinas
2023-07-17 13:10 ` [PATCH v11 2/4] mm/tlbbatch: Rename and extend some functions Yicong Yang
2023-07-21 18:24 ` Catalin Marinas
2023-07-17 13:10 ` [PATCH v11 3/4] mm/tlbbatch: Introduce arch_flush_tlb_batched_pending() Yicong Yang
2023-07-21 18:24 ` Catalin Marinas
2023-07-17 13:10 ` [PATCH v11 4/4] arm64: support batched/deferred tlb shootdown during page reclamation/migration Yicong Yang
2023-07-21 18:25 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLrNgfDNyZGWx5bG@arm.com \
--to=catalin.marinas@arm$(echo .)com \
--cc=21cnbao@gmail$(echo .)com \
--cc=Jonathan.Cameron@huawei$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anshuman.khandual@arm$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=corbet@lwn$(echo .)net \
--cc=darren@os$(echo .)amperecomputing.com \
--cc=guojian@oppo$(echo .)com \
--cc=huzhanyuan@oppo$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lipeifeng@oppo$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=mgorman@suse$(echo .)de \
--cc=namit@vmware$(echo .)com \
--cc=openrisc@lists$(echo .)librecores.org \
--cc=peterz@infradead$(echo .)org \
--cc=prime.zeng@hisilicon$(echo .)com \
--cc=punit.agrawal@bytedance$(echo .)com \
--cc=realmz6@gmail$(echo .)com \
--cc=ryan.roberts@arm$(echo .)com \
--cc=v-songbaohua@oppo$(echo .)com \
--cc=wangkefeng.wang@huawei$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=xhao@linux$(echo .)alibaba.com \
--cc=yangyicong@hisilicon$(echo .)com \
--cc=yangyicong@huawei$(echo .)com \
--cc=zhangshiming@oppo$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox