From: Jason Gunthorpe <jgg@nvidia•com>
To: Baolu Lu <baolu.lu@linux•intel.com>
Cc: Heiko Stuebner <heiko@sntech•de>,
Matthew Rosato <mjrosato@linux•ibm.com>,
Matthias Brugger <matthias.bgg@gmail•com>,
Thierry Reding <thierry.reding@gmail•com>,
Jernej Skrabec <jernej.skrabec@gmail•com>,
Alim Akhtar <alim.akhtar@samsung•com>,
Dmitry Osipenko <digetx@gmail•com>,
Steven Price <steven.price@arm•com>,
Will Deacon <will@kernel•org>,
Marek Szyprowski <m.szyprowski@samsung•com>,
linux-s390@vger•kernel.org, linux-samsung-soc@vger•kernel.org,
Samuel Holland <samuel@sholland•org>,
Joerg Roedel <joro@8bytes•org>,
Russell King <linux@armlinux•org.uk>,
Jonathan Hunter <jonathanh@nvidia•com>,
linux-rockchip@lists•infradead.org, iommu@lists•linux.dev,
Andy Gross <agross@kernel•org>,
Nicolin Chen <nicolinc@nvidia•com>,
Yong Wu <yong.wu@mediatek•com>, Orson Zhai <orsonzhai@gmail•com>,
Gerald Schaefer <gerald.schaefer@linux•ibm.com>,
Thierry Reding <treding@nvidia•com>,
linux-sunxi@lists•linux.dev, Rob Clark <robdclark@gmail•com>,
Kevin Tian <kevin.tian@intel•com>,
Niklas Schnelle <schnelle@linux•ibm.com>,
linux-arm-msm@vger•kernel.org,
Nicholas Piggin <npiggin@gmail•com>,
Krishna Reddy <vdumpa@nvidia•com>,
linux-mediatek@lists•infradead.org,
Baolin Wang <baolin.wang@linux•alibaba.com>,
linux-tegra@vger•kernel.org, Chen-Yu Tsai <wens@csie•org>,
linux-arm-kernel@lists•infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora•com>,
Robin Murphy <robin.murphy@arm•com>,
Bjorn Andersson <andersson@kernel•org>,
Konrad Dybcio <konrad.dybcio@linaro•org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro•org>,
Chunyan Zhang <zhang.lyra@gmail•com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v6 12/25] iommu/tegra-smmu: Support DMA domains in tegra
Date: Mon, 14 Aug 2023 12:34:40 -0300 [thread overview]
Message-ID: <ZNpJkMp3W45mPnHB@nvidia.com> (raw)
In-Reply-To: <6675bf11-ed80-15b9-b8bc-dee65b595ba5@linux.intel.com>
On Mon, Aug 14, 2023 at 01:08:39PM +0800, Baolu Lu wrote:
> > @@ -989,6 +989,12 @@ static int tegra_smmu_def_domain_type(struct device *dev)
> > }
> > static const struct iommu_ops tegra_smmu_ops = {
> > + /*
> > + * FIXME: For now we want to run all translation in IDENTITY mode,
> > + * better would be to have a def_domain_type op do this for just the
> > + * quirky device.
> > + */
> > + .default_domain = &tegra_smmu_identity_domain,
>
> tegra_smmu_def_domain_type() has already forced the core to use
> ops->identity_domain, why do we still need ops->default_domain?
This looks like it is just some cruft from an earlier version that did
not have tegra_smmu_def_domain_type(), I deleted it
Thanks,
Jason
next prev parent reply other threads:[~2023-08-14 15:36 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 0:07 [PATCH v6 00/25] iommu: Make default_domain's mandatory Jason Gunthorpe
2023-08-03 0:07 ` [PATCH v6 01/25] iommu: Add iommu_ops->identity_domain Jason Gunthorpe
2023-08-03 0:07 ` [PATCH v6 02/25] iommu: Add IOMMU_DOMAIN_PLATFORM Jason Gunthorpe
2023-08-12 1:36 ` Baolu Lu
2023-08-12 11:28 ` Jason Gunthorpe
2023-08-13 12:11 ` Baolu Lu
2023-08-14 13:39 ` Jason Gunthorpe
2023-08-12 1:41 ` Baolu Lu
2023-08-14 14:22 ` Jason Gunthorpe
2023-08-03 0:07 ` [PATCH v6 03/25] powerpc/iommu: Setup a default domain and remove set_platform_dma_ops Jason Gunthorpe
2023-08-14 2:13 ` Baolu Lu
2023-08-03 0:07 ` [PATCH v6 04/25] iommu: Add IOMMU_DOMAIN_PLATFORM for S390 Jason Gunthorpe
2023-08-14 2:20 ` Baolu Lu
2023-08-03 0:07 ` [PATCH v6 05/25] iommu/fsl_pamu: Implement a PLATFORM domain Jason Gunthorpe
2023-08-14 2:35 ` Baolu Lu
2023-08-03 0:07 ` [PATCH v6 06/25] iommu/tegra-gart: Remove tegra-gart Jason Gunthorpe
2023-08-12 1:51 ` Baolu Lu
2023-08-03 0:07 ` [PATCH v6 07/25] iommu/mtk_iommu_v1: Implement an IDENTITY domain Jason Gunthorpe
2023-08-14 3:06 ` Baolu Lu
2023-08-14 14:34 ` Jason Gunthorpe
2023-08-15 0:34 ` Baolu Lu
2023-08-03 0:07 ` [PATCH v6 08/25] iommu: Reorganize iommu_get_default_domain_type() to respect def_domain_type() Jason Gunthorpe
2023-08-12 2:15 ` Baolu Lu
2023-08-14 17:25 ` Jason Gunthorpe
2023-08-15 1:18 ` Baolu Lu
2023-08-16 12:44 ` Jason Gunthorpe
2023-08-03 0:07 ` [PATCH v6 09/25] iommu: Allow an IDENTITY domain as the default_domain in ARM32 Jason Gunthorpe
2023-08-14 4:32 ` Baolu Lu
2023-08-03 0:07 ` [PATCH v6 10/25] iommu/exynos: Implement an IDENTITY domain Jason Gunthorpe
2023-08-14 4:52 ` Baolu Lu
2023-08-14 12:48 ` Jason Gunthorpe
2023-08-03 0:07 ` [PATCH v6 11/25] iommu/tegra-smmu: " Jason Gunthorpe
2023-08-14 5:01 ` Baolu Lu
2023-08-03 0:07 ` [PATCH v6 12/25] iommu/tegra-smmu: Support DMA domains in tegra Jason Gunthorpe
2023-08-14 5:08 ` Baolu Lu
2023-08-14 15:34 ` Jason Gunthorpe [this message]
2023-08-03 0:08 ` [PATCH v6 13/25] iommu/omap: Implement an IDENTITY domain Jason Gunthorpe
2023-08-14 5:10 ` Baolu Lu
2023-08-03 0:08 ` [PATCH v6 14/25] iommu/msm: " Jason Gunthorpe
2023-08-14 5:53 ` Baolu Lu
2023-08-03 0:08 ` [PATCH v6 15/25] iommufd/selftest: Make the mock iommu driver into a real driver Jason Gunthorpe
2023-08-12 4:57 ` Baolu Lu
2023-08-12 5:01 ` Baolu Lu
2023-08-14 23:16 ` Jason Gunthorpe
2023-08-03 0:08 ` [PATCH v6 16/25] iommu: Remove ops->set_platform_dma_ops() Jason Gunthorpe
2023-08-03 0:08 ` [PATCH v6 17/25] iommu/qcom_iommu: Add an IOMMU_IDENTITIY_DOMAIN Jason Gunthorpe
2023-08-14 6:32 ` Baolu Lu
2023-08-14 15:36 ` Jason Gunthorpe
2023-08-15 0:56 ` Baolu Lu
2023-08-03 0:08 ` [PATCH v6 18/25] iommu/ipmmu: " Jason Gunthorpe
2023-08-14 6:34 ` Baolu Lu
2023-08-03 0:08 ` [PATCH v6 19/25] iommu/mtk_iommu: " Jason Gunthorpe
2023-08-14 6:35 ` Baolu Lu
2023-08-03 0:08 ` [PATCH v6 20/25] iommu/sun50i: " Jason Gunthorpe
2023-08-14 6:44 ` Baolu Lu
2023-08-14 15:39 ` Jason Gunthorpe
2023-08-03 0:08 ` [PATCH v6 21/25] iommu: Require a default_domain for all iommu drivers Jason Gunthorpe
2023-08-03 0:08 ` [PATCH v6 22/25] iommu: Add __iommu_group_domain_alloc() Jason Gunthorpe
2023-08-03 0:08 ` [PATCH v6 23/25] iommu: Add ops->domain_alloc_paging() Jason Gunthorpe
2023-08-03 0:08 ` [PATCH v6 24/25] iommu: Convert simple drivers with DOMAIN_DMA to domain_alloc_paging() Jason Gunthorpe
2023-08-14 6:58 ` Baolu Lu
2023-08-14 15:40 ` Jason Gunthorpe
2023-08-03 0:08 ` [PATCH v6 25/25] iommu: Convert remaining simple drivers " Jason Gunthorpe
2023-08-14 7:00 ` Baolu Lu
2023-08-14 8:43 ` [PATCH v6 00/25] iommu: Make default_domain's mandatory Baolu Lu
2023-08-14 17:30 ` Jason Gunthorpe
2023-08-15 1:34 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNpJkMp3W45mPnHB@nvidia.com \
--to=jgg@nvidia$(echo .)com \
--cc=agross@kernel$(echo .)org \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=andersson@kernel$(echo .)org \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=baolin.wang@linux$(echo .)alibaba.com \
--cc=baolu.lu@linux$(echo .)intel.com \
--cc=digetx@gmail$(echo .)com \
--cc=gerald.schaefer@linux$(echo .)ibm.com \
--cc=heiko@sntech$(echo .)de \
--cc=iommu@lists$(echo .)linux.dev \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=kevin.tian@intel$(echo .)com \
--cc=konrad.dybcio@linaro$(echo .)org \
--cc=krzysztof.kozlowski@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mjrosato@linux$(echo .)ibm.com \
--cc=nicolinc@nvidia$(echo .)com \
--cc=npiggin@gmail$(echo .)com \
--cc=orsonzhai@gmail$(echo .)com \
--cc=robdclark@gmail$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=samuel@sholland$(echo .)org \
--cc=schnelle@linux$(echo .)ibm.com \
--cc=steven.price@arm$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=treding@nvidia$(echo .)com \
--cc=vdumpa@nvidia$(echo .)com \
--cc=wens@csie$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=yong.wu@mediatek$(echo .)com \
--cc=zhang.lyra@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox