From: Catalin Marinas <catalin.marinas@arm•com>
To: Ryan Roberts <ryan.roberts@arm•com>
Cc: Peter Xu <peterx@redhat•com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership•com>,
linux-mm@kvack•org, sparclinux@vger•kernel.org,
Alexander Gordeev <agordeev@linux•ibm.com>,
Will Deacon <will@kernel•org>,
linux-riscv@lists•infradead.org, linux-s390@vger•kernel.org,
Vasily Gorbik <gor@linux•ibm.com>, Helge Deller <deller@gmx•de>,
Christoph Hellwig <hch@infradead•org>,
Axel Rasmussen <axelrasmussen@google•com>,
Gerald Schaefer <gerald.schaefer@linux•ibm.com>,
Christian Borntraeger <borntraeger@linux•ibm.com>,
Albert Ou <aou@eecs•berkeley.edu>, Arnd Bergmann <arnd@arndb•de>,
Anshuman Khandual <anshuman.khandual@arm•com>,
Heiko Carstens <hca@linux•ibm.com>,
Nicholas Piggin <npiggin@gmail•com>,
Qi Zheng <zhengqi.arch@bytedance•com>,
Paul Walmsley <paul.walmsley@sifive•com>,
linux-arm-kernel@lists•infradead.org,
SeongJae Park <sj@kernel•org>,
Lorenzo Stoakes <lstoakes@gmail•com>,
linux-parisc@vger•kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Muchun Song <muc hun.song@linux•dev>,
linux-kernel@vger•kernel.org, stable@vger•kernel.org,
Uladzislau Rezki <urezki@gmail•com>,
Palmer Dabbelt <palmer@dabbelt•com>,
Sven Schnelle <svens@linux•ibm.com>,
Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org,
"David S. Miller" <davem@davemloft•net>,
Mike Kravetz <mike.kravetz@oracle•com>
Subject: Re: [PATCH v1 0/8] Fix set_huge_pte_at() panic on arm64
Date: Thu, 21 Sep 2023 18:38:07 +0100 [thread overview]
Message-ID: <ZQx/f35o0zT2lug4@arm.com> (raw)
In-Reply-To: <7c5c2c00-d657-44fd-b478-743b43c57e8a@arm.com>
On Thu, Sep 21, 2023 at 05:35:54PM +0100, Ryan Roberts wrote:
> On 21/09/2023 17:30, Andrew Morton wrote:
> > On Thu, 21 Sep 2023 17:19:59 +0100 Ryan Roberts <ryan.roberts@arm•com> wrote:
> >> Ryan Roberts (8):
> >> parisc: hugetlb: Convert set_huge_pte_at() to take vma
> >> powerpc: hugetlb: Convert set_huge_pte_at() to take vma
> >> riscv: hugetlb: Convert set_huge_pte_at() to take vma
> >> s390: hugetlb: Convert set_huge_pte_at() to take vma
> >> sparc: hugetlb: Convert set_huge_pte_at() to take vma
> >> mm: hugetlb: Convert set_huge_pte_at() to take vma
> >> arm64: hugetlb: Convert set_huge_pte_at() to take vma
> >> arm64: hugetlb: Fix set_huge_pte_at() to work with all swap entries
> >>
> >> arch/arm64/include/asm/hugetlb.h | 2 +-
> >> arch/arm64/mm/hugetlbpage.c | 22 ++++----------
> >> arch/parisc/include/asm/hugetlb.h | 2 +-
> >> arch/parisc/mm/hugetlbpage.c | 4 +--
> >> .../include/asm/nohash/32/hugetlb-8xx.h | 3 +-
> >> arch/powerpc/mm/book3s64/hugetlbpage.c | 2 +-
> >> arch/powerpc/mm/book3s64/radix_hugetlbpage.c | 2 +-
> >> arch/powerpc/mm/nohash/8xx.c | 2 +-
> >> arch/powerpc/mm/pgtable.c | 7 ++++-
> >> arch/riscv/include/asm/hugetlb.h | 2 +-
> >> arch/riscv/mm/hugetlbpage.c | 3 +-
> >> arch/s390/include/asm/hugetlb.h | 8 +++--
> >> arch/s390/mm/hugetlbpage.c | 8 ++++-
> >> arch/sparc/include/asm/hugetlb.h | 8 +++--
> >> arch/sparc/mm/hugetlbpage.c | 8 ++++-
> >> include/asm-generic/hugetlb.h | 6 ++--
> >> include/linux/hugetlb.h | 6 ++--
> >> mm/damon/vaddr.c | 2 +-
> >> mm/hugetlb.c | 30 +++++++++----------
> >> mm/migrate.c | 2 +-
> >> mm/rmap.c | 10 +++----
> >> mm/vmalloc.c | 5 +++-
> >> 22 files changed, 80 insertions(+), 64 deletions(-)
> >
> > Looks scary but it's actually a fairly modest patchset. It could
> > easily be all rolled into a single patch for ease of backporting.
> > Maybe Greg has an opinion?
>
> Yes, I thought about doing that; or perhaps 2 patches - one for the interface
> change across all arches and core code, and one for the actual bug fix?
I think this would make more sense, especially if we want to backport
it. The first patch would have no functional change, only an interface
change, followed by the arm64 fix.
--
Catalin
next prev parent reply other threads:[~2023-09-21 17:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 16:19 [PATCH v1 0/8] Fix set_huge_pte_at() panic on arm64 Ryan Roberts
2023-09-21 16:20 ` [PATCH v1 1/8] parisc: hugetlb: Convert set_huge_pte_at() to take vma Ryan Roberts
2023-09-21 16:20 ` [PATCH v1 2/8] powerpc: " Ryan Roberts
2023-09-21 18:43 ` Christophe Leroy
2023-09-22 6:44 ` Christophe Leroy
2023-09-22 7:19 ` Ryan Roberts
2023-09-22 6:56 ` Christophe Leroy
2023-09-22 7:33 ` Ryan Roberts
2023-09-22 8:10 ` Christophe Leroy
2023-09-22 8:41 ` Ryan Roberts
2023-09-22 9:14 ` Christophe Leroy
2023-09-22 9:37 ` Ryan Roberts
2023-09-21 16:20 ` [PATCH v1 3/8] riscv: " Ryan Roberts
2023-09-22 7:54 ` Alexandre Ghiti
2023-09-22 8:36 ` Ryan Roberts
2023-09-21 16:20 ` [PATCH v1 4/8] s390: " Ryan Roberts
2023-09-21 16:20 ` [PATCH v1 5/8] sparc: " Ryan Roberts
2023-09-21 16:20 ` [PATCH v1 6/8] mm: " Ryan Roberts
2023-09-22 1:37 ` SeongJae Park
2023-09-21 16:20 ` [PATCH v1 7/8] arm64: " Ryan Roberts
2023-09-21 16:20 ` [PATCH v1 8/8] arm64: hugetlb: Fix set_huge_pte_at() to work with all swap entries Ryan Roberts
2023-09-22 2:54 ` Qi Zheng
2023-09-22 7:40 ` Ryan Roberts
2023-09-22 7:54 ` Qi Zheng
2023-09-22 9:35 ` Ryan Roberts
2023-09-22 9:58 ` Qi Zheng
2023-09-21 16:30 ` [PATCH v1 0/8] Fix set_huge_pte_at() panic on arm64 Andrew Morton
2023-09-21 16:35 ` Ryan Roberts
2023-09-21 17:38 ` Catalin Marinas [this message]
2023-09-22 7:41 ` Ryan Roberts
2023-09-22 9:23 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQx/f35o0zT2lug4@arm.com \
--to=catalin.marinas@arm$(echo .)com \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=anshuman.khandual@arm$(echo .)com \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=arnd@arndb$(echo .)de \
--cc=axelrasmussen@google$(echo .)com \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=deller@gmx$(echo .)de \
--cc=gerald.schaefer@linux$(echo .)ibm.com \
--cc=gor@linux$(echo .)ibm.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hca@linux$(echo .)ibm.com \
--cc=hch@infradead$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=lstoakes@gmail$(echo .)com \
--cc=npiggin@gmail$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=peterx@redhat$(echo .)com \
--cc=ryan.roberts@arm$(echo .)com \
--cc=sj@kernel$(echo .)org \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=will@kernel$(echo .)org \
--cc=zhengqi.arch@bytedance$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox