From: Peter Xu <peterx@redhat•com>
To: Jason Gunthorpe <jgg@nvidia•com>
Cc: James Houghton <jthoughton@google•com>,
David Hildenbrand <david@redhat•com>,
Yang Shi <shy828301@gmail•com>,
Andrew Jones <andrew.jones@linux•dev>,
linux-mm@kvack•org, Matthew Wilcox <willy@infradead•org>,
linux-riscv@lists•infradead.org,
Andrea Arcangeli <aarcange@redhat•com>,
Christoph Hellwig <hch@infradead•org>,
"Aneesh Kumar K . V" <aneesh.kumar@kernel•org>,
Vlastimil Babka <vbabka@suse•cz>,
Axel Rasmussen <axelrasmussen@google•com>,
Rik van Riel <riel@surriel•com>,
John Hubbard <jhubbard@nvidia•com>,
"Kirill A . Shutemov" <kirill@shutemov•name>,
linux-arm-kernel@lists•infradead.org,
Lorenzo Stoakes <lstoakes@gmail•com>,
Muchun Song <muchun.song@linux•dev>,
linux-kernel@vger•kernel.org,
Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org, Mike Rapoport <rppt@kernel•org>,
Mike Kravetz <mike.kravetz@oracle•com>
Subject: Re: [PATCH v2 01/13] mm/Kconfig: CONFIG_PGTABLE_HAS_HUGE_LEAVES
Date: Mon, 22 Jan 2024 16:25:12 +0800 [thread overview]
Message-ID: <Za4maErLKnRnM0sB@x1n> (raw)
In-Reply-To: <20240115173737.GO734935@nvidia.com>
On Mon, Jan 15, 2024 at 01:37:37PM -0400, Jason Gunthorpe wrote:
> On Wed, Jan 03, 2024 at 05:14:11PM +0800, peterx@redhat•com wrote:
> > From: Peter Xu <peterx@redhat•com>
> >
> > Introduce a config option that will be selected as long as huge leaves are
> > involved in pgtable (thp or hugetlbfs). It would be useful to mark any
> > code with this new config that can process either hugetlb or thp pages in
> > any level that is higher than pte level.
> >
> > Signed-off-by: Peter Xu <peterx@redhat•com>
> > ---
> > mm/Kconfig | 3 +++
> > 1 file changed, 3 insertions(+)
>
> So you mean anything that supports page table entires > PAGE_SIZE ?
Yes.
>
> Makes sense to me, though maybe add a comment in the kconfig?
Sure I'll add some.
>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia•com>
Thanks for your reviews and also positive comments in previous versions,
Jason. I appreciate that.
I'm just pretty occupied with other tasks recently so I don't yet have time
to revisit this series, along with other comments yet. I'll do so and
reply to the comments / discussions together afterwards.
--
Peter Xu
next prev parent reply other threads:[~2024-01-22 8:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 9:14 [PATCH v2 00/13] mm/gup: Unify hugetlb, part 2 peterx
2024-01-03 9:14 ` [PATCH v2 01/13] mm/Kconfig: CONFIG_PGTABLE_HAS_HUGE_LEAVES peterx
2024-01-15 17:37 ` Jason Gunthorpe
2024-01-22 8:25 ` Peter Xu [this message]
2024-01-03 9:14 ` [PATCH v2 02/13] mm/hugetlb: Declare hugetlbfs_pagecache_present() non-static peterx
2024-01-03 9:14 ` [PATCH v2 03/13] mm: Provide generic pmd_thp_or_huge() peterx
2024-01-15 17:55 ` Jason Gunthorpe
2024-02-21 9:37 ` Peter Xu
2024-02-21 12:57 ` Jason Gunthorpe
2024-02-22 8:04 ` Peter Xu
2024-01-03 9:14 ` [PATCH v2 04/13] mm: Make HPAGE_PXD_* macros even if !THP peterx
2024-01-15 17:59 ` Jason Gunthorpe
2024-01-03 9:14 ` [PATCH v2 05/13] mm: Introduce vma_pgtable_walk_{begin|end}() peterx
2024-01-03 9:14 ` [PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing peterx
2024-01-15 18:37 ` Jason Gunthorpe
2024-01-16 6:30 ` Christophe Leroy
2024-01-16 12:31 ` Jason Gunthorpe
2024-01-16 18:32 ` Christophe Leroy
2024-01-17 13:22 ` Jason Gunthorpe
2024-01-18 15:15 ` Ryan Roberts
2024-02-21 11:55 ` Peter Xu
2024-01-03 9:14 ` [PATCH v2 07/13] mm/gup: Refactor record_subpages() to find 1st small page peterx
2024-01-15 18:38 ` Jason Gunthorpe
2024-01-03 9:14 ` [PATCH v2 08/13] mm/gup: Handle hugetlb for no_page_table() peterx
2024-01-15 18:39 ` Jason Gunthorpe
2024-01-03 9:14 ` [PATCH v2 09/13] mm/gup: Cache *pudp in follow_pud_mask() peterx
2024-01-15 18:41 ` Jason Gunthorpe
2024-01-03 9:14 ` [PATCH v2 10/13] mm/gup: Handle huge pud for follow_pud_mask() peterx
2024-01-15 18:49 ` Jason Gunthorpe
2024-02-21 11:49 ` Peter Xu
2024-01-03 9:14 ` [PATCH v2 11/13] mm/gup: Handle huge pmd for follow_pmd_mask() peterx
2024-01-15 18:51 ` Jason Gunthorpe
2024-01-03 9:14 ` [PATCH v2 12/13] mm/gup: Handle hugepd for follow_page() peterx
2024-01-03 9:14 ` [PATCH v2 13/13] mm/gup: Handle hugetlb in the generic follow_page_mask code peterx
2024-01-03 11:14 ` [PATCH v2 00/13] mm/gup: Unify hugetlb, part 2 Christophe Leroy
2024-01-08 7:27 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za4maErLKnRnM0sB@x1n \
--to=peterx@redhat$(echo .)com \
--cc=aarcange@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andrew.jones@linux$(echo .)dev \
--cc=aneesh.kumar@kernel$(echo .)org \
--cc=axelrasmussen@google$(echo .)com \
--cc=david@redhat$(echo .)com \
--cc=hch@infradead$(echo .)org \
--cc=jgg@nvidia$(echo .)com \
--cc=jhubbard@nvidia$(echo .)com \
--cc=jthoughton@google$(echo .)com \
--cc=kirill@shutemov$(echo .)name \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lstoakes@gmail$(echo .)com \
--cc=mike.kravetz@oracle$(echo .)com \
--cc=muchun.song@linux$(echo .)dev \
--cc=riel@surriel$(echo .)com \
--cc=rppt@kernel$(echo .)org \
--cc=shy828301@gmail$(echo .)com \
--cc=vbabka@suse$(echo .)cz \
--cc=willy@infradead$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox