From: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
To: Herve Codina <herve.codina@bootlin•com>
Cc: Andrew Lunn <andrew@lunn•ch>,
Vadim Fedorenko <vadim.fedorenko@linux•dev>,
Yury Norov <yury.norov@gmail•com>,
netdev@vger•kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes•dk>,
linux-kernel@vger•kernel.org, Eric Dumazet <edumazet@google•com>,
Mark Brown <broonie@kernel•org>,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
linuxppc-dev@lists•ozlabs.org,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH v5 0/5] Add support for QMC HDLC
Date: Thu, 29 Feb 2024 17:23:32 +0200 [thread overview]
Message-ID: <ZeChdAsAhrC8a75t@smile.fi.intel.com> (raw)
In-Reply-To: <20240229141554.836867-1-herve.codina@bootlin.com>
On Thu, Feb 29, 2024 at 03:15:48PM +0100, Herve Codina wrote:
> Hi,
>
> This series introduces the QMC HDLC support.
>
> Patches were previously sent as part of a full feature series and were
> previously reviewed in that context:
> "Add support for QMC HDLC, framer infrastructure and PEF2256 framer" [1]
>
> In order to ease the merge, the full feature series has been split and
> needed parts were merged in v6.8-rc1:
> - "Prepare the PowerQUICC QMC and TSA for the HDLC QMC driver" [2]
> - "Add support for framer infrastructure and PEF2256 framer" [3]
>
> This series contains patches related to the QMC HDLC part (QMC HDLC
> driver):
> - Introduce the QMC HDLC driver (patches 1 and 2)
> - Add timeslots change support in QMC HDLC (patch 3)
> - Add framer support as a framer consumer in QMC HDLC (patch 4)
>
> Compare to the original full feature series, a modification was done on
> patch 3 in order to use a coherent prefix in the commit title.
>
> I kept the patches unsquashed as they were previously sent and reviewed.
> Of course, I can squash them if needed.
I think it's a good series and next version will be final. The only question is
possible use of the returned values from bitmap_scatter()/bitmap_gather(), the
rest are minors.
Feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
to patches 4 and 5.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-29 15:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 14:15 [PATCH v5 0/5] Add support for QMC HDLC Herve Codina
2024-02-29 14:15 ` [PATCH v5 1/5] net: wan: " Herve Codina
2024-02-29 15:13 ` Andy Shevchenko
2024-02-29 14:15 ` [PATCH v5 2/5] MAINTAINERS: Add the Freescale QMC HDLC driver entry Herve Codina
2024-02-29 14:15 ` [PATCH v5 3/5] lib/bitmap: Introduce bitmap_scatter() and bitmap_gather() helpers Herve Codina
2024-02-29 15:17 ` Andy Shevchenko
2024-02-29 14:15 ` [PATCH v5 4/5] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support Herve Codina
2024-02-29 15:20 ` Andy Shevchenko
2024-02-29 16:30 ` Herve Codina
2024-02-29 14:15 ` [PATCH v5 5/5] net: wan: fsl_qmc_hdlc: Add framer support Herve Codina
2024-02-29 15:23 ` Andy Shevchenko [this message]
2024-03-05 11:02 ` [PATCH v5 0/5] Add support for QMC HDLC Herve Codina
2024-03-05 14:53 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeChdAsAhrC8a75t@smile.fi.intel.com \
--to=andriy.shevchenko@linux$(echo .)intel.com \
--cc=andrew@lunn$(echo .)ch \
--cc=broonie@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=herve.codina@bootlin$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@rasmusvillemoes$(echo .)dk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
--cc=yury.norov@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox