From: Niklas Cassel <cassel@kernel•org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro•org>
Cc: "Krzysztof Wilczyński" <kw@linux•com>,
"Vignesh Raghavendra" <vigneshr@ti•com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext•com>,
linux-pci@vger•kernel.org,
"Lorenzo Pieralisi" <lpieralisi@kernel•org>,
"Minghuan Lian" <minghuan.Lian@nxp•com>,
"Thierry Reding" <thierry.reding@gmail•com>,
"Kishon Vijay Abraham I" <kishon@ti•com>,
"Fabio Estevam" <festevam@gmail•com>,
"Marek Vasut" <marek.vasut+renesas@gmail•com>,
"Kishon Vijay Abraham I" <kishon@kernel•org>,
"Rob Herring" <robh@kernel•org>,
"Jesper Nilsson" <jesper.nilsson@axis•com>,
linux-tegra@vger•kernel.org, linux-arm-kernel@axis•com,
"Jonathan Hunter" <jonathanh@nvidia•com>,
"NXP Linux Team" <linux-imx@nxp•com>,
"Richard Zhu" <hongxing.zhu@nxp•com>,
"Srikanth Thokala" <srikanth.thokala@intel•com>,
linux-arm-msm@vger•kernel.org,
"Sascha Hauer" <s.hauer@pengutronix•de>,
linuxppc-dev@lists•ozlabs.org,
"Bjorn Helgaas" <bhelgaas@google•com>,
linux-omap@vger•kernel.org, "Mingkai Hu" <mingkai.hu@nxp•com>,
linux-arm-kernel@lists•infradead.org,
"Roy Zang" <roy.zang@nxp•com>,
"Jingoo Han" <jingoohan1@gmail•com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas•com>,
linux-kernel@vger•kernel.org, "Vidya Sagar" <vidyas@nvidia•com>,
linux-renesas-soc@vger•kernel.org,
"Masami Hiramatsu" <mhiramat@kernel•org>,
"Pengutronix Kernel Team" <kernel@pengutronix•de>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys•com>,
"Shawn Guo" <shawnguo@kernel•org>,
"Lucas Stach" <l.stach@pengutronix•de>
Subject: Re: [PATCH v10 7/8] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers
Date: Fri, 22 Mar 2024 12:03:07 +0100 [thread overview]
Message-ID: <Zf1la9ICDCHAyOit@ryzen> (raw)
In-Reply-To: <20240314-pci-dbi-rework-v10-7-14a45c5a938e@linaro.org>
On Thu, Mar 14, 2024 at 01:18:05PM +0530, Manivannan Sadhasivam wrote:
> Currently, dw_pcie_ep_init_registers() API is directly called by the glue
> drivers requiring active refclk from host. But for the other drivers, it is
> getting called implicitly by dw_pcie_ep_init(). This is due to the fact
> that this API initializes DWC EP specific registers and that requires an
> active refclk (either from host or generated locally by endpoint itsef).
>
> But, this causes a discrepancy among the glue drivers. So to avoid this
> confusion, let's call this API directly from all glue drivers irrespective
> of refclk dependency. Only difference here is that the drivers requiring
> refclk from host will call this API only after the refclk is received and
> other drivers without refclk dependency will call this API right after
> dw_pcie_ep_init().
>
> With this change, the check for 'core_init_notifier' flag can now be
> dropped from dw_pcie_ep_init() API. This will also allow us to remove the
> 'core_init_notifier' flag completely in the later commits.
>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas•com>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro•org>
> ---
Reviewed-by: Niklas Cassel <cassel@kernel•org>
next prev parent reply other threads:[~2024-03-22 11:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 7:47 [PATCH v10 0/8] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host Manivannan Sadhasivam
2024-03-14 7:47 ` [PATCH v10 1/8] " Manivannan Sadhasivam
2024-03-14 7:48 ` [PATCH v10 2/8] PCI: dwc: ep: Add Kernel-doc comments for APIs Manivannan Sadhasivam
2024-03-22 11:02 ` Niklas Cassel
2024-03-14 7:48 ` [PATCH v10 3/8] PCI: dwc: ep: Remove deinit() callback from struct dw_pcie_ep_ops Manivannan Sadhasivam
2024-03-14 7:48 ` [PATCH v10 4/8] PCI: dwc: ep: Rename dw_pcie_ep_exit() to dw_pcie_ep_deinit() Manivannan Sadhasivam
2024-03-14 7:48 ` [PATCH v10 5/8] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST# Manivannan Sadhasivam
2024-03-14 7:48 ` [PATCH v10 6/8] PCI: dwc: ep: Rename dw_pcie_ep_init_complete() to dw_pcie_ep_init_registers() Manivannan Sadhasivam
2024-03-14 7:48 ` [PATCH v10 7/8] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Manivannan Sadhasivam
2024-03-22 11:03 ` Niklas Cassel [this message]
2024-03-14 7:48 ` [PATCH v10 8/8] PCI: dwc: ep: Remove "core_init_notifier" flag Manivannan Sadhasivam
2024-03-22 11:53 ` Niklas Cassel
2024-03-25 14:17 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zf1la9ICDCHAyOit@ryzen \
--to=cassel@kernel$(echo .)org \
--cc=bhelgaas@google$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=gustavo.pimentel@synopsys$(echo .)com \
--cc=hayashi.kunihiko@socionext$(echo .)com \
--cc=hongxing.zhu@nxp$(echo .)com \
--cc=jesper.nilsson@axis$(echo .)com \
--cc=jingoohan1@gmail$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=kishon@kernel$(echo .)org \
--cc=kishon@ti$(echo .)com \
--cc=kw@linux$(echo .)com \
--cc=l.stach@pengutronix$(echo .)de \
--cc=linux-arm-kernel@axis$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lpieralisi@kernel$(echo .)org \
--cc=manivannan.sadhasivam@linaro$(echo .)org \
--cc=marek.vasut+renesas@gmail$(echo .)com \
--cc=mhiramat@kernel$(echo .)org \
--cc=minghuan.Lian@nxp$(echo .)com \
--cc=mingkai.hu@nxp$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=roy.zang@nxp$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=srikanth.thokala@intel$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=vidyas@nvidia$(echo .)com \
--cc=vigneshr@ti$(echo .)com \
--cc=yoshihiro.shimoda.uh@renesas$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox