From: Niklas Cassel <cassel@kernel•org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro•org>
Cc: "Krzysztof Wilczyński" <kw@linux•com>,
"Vignesh Raghavendra" <vigneshr@ti•com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext•com>,
linux-pci@vger•kernel.org,
"Lorenzo Pieralisi" <lpieralisi@kernel•org>,
"Minghuan Lian" <minghuan.Lian@nxp•com>,
"Thierry Reding" <thierry.reding@gmail•com>,
"Fabio Estevam" <festevam@gmail•com>,
"Marek Vasut" <marek.vasut+renesas@gmail•com>,
"Kishon Vijay Abraham I" <kishon@kernel•org>,
"Rob Herring" <robh@kernel•org>,
"Jesper Nilsson" <jesper.nilsson@axis•com>,
linux-tegra@vger•kernel.org, linux-arm-kernel@axis•com,
"Jonathan Hunter" <jonathanh@nvidia•com>,
linux-rockchip@lists•infradead.org,
"NXP Linux Team" <linux-imx@nxp•com>,
"Shawn Lin" <shawn.lin@rock-chips•com>,
"Richard Zhu" <hongxing.zhu@nxp•com>,
"Srikanth Thokala" <srikanth.thokala@intel•com>,
linux-arm-msm@vger•kernel.org,
"Sascha Hauer" <s.hauer@pengutronix•de>,
linuxppc-dev@lists•ozlabs.org,
"Bjorn Helgaas" <bhelgaas@google•com>,
linux-omap@vger•kernel.org, "Mingkai Hu" <mingkai.hu@nxp•com>
Subject: Re: [PATCH v12 8/8] PCI: endpoint: Remove "core_init_notifier" flag
Date: Wed, 27 Mar 2024 10:41:39 +0100 [thread overview]
Message-ID: <ZgPp020vefFw3pGk@ryzen> (raw)
In-Reply-To: <20240327-pci-dbi-rework-v12-8-082625472414@linaro.org>
On Wed, Mar 27, 2024 at 02:43:37PM +0530, Manivannan Sadhasivam wrote:
> "core_init_notifier" flag is set by the glue drivers requiring refclk from
> the host to complete the DWC core initialization. Also, those drivers will
> send a notification to the EPF drivers once the initialization is fully
> completed using the pci_epc_init_notify() API. Only then, the EPF drivers
> will start functioning.
>
> For the rest of the drivers generating refclk locally, EPF drivers will
> start functioning post binding with them. EPF drivers rely on the
> 'core_init_notifier' flag to differentiate between the drivers.
> Unfortunately, this creates two different flows for the EPF drivers.
>
> So to avoid that, let's get rid of the "core_init_notifier" flag and follow
> a single initialization flow for the EPF drivers. This is done by calling
> the dw_pcie_ep_init_notify() from all glue drivers after the completion of
> dw_pcie_ep_init_registers() API. This will allow all the glue drivers to
> send the notification to the EPF drivers once the initialization is fully
> completed.
>
> Only difference here is that, the drivers requiring refclk from host will
> send the notification once refclk is received, while others will send it
> during probe time itself.
>
> But this also requires the EPC core driver to deliver the notification
> after EPF driver bind. Because, the glue driver can send the notification
> before the EPF drivers bind() and in those cases the EPF drivers will miss
> the event. To accommodate this, EPC core is now caching the state of the
> EPC initialization in 'init_complete' flag and pci-ep-cfs driver sends the
> notification to EPF drivers based on that after each EPF driver bind.
>
> Tested-by: Niklas Cassel <cassel@kernel•org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro•org>
> ---
Reviewed-by: Niklas Cassel <cassel@kernel•org>
next prev parent reply other threads:[~2024-03-27 9:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 9:13 [PATCH v12 0/8] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host Manivannan Sadhasivam
2024-03-27 9:13 ` [PATCH v12 1/8] " Manivannan Sadhasivam
2024-03-27 9:13 ` [PATCH v12 2/8] PCI: dwc: ep: Add Kernel-doc comments for APIs Manivannan Sadhasivam
2024-04-12 19:58 ` Bjorn Helgaas
2024-04-15 14:00 ` Manivannan Sadhasivam
2024-04-15 14:34 ` Bjorn Helgaas
2024-03-27 9:13 ` [PATCH v12 3/8] PCI: dwc: ep: Remove deinit() callback from struct dw_pcie_ep_ops Manivannan Sadhasivam
2024-03-27 9:13 ` [PATCH v12 4/8] PCI: dwc: ep: Rename dw_pcie_ep_exit() to dw_pcie_ep_deinit() Manivannan Sadhasivam
2024-03-27 9:13 ` [PATCH v12 5/8] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST# Manivannan Sadhasivam
2024-03-27 9:13 ` [PATCH v12 6/8] PCI: dwc: ep: Rename dw_pcie_ep_init_complete() to dw_pcie_ep_init_registers() Manivannan Sadhasivam
2024-03-27 9:13 ` [PATCH v12 7/8] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Manivannan Sadhasivam
2024-03-29 19:16 ` Frank Li
2024-03-27 9:13 ` [PATCH v12 8/8] PCI: endpoint: Remove "core_init_notifier" flag Manivannan Sadhasivam
2024-03-27 9:41 ` Niklas Cassel [this message]
2024-03-29 19:17 ` Frank Li
2024-04-12 20:22 ` Bjorn Helgaas
2024-04-14 10:51 ` Manivannan Sadhasivam
2024-05-17 17:04 ` [PATCH v12 0/8] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgPp020vefFw3pGk@ryzen \
--to=cassel@kernel$(echo .)org \
--cc=bhelgaas@google$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=hayashi.kunihiko@socionext$(echo .)com \
--cc=hongxing.zhu@nxp$(echo .)com \
--cc=jesper.nilsson@axis$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=kishon@kernel$(echo .)org \
--cc=kw@linux$(echo .)com \
--cc=linux-arm-kernel@axis$(echo .)com \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lpieralisi@kernel$(echo .)org \
--cc=manivannan.sadhasivam@linaro$(echo .)org \
--cc=marek.vasut+renesas@gmail$(echo .)com \
--cc=minghuan.Lian@nxp$(echo .)com \
--cc=mingkai.hu@nxp$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawn.lin@rock-chips$(echo .)com \
--cc=srikanth.thokala@intel$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=vigneshr@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox