From: Vinod Koul <vkoul@kernel•org>
To: Linus Walleij <linus.walleij@linaro•org>
Cc: imx@lists•linux.dev, ulf.hansson@linaro•org, oneukum@suse•com,
duncan.sands@free•fr, hayashi.kunihiko@socionext•com,
linux-mmc@vger•kernel.org, aubin.constans@microchip•com,
Frank.Li@nxp•com, linux-hyperv@vger•kernel.org,
linux-mips@vger•kernel.org, paul@crapouillou•net,
linux-tegra@vger•kernel.org, netdev@vger•kernel.org,
maintainers@bluecherrydvr•com, peter.ujfalusi@gmail•com,
manivannan.sadhasivam@linaro•org,
linux-riscv@lists•infradead.org, kys@microsoft•com,
robert.jarzmik@free•fr, haijie1@huawei•com,
linux-renesas-soc@vger•kernel.org, wei.liu@kernel•org,
linux-omap@vger•kernel.org, florian.fainelli@broadcom•com,
linux-rdma@vger•kernel.org, vireshk@kernel•org,
jassisinghbrar@gmail•com, decui@microsoft•com,
HaraldWelte@viatech•com, jernej.skrabec@gmail•com,
jh80.chung@samsung•com, zw@zh-kernel•org, wens@csie•org,
stern@rowland•harvard.edu, linux-arm-msm@vger•kernel.org,
orsonzhai@gmail•com, pierre@ossman•eu, linux-usb@vger•kernel.org,
Eugeniy.Paltsev@synopsys•com, patrice.cho tard@foss•st.com,
asahi@lists•linux.dev, brucechang@via•com.tw,
keescook@chromium•org, oakad@yahoo•com, sven@svenpeter•dev,
rjui@broadcom•com, s.hauer@pengutronix•de,
sean.wang@mediatek•com, linux-actions@lists•infradead.org,
linuxppc-dev@lists•ozlabs.org, haojian.zhuang@gmail•com,
mirq-linux@rere•qmqm.pl, dmaengine@vger•kernel.org,
linux-mediatek@lists•infradead.org,
linux-rpi-kernel@lists•infradead.org,
baolin.wang@linux•alibaba.com, matthias.bgg@gmail•com,
openipmi-developer@lists•sourceforge.net, mchehab@kernel•org,
Allen Pais <apais@linux•microsoft.com>,
linux-arm-kernel@lists•infradead.org,
angelogioacchino.delregno@collabora•com, sbranden@broadcom•com,
logang@deltatee•com, andersson@kernel•org, marcan@marcan•st,
haiyangz@microsoft•com, linux-kernel@vger•kernel.org,
leoyang.li@nxp•com, konrad.dybcio@linaro•org,
linux-sunxi@lists•linux.dev, wangzhou1@hisilicon•com,
linux-s390@vger•kernel.org, mhiramat@kernel•org,
zhang.lyra@gmail•com, tj@kernel•org, manuel.lauss@gmail•com,
linu x-media@vger•kernel.org, shawnguo@kernel•org,
afaerber@suse•de, daniel@zonque•org
Subject: Re: [PATCH 2/9] dma: Convert from tasklet to BH workqueue
Date: Tue, 2 Apr 2024 18:41:22 +0530 [thread overview]
Message-ID: <ZgwD-iScEb9zzB8H@matsya> (raw)
In-Reply-To: <CACRpkdaSBGe0EFm1gK-7qPK4e6T2H1dxFXjhJqO2hWCm1-bNdA@mail.gmail.com>
On 02-04-24, 14:25, Linus Walleij wrote:
> Hi Allen,
>
> thanks for your patch!
>
> On Wed, Mar 27, 2024 at 5:03 PM Allen Pais <apais@linux•microsoft.com> wrote:
>
> > The only generic interface to execute asynchronously in the BH context is
> > tasklet; however, it's marked deprecated and has some design flaws. To
> > replace tasklets, BH workqueue support was recently added. A BH workqueue
> > behaves similarly to regular workqueues except that the queued work items
> > are executed in the BH context.
> >
> > This patch converts drivers/dma/* from tasklet to BH workqueue.
> >
> > Based on the work done by Tejun Heo <tj@kernel•org>
> > Branch: git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-6.10
> >
> > Signed-off-by: Allen Pais <allen.lkml@gmail•com>
> (...)
> > diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
> (...)
> > if (d40c->pending_tx)
> > - tasklet_schedule(&d40c->tasklet);
> > + queue_work(system_bh_wq, &d40c->work);
>
> Why is "my" driver not allowed to use system_bh_highpri_wq?
>
> I can't see the reasoning between some drivers using system_bh_wq
> and others being highpri?
>
> Given the DMA usecase I would expect them all to be high prio.
It didnt use tasklet_hi_schedule(), I guess Allen has done the
conversion of tasklet_schedule -> system_bh_wq and tasklet_hi_schedule
-> system_bh_highpri_wq
Anyway, we are going to use a dma queue so should be better performance
--
~Vinod
next prev parent reply other threads:[~2024-04-02 20:20 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 16:03 [PATCH 0/9] Convert Tasklets to BH Workqueues Allen Pais
2024-03-27 16:03 ` [PATCH 1/9] hyperv: Convert from tasklet to BH workqueue Allen Pais
2024-04-03 16:43 ` Allen
2024-03-27 16:03 ` [PATCH 2/9] dma: " Allen Pais
2024-03-28 5:55 ` Vinod Koul
2024-03-28 10:08 ` Arnd Bergmann
2024-03-28 18:31 ` Vinod Koul
2024-03-28 19:39 ` Allen
2024-03-28 19:49 ` Arnd Bergmann
2024-03-28 20:01 ` Allen
2024-03-29 16:38 ` Vinod Koul
2024-03-29 16:39 ` Vinod Koul
2024-03-28 17:49 ` Allen
2024-04-02 12:25 ` Linus Walleij
2024-04-02 13:11 ` Vinod Koul [this message]
2024-03-27 16:03 ` [PATCH 3/9] IB: " Allen Pais
2024-04-07 18:56 ` Zhu Yanjun
2024-03-27 16:03 ` [PATCH 4/9] USB: " Allen Pais
2024-03-27 16:20 ` Duncan Sands
2024-03-27 16:55 ` Greg KH
2024-03-27 16:58 ` Allen
2024-03-27 17:55 ` Alan Stern
2024-03-28 17:54 ` Allen
2024-03-27 16:03 ` [PATCH 5/9] mailbox: " Allen Pais
2024-03-27 16:03 ` [PATCH 6/9] ipmi: " Allen Pais
2024-03-27 17:58 ` Corey Minyard
2024-03-28 17:52 ` Allen
2024-03-28 19:23 ` Corey Minyard
2024-03-28 19:41 ` Allen
2024-03-28 19:52 ` Corey Minyard
2024-03-28 19:58 ` Allen
2024-03-27 16:03 ` [PATCH 7/9] s390: " Allen Pais
2024-04-02 12:48 ` Alexandra Winter
2024-04-03 13:33 ` Allen
2024-04-08 9:33 ` Heiko Carstens
2024-04-08 10:03 ` Harald Freudenberger
2024-03-27 16:03 ` [PATCH 8/9] drivers/media/*: " Allen Pais
2024-04-24 9:12 ` Hans Verkuil
2024-04-24 16:48 ` Allen Pais
2024-03-27 16:03 ` [PATCH 9/9] mmc: " Allen Pais
2024-03-27 19:35 ` Jernej Škrabec
2024-03-28 10:16 ` Christian Loehle
2024-03-28 17:47 ` Allen
2024-03-28 12:53 ` Ulf Hansson
2024-03-28 13:37 ` Linus Walleij
2024-03-28 16:21 ` Tejun Heo
2024-04-02 10:15 ` Ulf Hansson
2024-04-05 9:28 ` Michał Mirosław
2024-06-03 12:38 ` Aubin Constans
2024-06-03 17:25 ` Allen Pais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgwD-iScEb9zzB8H@matsya \
--to=vkoul@kernel$(echo .)org \
--cc=Eugeniy.Paltsev@synopsys$(echo .)com \
--cc=Frank.Li@nxp$(echo .)com \
--cc=HaraldWelte@viatech$(echo .)com \
--cc=aubin.constans@microchip$(echo .)com \
--cc=decui@microsoft$(echo .)com \
--cc=duncan.sands@free$(echo .)fr \
--cc=florian.fainelli@broadcom$(echo .)com \
--cc=haijie1@huawei$(echo .)com \
--cc=hayashi.kunihiko@socionext$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=jassisinghbrar@gmail$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jh80.chung@samsung$(echo .)com \
--cc=kys@microsoft$(echo .)com \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=maintainers@bluecherrydvr$(echo .)com \
--cc=manivannan.sadhasivam@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oneukum@suse$(echo .)com \
--cc=orsonzhai@gmail$(echo .)com \
--cc=paul@crapouillou$(echo .)net \
--cc=peter.ujfalusi@gmail$(echo .)com \
--cc=pierre@ossman$(echo .)eu \
--cc=robert.jarzmik@free$(echo .)fr \
--cc=stern@rowland$(echo .)harvard.edu \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=vireshk@kernel$(echo .)org \
--cc=wei.liu@kernel$(echo .)org \
--cc=wens@csie$(echo .)org \
--cc=zw@zh-kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox