From: Mike Rapoport <rppt@kernel•org>
To: Masami Hiramatsu <masami.hiramatsu@gmail•com>
Cc: "Mark Rutland" <mark.rutland@arm•com>,
x86@kernel•org, "Catalin Marinas" <catalin.marinas@arm•com>,
linux-mips@vger•kernel.org, "Song Liu" <song@kernel•org>,
"Donald Dutile" <ddutile@redhat•com>,
"Luis Chamberlain" <mcgrof@kernel•org>,
sparclinux@vger•kernel.org, linux-riscv@lists•infradead.org,
"Nadav Amit" <nadav.amit@gmail•com>,
linux-arch@vger•kernel.org, linux-s390@vger•kernel.org,
"Helge Deller" <deller@gmx•de>,
"Huacai Chen" <chenhuacai@kernel•org>,
"Russell King" <linux@armlinux•org.uk>,
linux-trace-kernel@vger•kernel.org,
"Alexandre Ghiti" <alexghiti@rivosinc•com>,
"Will Deacon" <will@kernel•org>,
"Heiko Carstens" <hca@linux•ibm.com>,
"Steven Rostedt" <rostedt@goodmis•org>,
loongarch@lists•linux.dev, "Thomas Gleixner" <tglx@linutronix•de>,
bpf@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
"Thomas Bogendoerfer" <tsbogend@alpha•franken.de>,
linux-parisc@vger•kernel.org,
"Puranjay Mohan" <puranjay12@gmail•com>,
linux-mm@kvack•org, netdev@vger•kernel.org,
"Kent Overstreet" <kent.overstreet@linux•dev>,
linux-kernel@vger•kernel.org, "Dinh Nguyen" <dinguyen@kernel•org>,
"Björn Töpel" <bjorn@kernel•org>,
"Eric Chanudet" <echanude@redhat•com>,
"Palmer Dabbelt" <palmer@dabbelt•com>,
"Andrew Morton" <akpm@linux-foundation•org>,
"Rick Edgecombe" <rick.p.edgecombe@intel•com>,
linuxppc-dev@lists•ozlabs.org,
"David S. Miller" <davem@davemloft•net>,
linux-modules@vger•kernel.org
Subject: Re: [PATCH v4 14/15] kprobes: remove dependency on CONFIG_MODULES
Date: Thu, 18 Apr 2024 18:37:52 +0300 [thread overview]
Message-ID: <ZiE-UE27NalI-IeW@kernel.org> (raw)
In-Reply-To: <20240418061615.5fad23b954bf317c029acc4d@gmail.com>
Hi Masami,
On Thu, Apr 18, 2024 at 06:16:15AM +0900, Masami Hiramatsu wrote:
> Hi Mike,
>
> On Thu, 11 Apr 2024 19:00:50 +0300
> Mike Rapoport <rppt@kernel•org> wrote:
>
> > From: "Mike Rapoport (IBM)" <rppt@kernel•org>
> >
> > kprobes depended on CONFIG_MODULES because it has to allocate memory for
> > code.
> >
> > Since code allocations are now implemented with execmem, kprobes can be
> > enabled in non-modular kernels.
> >
> > Add #ifdef CONFIG_MODULE guards for the code dealing with kprobes inside
> > modules, make CONFIG_KPROBES select CONFIG_EXECMEM and drop the
> > dependency of CONFIG_KPROBES on CONFIG_MODULES.
>
> Thanks for this work, but this conflicts with the latest fix in v6.9-rc4.
> Also, can you use IS_ENABLED(CONFIG_MODULES) instead of #ifdefs in
> function body? We have enough dummy functions for that, so it should
> not make a problem.
I'll rebase and will try to reduce ifdefery where possible.
> Thank you,
>
> >
> > Signed-off-by: Mike Rapoport (IBM) <rppt@kernel•org>
> > ---
> > arch/Kconfig | 2 +-
> > kernel/kprobes.c | 43 +++++++++++++++++++++----------------
> > kernel/trace/trace_kprobe.c | 11 ++++++++++
> > 3 files changed, 37 insertions(+), 19 deletions(-)
> >
>
> --
> Masami Hiramatsu
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2024-04-18 15:39 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 16:00 [PATCH v4 00/15] mm: jit/text allocator Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 01/15] arm64: module: remove uneeded call to kasan_alloc_module_shadow() Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 02/15] mips: module: rename MODULE_START to MODULES_VADDR Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 03/15] nios2: define virtual address space for modules Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 04/15] module: make module_memory_{alloc,free} more self-contained Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() Mike Rapoport
2024-04-11 19:42 ` Luis Chamberlain
2024-04-14 6:53 ` Mike Rapoport
2024-04-12 9:16 ` Ingo Molnar
2024-04-14 6:54 ` Mike Rapoport
2024-04-15 7:52 ` Peter Zijlstra
2024-04-15 16:51 ` Mike Rapoport
2024-04-15 17:36 ` Mark Rutland
2024-04-16 7:22 ` Mike Rapoport
2024-04-17 23:32 ` Song Liu
2024-04-18 15:35 ` Mike Rapoport
2024-04-18 16:13 ` Song Liu
2024-04-18 17:52 ` Mike Rapoport
2024-04-18 21:01 ` Song Liu
2024-04-19 6:55 ` Mike Rapoport
2024-04-19 15:54 ` Song Liu
2024-04-19 17:02 ` Mike Rapoport
2024-04-19 17:32 ` Song Liu
2024-04-19 19:59 ` Mike Rapoport
2024-04-19 21:42 ` Song Liu
2024-04-20 4:22 ` Mike Rapoport
2024-04-20 9:11 ` Masami Hiramatsu
2024-04-22 18:32 ` Song Liu
2024-04-17 21:06 ` Masami Hiramatsu
2024-04-11 16:00 ` [PATCH v4 06/15] mm/execmem, arch: convert simple overrides of module_alloc to execmem Mike Rapoport
2024-04-11 20:53 ` Sam Ravnborg
2024-04-14 7:26 ` Mike Rapoport
2024-04-15 8:03 ` Peter Zijlstra
2024-04-11 16:00 ` [PATCH v4 07/15] mm/execmem, arch: convert remaining " Mike Rapoport
2024-04-15 9:36 ` Peter Zijlstra
2024-04-11 16:00 ` [PATCH v4 08/15] arm64: extend execmem_info for generated code allocations Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 09/15] riscv: extend execmem_params " Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 10/15] powerpc: extend execmem_params for kprobes allocations Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 11/15] arch: make execmem setup available regardless of CONFIG_MODULES Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 12/15] x86/ftrace: enable dynamic ftrace without CONFIG_MODULES Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 13/15] powerpc: use CONFIG_EXECMEM instead of CONFIG_MODULES where appropiate Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 14/15] kprobes: remove dependency on CONFIG_MODULES Mike Rapoport
2024-04-17 21:16 ` Masami Hiramatsu
2024-04-18 15:37 ` Mike Rapoport [this message]
2024-04-19 15:49 ` Mike Rapoport
2024-04-19 15:59 ` Christophe Leroy
2024-04-20 7:33 ` Mike Rapoport
2024-04-20 9:15 ` Masami Hiramatsu
2024-04-20 10:52 ` Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 15/15] bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of Mike Rapoport
2024-04-11 18:00 ` [PATCH v4 00/15] mm: jit/text allocator Kent Overstreet
2024-04-11 19:45 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiE-UE27NalI-IeW@kernel.org \
--to=rppt@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexghiti@rivosinc$(echo .)com \
--cc=bjorn@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=ddutile@redhat$(echo .)com \
--cc=deller@gmx$(echo .)de \
--cc=dinguyen@kernel$(echo .)org \
--cc=echanude@redhat$(echo .)com \
--cc=hca@linux$(echo .)ibm.com \
--cc=kent.overstreet@linux$(echo .)dev \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-modules@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-trace-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=loongarch@lists$(echo .)linux.dev \
--cc=mark.rutland@arm$(echo .)com \
--cc=masami.hiramatsu@gmail$(echo .)com \
--cc=mcgrof@kernel$(echo .)org \
--cc=nadav.amit@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=palmer@dabbelt$(echo .)com \
--cc=puranjay12@gmail$(echo .)com \
--cc=rick.p.edgecombe@intel$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=song@kernel$(echo .)org \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox