public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google•com>
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei•com>
Cc: "x86@kernel•org" <x86@kernel•org>,
	"kvm@vger•kernel.org" <kvm@vger•kernel.org>,
	Peter Zijlstra <peterz@infradead•org>,
	Catalin Marinas <catalin.marinas@arm•com>,
	Dave Hansen <dave.hansen@linux•intel.com>,
	"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
	Alexander Gordeev <agordeev@linux•ibm.com>,
	Claudio Imbrenda <imbrenda@linux•ibm.com>,
	Will Deacon <will@kernel•org>,
	"linux-riscv@lists•infradead.org"
	<linux-riscv@lists•infradead.org>,
	"linux-s390@vger•kernel.org" <linux-s390@vger•kernel.org>,
	Janosch Frank <frankja@linux•ibm.com>,
	Harald Freudenberger <freude@linux•ibm.com>,
	Marc Zyngier <maz@kernel•org>,
	Huacai Chen <chenhuacai@kernel•org>,
	Halil Pasic <pasic@linux•ibm.com>,
	Andrew Thornton <andrewth@google•com>,
	Ingo Molnar <mingo@redhat•com>,
	Christian Borntraeger <borntraeger@linux•ibm.com>,
	Jason Herne <jjherne@linux•ibm.com>,
	Albert Ou <aou@eecs•berkeley.edu>,
	Vasily Gorbik <gor@linux•ibm.com>,
	Venkatesh Srinivas <venkateshs@chromium•org>,
	Heiko Carstens <hca@linux•ibm.com>,
	Arnaldo Carvalho de Melo <acme@kernel•org>,
	Alex Williamson <alex.williamson@redhat•com>,
	Borislav Petkov <bp@alien8•de>, Andy Lutomirski <luto@kernel•org>,
	Paul Walmsley <paul.walmsley@sifive•com>,
	"kvmarm@lists•linux.dev" <kvmarm@lists•linux.dev>,
	Thomas Gleixner <tglx@linutronix•de>,
	"linux-arm-kernel@lists•infradead.org"
	<linux-arm-kernel@lists•infradead.org>,
	Tony Krowiak <akrowiak@linux•ibm.com>,
	Anish Ghulati <aghulati@google•com>,
	"linux-mips@vger•kernel.org" <linux-mips@vger•kernel.org>,
	Oliver Upton <oliver.upton@linux•dev>,
	"linux-perf-users@vger•kernel.org"
	<linux-perf-users@vger•kernel.org>,
	Palmer Dabbelt <palmer@dabbelt•com>,
	"kvm-riscv@lists•infradead.org" <kvm-riscv@lists•infradead.org>,
	Anup Patel <anup@brainfault•org>,
	Paolo Bonzini <pbonzini@redhat•com>,
	"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH 00/26] KVM: vfio: Hide KVM internals from others
Date: Mon, 24 Jun 2024 08:32:18 -0700	[thread overview]
Message-ID: <ZnmRgqD6FmXNNzzI@google.com> (raw)
In-Reply-To: <504fa0a7264d4762afda2f13c3525ce5@huawei.com>

On Thu, Jun 20, 2024, Shameerali Kolothum Thodi wrote:
> > This is a borderline RFC series to hide KVM's internals from the rest of
> > the kernel, where "internals" means data structures, enums, #defines,
> > APIs, etc. that are intended to be KVM-only, but are exposed everywhere
> > due to kvm_host.h (and other headers) living in the global include paths.
>
> Hi Sean,
> 
> Just thought of checking with you on this series. Do you have plans to revive this
> series?

Yep!

> The reason I am asking is, on ARM64/KVM side we do have a requirement
> to share the KVM VMID with SMMUV3. Please see the RFC I sent out earlier this
> year[1]. The series basically provides a way for KVM to pin a VMID and also
> associates an iommufd ctx with a struct kvm * to retrieve that VMID. 
> 
> As mentioned above, some of the patches in this series(especially 1-4 & 6) that
> does the VFIO cleanups and dropping CONFIG_KVM_VFIO looks very straightforward
> and useful. I am thinking of including those when I re-spin my RFC series, if
> that’s ok.

Please don't include them, as the patch they build towards (patch 5) is buggy[*],
and I am fairly certain that at least some of the patches will change significantly.

I expect to re-start working on the series in ~2 weeks, and am planning on actively
pushing the series (i.e. not ignoring it for months on end).

[*] https://lore.kernel.org/all/ZWp_q1w01NCZi8KX@google.com

> Please let me know your thoughts.
>
> [1]. https://lore.kernel.org/linux-iommu/20240209115824.GA2922446@myrica 

  reply	other threads:[~2024-06-24 15:33 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-16  0:30 [PATCH 00/26] KVM: vfio: Hide KVM internals from others Sean Christopherson
2023-09-16  0:30 ` [PATCH 01/26] vfio: Wrap KVM helpers with CONFIG_KVM instead of CONFIG_HAVE_KVM Sean Christopherson
2023-09-18 15:16   ` Jason Gunthorpe
2023-09-28 22:21   ` Alex Williamson
2023-09-16  0:30 ` [PATCH 02/26] vfio: Move KVM get/put helpers to colocate it with other KVM related code Sean Christopherson
2023-09-18 15:17   ` Jason Gunthorpe
2023-09-28 22:21   ` Alex Williamson
2023-09-16  0:30 ` [PATCH 03/26] virt: Declare and define vfio_file_set_kvm() iff CONFIG_KVM is enabled Sean Christopherson
2023-09-18 15:18   ` Jason Gunthorpe
2023-09-28 22:21   ` Alex Williamson
2023-09-16  0:30 ` [PATCH 04/26] vfio: Add struct to hold KVM assets and dedup group vs. iommufd code Sean Christopherson
2023-09-28 22:21   ` Alex Williamson
2023-09-16  0:30 ` [PATCH 05/26] vfio: KVM: Pass get/put helpers from KVM to VFIO, don't do circular lookup Sean Christopherson
2023-09-18 15:21   ` Jason Gunthorpe
2023-09-18 15:49     ` Sean Christopherson
2023-09-18 16:02       ` Jason Gunthorpe
2023-12-02  0:51         ` Sean Christopherson
2023-12-03 14:07           ` Jason Gunthorpe
2023-12-13  2:22             ` Sean Christopherson
2023-09-28 22:21   ` Alex Williamson
2023-09-16  0:30 ` [PATCH 06/26] KVM: Drop CONFIG_KVM_VFIO and just look at KVM+VFIO Sean Christopherson
2023-09-18 15:29   ` Jason Gunthorpe
2023-09-18 15:52     ` Sean Christopherson
2023-09-18 16:17       ` Jason Gunthorpe
2023-09-28 22:21   ` Alex Williamson
2023-09-16  0:30 ` [PATCH 07/26] x86/idt: Wrap KVM logic with CONFIG_KVM instead of CONFIG_HAVE_KVM Sean Christopherson
2023-09-16  0:31 ` [PATCH 08/26] KVM: x86: Stop selecting and depending on HAVE_KVM Sean Christopherson
2023-09-16  0:31 ` [PATCH 09/26] KVM: arm64: " Sean Christopherson
2023-09-16  0:31 ` [PATCH 10/26] KVM: s390: " Sean Christopherson
2023-09-18 13:38   ` Claudio Imbrenda
2023-09-16  0:31 ` [PATCH 11/26] KVM: MIPS: Make HAVE_KVM a MIPS-only Kconfig Sean Christopherson
2023-09-16  0:31 ` [PATCH 12/26] KVM: arm64: Move arm_{psci,hypercalls}.h to an internal KVM path Sean Christopherson
2023-09-16  0:31 ` [PATCH 13/26] KVM: arm64: Include KVM headers to get forward declarations Sean Christopherson
2023-09-16  0:31 ` [PATCH 14/26] KVM: arm64: Move ARM specific headers in include/kvm to arch directory Sean Christopherson
2023-09-16  0:31 ` [PATCH 15/26] KVM: Move include/kvm/iodev.h to include/linux as kvm_iodev.h Sean Christopherson
2023-12-14  6:02   ` Anup Patel
2023-09-16  0:31 ` [PATCH 16/26] KVM: MIPS: Stop adding virt/kvm to the arch include path Sean Christopherson
2023-09-16  0:31 ` [PATCH 17/26] KVM: PPC: " Sean Christopherson
2023-09-16  0:31 ` [PATCH 18/26] KVM: s390: " Sean Christopherson
2023-09-18  6:56   ` Thomas Huth
2023-09-18 13:38   ` Claudio Imbrenda
2023-09-16  0:31 ` [PATCH 19/26] KVM: Standardize include paths across all architectures Sean Christopherson
2023-12-14  6:04   ` Anup Patel
2023-09-16  0:31 ` [PATCH 20/26] perf/x86: KVM: Have perf define a dedicated struct for getting guest PEBS data Sean Christopherson
2023-09-16  0:31 ` [PATCH 21/26] entry/kvm: Drop @vcpu param from arch_xfer_to_guest_mode_handle_work() Sean Christopherson
2023-09-16  0:31 ` [PATCH 22/26] entry/kvm: KVM: Move KVM details related to signal/-EINTR into KVM proper Sean Christopherson
2023-12-14  6:13   ` Anup Patel
2023-09-16  0:31 ` [PATCH 23/26] KVM: arm64: Move and consolidate "public" functions in asm/kvm_host.h Sean Christopherson
2023-09-16  0:31 ` [PATCH 24/26] powerpc/xics: Move declaration of xics_wake_cpu() out of kvm_ppc.h Sean Christopherson
2023-09-16  0:31 ` [PATCH 25/26] KVM: PPC: Rearrange code in kvm_ppc.h to isolate "public" information Sean Christopherson
2023-09-16  0:31 ` [PATCH 26/26] KVM: Hide KVM internal data structures and values from kernel at-large Sean Christopherson
2023-12-14  6:20   ` Anup Patel
2024-06-20 10:10 ` [PATCH 00/26] KVM: vfio: Hide KVM internals from others Shameerali Kolothum Thodi
2024-06-24 15:32   ` Sean Christopherson [this message]
2024-06-24 19:21     ` Shameerali Kolothum Thodi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZnmRgqD6FmXNNzzI@google.com \
    --to=seanjc@google$(echo .)com \
    --cc=acme@kernel$(echo .)org \
    --cc=aghulati@google$(echo .)com \
    --cc=agordeev@linux$(echo .)ibm.com \
    --cc=akrowiak@linux$(echo .)ibm.com \
    --cc=alex.williamson@redhat$(echo .)com \
    --cc=andrewth@google$(echo .)com \
    --cc=anup@brainfault$(echo .)org \
    --cc=aou@eecs$(echo .)berkeley.edu \
    --cc=borntraeger@linux$(echo .)ibm.com \
    --cc=bp@alien8$(echo .)de \
    --cc=catalin.marinas@arm$(echo .)com \
    --cc=chenhuacai@kernel$(echo .)org \
    --cc=dave.hansen@linux$(echo .)intel.com \
    --cc=frankja@linux$(echo .)ibm.com \
    --cc=freude@linux$(echo .)ibm.com \
    --cc=gor@linux$(echo .)ibm.com \
    --cc=hca@linux$(echo .)ibm.com \
    --cc=imbrenda@linux$(echo .)ibm.com \
    --cc=jjherne@linux$(echo .)ibm.com \
    --cc=kvm-riscv@lists$(echo .)infradead.org \
    --cc=kvm@vger$(echo .)kernel.org \
    --cc=kvmarm@lists$(echo .)linux.dev \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-mips@vger$(echo .)kernel.org \
    --cc=linux-perf-users@vger$(echo .)kernel.org \
    --cc=linux-riscv@lists$(echo .)infradead.org \
    --cc=linux-s390@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=luto@kernel$(echo .)org \
    --cc=maz@kernel$(echo .)org \
    --cc=mingo@redhat$(echo .)com \
    --cc=oliver.upton@linux$(echo .)dev \
    --cc=palmer@dabbelt$(echo .)com \
    --cc=pasic@linux$(echo .)ibm.com \
    --cc=paul.walmsley@sifive$(echo .)com \
    --cc=pbonzini@redhat$(echo .)com \
    --cc=peterz@infradead$(echo .)org \
    --cc=shameerali.kolothum.thodi@huawei$(echo .)com \
    --cc=tglx@linutronix$(echo .)de \
    --cc=venkateshs@chromium$(echo .)org \
    --cc=will@kernel$(echo .)org \
    --cc=x86@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox