From: Sean Christopherson <seanjc@google•com>
To: David Matlack <dmatlack@google•com>
Cc: kvm@vger•kernel.org, David Hildenbrand <david@redhat•com>,
Paul Walmsley <paul.walmsley@sifive•com>,
linux-riscv@lists•infradead.org,
Claudio Imbrenda <imbrenda@linux•ibm.com>,
Janosch Frank <frankja@linux•ibm.com>,
Marc Zyngier <maz@kernel•org>,
Huacai Chen <chenhuacai@kernel•org>,
Zenghui Yu <yuzenghui@huawei•com>,
Palmer Dabbelt <palmer@dabbelt•com>,
Christian Borntraeger <borntraeger@linux•ibm.com>,
Albert Ou <aou@eecs•berkeley.edu>,
Suzuki K Poulose <suzuki.poulose@arm•com>,
Nicholas Piggin <npiggin@gmail•com>,
Bibo Mao <maobibo@loongson•cn>,
loongarch@lists•linux.dev, Atish Patra <atishp@atishpatra•org>,
kvmarm@lists•linux.dev, linux-arm-kernel@lists•infradead.org,
linux-mips@vger•kernel.org, Oliver Upton <oliver.upton@linux•dev>,
James Morse <james.morse@arm•com>,
kvm-riscv@lists•infradead.org, Anup Patel <anup@brainfault•org>,
Paolo Bonzini <pbonzini@redhat•com>,
Tianrui Zhao <zhaotianrui@loongson•cn>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v3 0/3] KVM: Set vcpu->preempted/ready iff scheduled out while running
Date: Wed, 10 Jul 2024 08:51:51 -0700 [thread overview]
Message-ID: <Zo6uFz187FBYnQiY@google.com> (raw)
In-Reply-To: <CALzav=cwu3M2nLHwZLCTF=eGWx2Nq+=TuHMuGTfZCNa27mLs1A@mail.gmail.com>
On Mon, Jul 01, 2024, David Matlack wrote:
> On Tue, Jun 18, 2024 at 2:41 PM Sean Christopherson <seanjc@google•com> wrote:
> >
> > On Fri, 03 May 2024 11:17:31 -0700, David Matlack wrote:
> > > This series changes KVM to mark a vCPU as preempted/ready if-and-only-if
> > > it's scheduled out while running. i.e. Do not mark a vCPU
> > > preempted/ready if it's scheduled out during a non-KVM_RUN ioctl() or
> > > when userspace is doing KVM_RUN with immediate_exit=true.
> > >
> > > This is a logical extension of commit 54aa83c90198 ("KVM: x86: do not
> > > set st->preempted when going back to user space"), which stopped
> > > marking a vCPU as preempted when returning to userspace. But if userspace
> > > invokes a KVM vCPU ioctl() that gets preempted, the vCPU will be marked
> > > preempted/ready. This is arguably incorrect behavior since the vCPU was
> > > not actually preempted while the guest was running, it was preempted
> > > while doing something on behalf of userspace.
> > >
> > > [...]
> >
> > Applied to kvm-x86 generic, with minor changelog tweaks (me thinks you've been
> > away from upstream too long ;-) ). Thanks!
>
> Thanks for the cleanups. Looks like you replaced "[Tt]his commit"
> throughout. Anything else (so I can avoid the same mistakes in the
> future)?
I don't think so? The "This commit" stuff is the only thing that I remember, so
any other tweaks can't be that important :-)
prev parent reply other threads:[~2024-07-10 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 18:17 [PATCH v3 0/3] KVM: Set vcpu->preempted/ready iff scheduled out while running David Matlack
2024-05-03 18:17 ` [PATCH v3 1/3] KVM: Introduce vcpu->wants_to_run David Matlack
2024-05-03 18:17 ` [PATCH v3 2/3] KVM: Ensure new code that references immediate_exit gets extra scrutiny David Matlack
2024-05-03 18:17 ` [PATCH v3 3/3] KVM: Mark a vCPU as preempted/ready iff it's scheduled out while running David Matlack
2024-06-18 21:41 ` [PATCH v3 0/3] KVM: Set vcpu->preempted/ready iff " Sean Christopherson
2024-07-01 17:51 ` David Matlack
2024-07-10 15:51 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zo6uFz187FBYnQiY@google.com \
--to=seanjc@google$(echo .)com \
--cc=anup@brainfault$(echo .)org \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=atishp@atishpatra$(echo .)org \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=david@redhat$(echo .)com \
--cc=dmatlack@google$(echo .)com \
--cc=frankja@linux$(echo .)ibm.com \
--cc=imbrenda@linux$(echo .)ibm.com \
--cc=james.morse@arm$(echo .)com \
--cc=kvm-riscv@lists$(echo .)infradead.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kvmarm@lists$(echo .)linux.dev \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=loongarch@lists$(echo .)linux.dev \
--cc=maobibo@loongson$(echo .)cn \
--cc=maz@kernel$(echo .)org \
--cc=npiggin@gmail$(echo .)com \
--cc=oliver.upton@linux$(echo .)dev \
--cc=palmer@dabbelt$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=pbonzini@redhat$(echo .)com \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=yuzenghui@huawei$(echo .)com \
--cc=zhaotianrui@loongson$(echo .)cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox