From: "Jason A. Donenfeld" <Jason@zx2c4•com>
To: Christophe Leroy <christophe.leroy@csgroup•eu>
Cc: Theodore Ts'o <tytso@mit•edu>, Arnd Bergmann <arnd@arndb•de>,
Andy Lutomirski <luto@kernel•org>,
Thomas Gleixner <tglx@linutronix•de>,
Vincenzo Frascino <vincenzo.frascino@arm•com>,
Ingo Molnar <mingo@redhat•com>, Borislav Petkov <bp@alien8•de>,
Dave Hansen <dave.hansen@linux•intel.com>,
x86@kernel•org, "H. Peter Anvin" <hpa@zytor•com>,
linux-kernel@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-arch@vger•kernel.org
Subject: Re: [PATCH 2/4] random: vDSO: Don't use PAGE_SIZE and PAGE_MASK
Date: Tue, 27 Aug 2024 10:23:50 +0200 [thread overview]
Message-ID: <Zs2NFjfBKKjfoI2d@zx2c4.com> (raw)
In-Reply-To: <55a7d3ba-b384-4fb0-8fbb-e05ddf0d1fb8@csgroup.eu>
On Tue, Aug 27, 2024 at 10:16:18AM +0200, Christophe Leroy wrote:
> tglx or yourself suggested to put in a one of the vdso headers instead
> of directly in getrandom.c. This is too fragile because PAGE_SIZE might
> be absent in that header but arrive in getrandom.c through another header.
Oh jeeze, yea.
FYI, _PAGE_SIZE is defined on s390, so that might not be such a good
idea (from the previous version).
> The best would be to have an asm-generic definition of
> PAGE_SIZE and PAGE_MASK that all architectures use, but that's another
> level of work.
Yea that seems far too large of an operation to do here.
> > I'm really not a fan of making the code less idiomatic...
>
> Ok, I have another idea, let's give it a try.
What's the other idea?
next prev parent reply other threads:[~2024-08-27 8:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 7:31 [PATCH 0/4] Fixups for random vDSO Christophe Leroy
2024-08-27 7:31 ` [PATCH 1/4] asm-generic/unaligned.h: Extract common header for vDSO Christophe Leroy
2024-08-27 7:31 ` [PATCH 2/4] random: vDSO: Don't use PAGE_SIZE and PAGE_MASK Christophe Leroy
2024-08-27 7:49 ` Jason A. Donenfeld
2024-08-27 8:16 ` Christophe Leroy
2024-08-27 8:23 ` Jason A. Donenfeld [this message]
2024-08-27 8:26 ` [PATCH] random: vDSO: Redefine " Christophe Leroy
2024-08-27 8:40 ` Jason A. Donenfeld
2024-08-27 8:55 ` Christophe Leroy
2024-08-27 9:59 ` Arnd Bergmann
2024-08-27 10:49 ` Christophe Leroy
2024-08-27 16:05 ` Vincenzo Frascino
2024-08-27 17:14 ` Christophe Leroy
2024-08-29 12:01 ` Vincenzo Frascino
2024-08-29 15:00 ` Christophe Leroy
2024-08-29 15:34 ` Vincenzo Frascino
2024-08-27 17:38 ` LEROY Christophe
2024-08-29 14:07 ` Vincenzo Frascino
2024-08-27 7:31 ` [PATCH 3/4] random: vDSO: Clean header inclusion in getrandom Christophe Leroy
2024-08-27 7:31 ` [PATCH 4/4] random: vDSO: don't use 64 bits atomics on 32 bits architectures Christophe Leroy
2024-08-27 8:03 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zs2NFjfBKKjfoI2d@zx2c4.com \
--to=jason@zx2c4$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=bp@alien8$(echo .)de \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=hpa@zytor$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=luto@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=tytso@mit$(echo .)edu \
--cc=vincenzo.frascino@arm$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox