From: "Jason A. Donenfeld" <Jason@zx2c4•com>
To: Christophe Leroy <christophe.leroy@csgroup•eu>
Cc: Andrew Morton <akpm@linux-foundation•org>,
Steven Rostedt <rostedt@goodmis•org>,
Masami Hiramatsu <mhiramat@kernel•org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios•com>,
Michael Ellerman <mpe@ellerman•id.au>,
Nicholas Piggin <npiggin@gmail•com>,
Naveen N Rao <naveen@kernel•org>,
Nathan Chancellor <nathan@kernel•org>,
Nick Desaulniers <ndesaulniers@google•com>,
Bill Wendling <morbo@google•com>,
Justin Stitt <justinstitt@google•com>,
Shuah Khan <shuah@kernel•org>,
linux-kernel@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-kselftest@vger•kernel.org, llvm@lists•linux.dev,
linux-fsdevel@vger•kernel.org, linux-mm@kvack•org,
linux-trace-kernel@vger•kernel.org,
Adhemerval Zanella <adhemerval.zanella@linaro•org>,
Xi Ruoyao <xry111@xry111•site>
Subject: Re: [PATCH v5 0/5] Wire up getrandom() vDSO implementation on powerpc
Date: Wed, 4 Sep 2024 16:16:54 +0200 [thread overview]
Message-ID: <Zthr1nB_RJ56YD3O@zx2c4.com> (raw)
In-Reply-To: <cover.1725304404.git.christophe.leroy@csgroup.eu>
Hi Christophe, Michael,
On Mon, Sep 02, 2024 at 09:17:17PM +0200, Christophe Leroy wrote:
> This series wires up getrandom() vDSO implementation on powerpc.
>
> Tested on PPC32 on real hardware.
> Tested on PPC64 (both BE and LE) on QEMU:
>
> Performance on powerpc 885:
> ~# ./vdso_test_getrandom bench-single
> vdso: 25000000 times in 62.938002291 seconds
> libc: 25000000 times in 535.581916866 seconds
> syscall: 25000000 times in 531.525042806 seconds
>
> Performance on powerpc 8321:
> ~# ./vdso_test_getrandom bench-single
> vdso: 25000000 times in 16.899318858 seconds
> libc: 25000000 times in 131.050596522 seconds
> syscall: 25000000 times in 129.794790389 seconds
>
> Performance on QEMU pseries:
> ~ # ./vdso_test_getrandom bench-single
> vdso: 25000000 times in 4.977777162 seconds
> libc: 25000000 times in 75.516749981 seconds
> syscall: 25000000 times in 86.842242014 seconds
Looking good. I have no remaining nits on this patchset; it looks good
to me.
A review from Michael would be nice though (in addition to the necessary
"Ack" I need to commit this to my tree), because there are a lot of PPC
particulars that I don't know enough about to review properly. For
example, you use -ffixed-r30 on PPC64. I'm sure there's a good reason
for this, but I don't know enough to assess it. And cvdso_call I have no
idea what's going on. Etc.
But anyway, awesome work, and I look forward to the final stretches.
Jason
next prev parent reply other threads:[~2024-09-04 14:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 19:17 [PATCH v5 0/5] Wire up getrandom() vDSO implementation on powerpc Christophe Leroy
2024-09-02 19:17 ` [PATCH v5 1/5] mm: Define VM_DROPPABLE for powerpc/32 Christophe Leroy
2024-09-02 19:17 ` [PATCH v5 2/5] powerpc/vdso32: Add crtsavres Christophe Leroy
2024-09-02 19:17 ` [PATCH v5 3/5] powerpc/vdso: Refactor CFLAGS for CVDSO build Christophe Leroy
2024-09-02 19:17 ` [PATCH v5 4/5] powerpc/vdso: Wire up getrandom() vDSO implementation on VDSO32 Christophe Leroy
2024-09-05 16:13 ` Jason A. Donenfeld
2024-09-05 16:25 ` Jason A. Donenfeld
2024-09-05 16:55 ` Christophe Leroy
2024-09-05 17:01 ` Xi Ruoyao
2024-09-05 17:03 ` Jason A. Donenfeld
2024-09-05 17:16 ` Jason A. Donenfeld
2024-09-05 20:41 ` Jason A. Donenfeld
2024-09-06 2:48 ` Jason A. Donenfeld
2024-09-06 3:24 ` Jason A. Donenfeld
2024-09-06 4:53 ` Christophe Leroy
2024-09-02 19:17 ` [PATCH v5 5/5] powerpc/vdso: Wire up getrandom() vDSO implementation on VDSO64 Christophe Leroy
2024-09-04 11:46 ` Madhavan Srinivasan
2024-09-04 14:16 ` Jason A. Donenfeld [this message]
2024-09-04 14:36 ` [PATCH v5 0/5] Wire up getrandom() vDSO implementation on powerpc Christophe Leroy
2024-09-05 12:18 ` Michael Ellerman
2024-09-05 12:56 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zthr1nB_RJ56YD3O@zx2c4.com \
--to=jason@zx2c4$(echo .)com \
--cc=adhemerval.zanella@linaro$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=justinstitt@google$(echo .)com \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-trace-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=llvm@lists$(echo .)linux.dev \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=mhiramat@kernel$(echo .)org \
--cc=morbo@google$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=nathan@kernel$(echo .)org \
--cc=naveen@kernel$(echo .)org \
--cc=ndesaulniers@google$(echo .)com \
--cc=npiggin@gmail$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=shuah@kernel$(echo .)org \
--cc=xry111@xry111$(echo .)site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox