Subject: Re: [PATCH 3/6] Consolidate of_find_property

From: Segher Boessenkool <[email-masked]>
Date: Wed, 25 Apr 2007 02:43:44 +0200

>> The only change here is that a readlock is taken while the property 
>> list
>> is being traversed on Sparc where it was not taken previously.
>>
>> Also, Sparc uses strcasecmp to compare property names while PowerPC
>> uses strcmp.
>
> Ok, so that's the opposite as the previous one... property names are
> supposed to be case sensitive though, no ?

The OF standard doesn't allow upper case in property
names at all.

> I don't think we would take much risk on ppc by
> using strncasecmp but it shouldn't be necessary...

There are some examples where upper case is actually
used in property names, unfortunately.  These can
be solved by renaming/copying those properties to
all lower case in a bootwrapper, or by strcmp() to
the "cased" string, or by strcasecmp().  I for one
don't like either option, you figure it out ;-)

Segher