Subject: Re: [PATCH 1/3] mm: change vm_get_page_prot() to accept vm_flags_t argument

From: Oscar Salvador <[email-masked]>
Date: Thu, 19 Jun 2025 14:12:49 +0200

On Wed, Jun 18, 2025 at 08:42:52PM +0100, Lorenzo Stoakes wrote:
> We abstract the type of the VMA flags to vm_flags_t, however in may places
                                                                  many?
> it is simply assumed this is unsigned long, which is simply incorrect.
> 
> At the moment this is simply an incongruity, however in future we plan to
> change this type and therefore this change is a critical requirement for
> doing so.
> 
> Overall, this patch does not introduce any functional change.
> 
> Signed-off-by: Lorenzo Stoakes <[email-masked]>

Reviewed-by: Oscar Salvador <[email-masked]>

Same comments as Vlastimil, you want to push vmflag_to_pte_pkey_bits
further to patch#2 and bring 

arch/powerpc/mm/book3s64/pgtable.c:pgprot_t vm_get_page_prot(unsigned long vm_flags)

-- 
Oscar Salvador
SUSE Labs