* [PATCH 0/2] powerpc: Fix backlight include fallout
@ 2025-10-27 14:05 Thomas Zimmermann
2025-10-27 14:05 ` [PATCH 1/2] powermac: backlight: Include <linux/of.h> Thomas Zimmermann
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2025-10-27 14:05 UTC (permalink / raw)
To: naresh.kamboju, maddy, mpe, npiggin, christophe.leroy, lee,
danielt, jingoohan1
Cc: linuxppc-dev, linux-kernel, dri-devel, Thomas Zimmermann
Fix the fallout from a recent cleanup of the backlight header.
Thomas Zimmermann (2):
powermac: backlight: Include <linux/of.h>
macintosh/via-pmu-backlight: Include <linux/fb.h> and <linux/of.h>
arch/powerpc/platforms/powermac/backlight.c | 1 +
drivers/macintosh/via-pmu-backlight.c | 2 ++
2 files changed, 3 insertions(+)
--
2.51.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] powermac: backlight: Include <linux/of.h>
2025-10-27 14:05 [PATCH 0/2] powerpc: Fix backlight include fallout Thomas Zimmermann
@ 2025-10-27 14:05 ` Thomas Zimmermann
2025-10-27 14:05 ` [PATCH 2/2] macintosh/via-pmu-backlight: Include <linux/fb.h> and <linux/of.h> Thomas Zimmermann
2025-10-28 12:30 ` [PATCH 0/2] powerpc: Fix backlight include fallout Daniel Thompson
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2025-10-27 14:05 UTC (permalink / raw)
To: naresh.kamboju, maddy, mpe, npiggin, christophe.leroy, lee,
danielt, jingoohan1
Cc: linuxppc-dev, linux-kernel, dri-devel, Thomas Zimmermann,
Simona Vetter
Include <linux/of.h> to avoid dependency on backlight header to include
it. Declares of_find_node_by_name(), of_property_match_string() and
of_node_put().
Signed-off-by: Thomas Zimmermann <tzimmermann@suse•de>
Fixes: 243ce64b2b37 ("backlight: Do not include <linux/fb.h> in header file")
Reported-by: Naresh Kamboju <naresh.kamboju@linaro•org>
Closes: https://lore.kernel.org/linuxppc-dev/CA+G9fYs8fn5URQx2+s2oNxdUgZkSrdLC0P1tNBW_n-6BaBkK2Q@mail.gmail.com/
Cc: Thomas Zimmermann <tzimmermann@suse•de>
Cc: Daniel Thompson (RISCstar) <danielt@kernel•org>
Cc: Simona Vetter <simona.vetter@ffwll•ch>
Cc: Lee Jones <lee@kernel•org>
Cc: Daniel Thompson <danielt@kernel•org>
Cc: Jingoo Han <jingoohan1@gmail•com>
Cc: dri-devel@lists•freedesktop.org
---
arch/powerpc/platforms/powermac/backlight.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/powermac/backlight.c b/arch/powerpc/platforms/powermac/backlight.c
index 79741370c40c..1796327955c6 100644
--- a/arch/powerpc/platforms/powermac/backlight.c
+++ b/arch/powerpc/platforms/powermac/backlight.c
@@ -11,6 +11,7 @@
#include <linux/kernel.h>
#include <linux/backlight.h>
#include <linux/adb.h>
+#include <linux/of.h>
#include <linux/pmu.h>
#include <linux/atomic.h>
#include <linux/export.h>
--
2.51.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] macintosh/via-pmu-backlight: Include <linux/fb.h> and <linux/of.h>
2025-10-27 14:05 [PATCH 0/2] powerpc: Fix backlight include fallout Thomas Zimmermann
2025-10-27 14:05 ` [PATCH 1/2] powermac: backlight: Include <linux/of.h> Thomas Zimmermann
@ 2025-10-27 14:05 ` Thomas Zimmermann
2025-10-28 12:30 ` [PATCH 0/2] powerpc: Fix backlight include fallout Daniel Thompson
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2025-10-27 14:05 UTC (permalink / raw)
To: naresh.kamboju, maddy, mpe, npiggin, christophe.leroy, lee,
danielt, jingoohan1
Cc: linuxppc-dev, linux-kernel, dri-devel, Thomas Zimmermann,
Simona Vetter
Include <linux/fb.h> and <linux/of.h> to avoid dependency on backlight
header to include them. Declares of_machine_is_compatible() and defines
FB_BACKLIGHT_MAX.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse•de>
Fixes: 243ce64b2b37 ("backlight: Do not include <linux/fb.h> in header file")
Reported-by: Naresh Kamboju <naresh.kamboju@linaro•org>
Closes: https://lore.kernel.org/linuxppc-dev/CA+G9fYs8fn5URQx2+s2oNxdUgZkSrdLC0P1tNBW_n-6BaBkK2Q@mail.gmail.com/
Cc: Thomas Zimmermann <tzimmermann@suse•de>
Cc: Daniel Thompson (RISCstar) <danielt@kernel•org>
Cc: Simona Vetter <simona.vetter@ffwll•ch>
Cc: Lee Jones <lee@kernel•org>
Cc: Daniel Thompson <danielt@kernel•org>
Cc: Jingoo Han <jingoohan1@gmail•com>
Cc: dri-devel@lists•freedesktop.org
---
drivers/macintosh/via-pmu-backlight.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c
index 26bd9ed5e664..d91825bb0a5c 100644
--- a/drivers/macintosh/via-pmu-backlight.c
+++ b/drivers/macintosh/via-pmu-backlight.c
@@ -11,6 +11,8 @@
#include <asm/ptrace.h>
#include <linux/adb.h>
#include <linux/backlight.h>
+#include <linux/fb.h>
+#include <linux/of.h>
#include <linux/pmu.h>
#include <asm/backlight.h>
--
2.51.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] powerpc: Fix backlight include fallout
2025-10-27 14:05 [PATCH 0/2] powerpc: Fix backlight include fallout Thomas Zimmermann
2025-10-27 14:05 ` [PATCH 1/2] powermac: backlight: Include <linux/of.h> Thomas Zimmermann
2025-10-27 14:05 ` [PATCH 2/2] macintosh/via-pmu-backlight: Include <linux/fb.h> and <linux/of.h> Thomas Zimmermann
@ 2025-10-28 12:30 ` Daniel Thompson
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Thompson @ 2025-10-28 12:30 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: naresh.kamboju, maddy, mpe, npiggin, christophe.leroy, lee,
jingoohan1, linuxppc-dev, linux-kernel, dri-devel
On Mon, Oct 27, 2025 at 03:05:39PM +0100, Thomas Zimmermann wrote:
> Fix the fallout from a recent cleanup of the backlight header.
>
> Thomas Zimmermann (2):
> powermac: backlight: Include <linux/of.h>
> macintosh/via-pmu-backlight: Include <linux/fb.h> and <linux/of.h>
>
> arch/powerpc/platforms/powermac/backlight.c | 1 +
> drivers/macintosh/via-pmu-backlight.c | 2 ++
> 2 files changed, 3 insertions(+)
I noticed that both these directory trees are orphaned.
Anyone have any thoughts about what tree these should be delivered via?
Either way, FWIW:
Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel•org>
Daniel.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-28 21:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-27 14:05 [PATCH 0/2] powerpc: Fix backlight include fallout Thomas Zimmermann
2025-10-27 14:05 ` [PATCH 1/2] powermac: backlight: Include <linux/of.h> Thomas Zimmermann
2025-10-27 14:05 ` [PATCH 2/2] macintosh/via-pmu-backlight: Include <linux/fb.h> and <linux/of.h> Thomas Zimmermann
2025-10-28 12:30 ` [PATCH 0/2] powerpc: Fix backlight include fallout Daniel Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox