From: Lukas Wunner <lukas@wunner•de>
To: Bjorn Helgaas <helgaas@kernel•org>
Cc: "Rafael J. Wysocki" <rafael@kernel•org>,
Riana Tauro <riana.tauro@intel•com>,
"Sean C. Dardis" <sean.c.dardis@intel•com>,
Farhan Ali <alifm@linux•ibm.com>,
Benjamin Block <bblock@linux•ibm.com>,
Niklas Schnelle <schnelle@linux•ibm.com>,
Alek Du <alek.du@intel•com>,
Mahesh J Salgaonkar <mahesh@linux•ibm.com>,
Oliver OHalloran <oohall@gmail•com>,
linuxppc-dev@lists•ozlabs.org, linux-pci@vger•kernel.org,
Giovanni Cabiddu <giovanni.cabiddu@intel•com>,
qat-linux@intel•com, Dave Jiang <dave.jiang@intel•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Jiri Slaby <jirislaby@kernel•org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership•com>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>
Subject: Re: [PATCH 1/2] PCI: Ensure error recoverability at all times
Date: Fri, 21 Nov 2025 18:40:23 +0100 [thread overview]
Message-ID: <aSCkB7C5EF2BVdfM@wunner.de> (raw)
In-Reply-To: <20251113161556.GA2284238@bhelgaas>
On Thu, Nov 13, 2025 at 10:15:56AM -0600, Bjorn Helgaas wrote:
> On Thu, Nov 13, 2025 at 10:38:09AM +0100, Lukas Wunner wrote:
> > On Wed, Nov 12, 2025 at 04:38:31PM -0600, Bjorn Helgaas wrote:
> > > On Sun, Oct 12, 2025 at 03:25:01PM +0200, Lukas Wunner wrote:
> > > It would be nice if there were a few more
> > > words about pci_save_state() and pci_restore_state() in
> > > Documentation/.
> > >
> > > pci_save_state() isn't mentioned at all in Documentation/PCI
> >
> > Right, it's documented in the Documentation/power directory. :)
>
> Yes, in the pci.rst I mentioned, but it mostly uses the "saves the
> device's standard configuration registers" wording.
>
> I'm just wishing for a more concrete mention of "pci_save_state()",
> since that's where the critical "state_saved" flag is updated.
Hm, Documentation/power/pci.rst does contain this:
"Then, pci_save_state(), pci_prepare_to_sleep(), and
pci_set_power_state() should be used to save the device’s
standard configuration registers, to prepare it for system wakeup
(if necessary), and to put it into a low-power state, respectively."
I'm struggling to find a better way to phrase it.
> And I'm not sure Documentation/ includes anything about the idea of
> a driver using pci_save_state() to capture the state it wants to
> restore after an error.
Right, while pci_save_state() usage is mentioned in the PCI power
management documentation, it's not mentioned at all in the error
recovery context. So I'm proposing this amendment:
https://lore.kernel.org/r/077596ba70202be0e43fdad3bb9b93d356cbe4ec.1763746079.git.lukas@wunner.de/
Thanks,
Lukas
next prev parent reply other threads:[~2025-11-21 17:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-12 13:25 [PATCH 0/2] PCI: Universal error recoverability of devices Lukas Wunner
2025-10-12 13:25 ` [PATCH 1/2] PCI: Ensure error recoverability at all times Lukas Wunner
2025-11-12 22:38 ` Bjorn Helgaas
2025-11-13 9:38 ` Lukas Wunner
2025-11-13 16:15 ` Bjorn Helgaas
2025-11-14 18:58 ` Lukas Wunner
2025-11-14 23:39 ` Bjorn Helgaas
2025-11-19 10:02 ` Lukas Wunner
2025-11-21 17:40 ` Lukas Wunner [this message]
2025-11-24 22:11 ` Bjorn Helgaas
2025-11-13 20:49 ` Rafael J. Wysocki
2025-11-13 21:03 ` Rafael J. Wysocki
2025-10-12 13:25 ` [PATCH 2/2] treewide: Drop pci_save_state() after pci_restore_state() Lukas Wunner
2025-11-05 14:22 ` Dave Jiang
2025-11-05 14:33 ` Giovanni Cabiddu
2025-11-24 23:13 ` Bjorn Helgaas
2025-11-14 23:45 ` [PATCH 0/2] PCI: Universal error recoverability of devices Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSCkB7C5EF2BVdfM@wunner.de \
--to=lukas@wunner$(echo .)de \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=alek.du@intel$(echo .)com \
--cc=alifm@linux$(echo .)ibm.com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=bblock@linux$(echo .)ibm.com \
--cc=dave.jiang@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=giovanni.cabiddu@intel$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=helgaas@kernel$(echo .)org \
--cc=jirislaby@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mahesh@linux$(echo .)ibm.com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=oohall@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=qat-linux@intel$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=riana.tauro@intel$(echo .)com \
--cc=schnelle@linux$(echo .)ibm.com \
--cc=sean.c.dardis@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox