From: Mike Rapoport <rppt@kernel•org>
To: Alexander Gordeev <agordeev@linux•ibm.com>
Cc: Andrew Morton <akpm@linux-foundation•org>,
Alex Shi <alexs@kernel•org>,
Andreas Larsson <andreas@gaisler•com>,
Borislav Petkov <bp@alien8•de>, Brian Cain <bcain@kernel•org>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel•org>,
Catalin Marinas <catalin.marinas@arm•com>,
"David S. Miller" <davem@davemloft•net>,
Dave Hansen <dave.hansen@linux•intel.com>,
David Hildenbrand <david@kernel•org>,
Dinh Nguyen <dinguyen@kernel•org>,
Geert Uytterhoeven <geert@linux-m68k•org>,
Guo Ren <guoren@kernel•org>, Heiko Carstens <hca@linux•ibm.com>,
Helge Deller <deller@gmx•de>, Huacai Chen <chenhuacai@kernel•org>,
Ingo Molnar <mingo@redhat•com>,
Johannes Berg <johannes@sipsolutions•net>,
John Paul Adrian Glaubitz <glaubitz@physik•fu-berlin.de>,
Jonathan Corbet <corbet@lwn•net>,
Klara Modin <klarasmodin@gmail•com>,
"Liam R. Howlett" <Liam.Howlett@oracle•com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle•com>,
Magnus Lindholm <linmag7@gmail•com>,
Matt Turner <mattst88@gmail•com>,
Max Filippov <jcmvbkbc@gmail•com>,
Michael Ellerman <mpe@ellerman•id.au>,
Michal Hocko <mhocko@suse•com>, Michal Simek <monstr@monstr•eu>,
Muchun Song <muchun.song@linux•dev>,
Oscar Salvador <osalvador@suse•de>,
Palmer Dabbelt <palmer@dabbelt•com>,
Pratyush Yadav <pratyush@kernel•org>,
Richard Weinberger <richard@nod•at>,
Ritesh Harjani <ritesh.list@gmail•com>,
Russell King <linux@armlinux•org.uk>,
Stafford Horne <shorne@gmail•com>,
Suren Baghdasaryan <surenb@google•com>,
Thomas Bogendoerfer <tsbogend@alpha•franken.de>,
Thomas Gleixner <tglx@linutronix•de>,
Vasily Gorbik <gor@linux•ibm.com>,
Vineet Gupta <vgupta@kernel•org>,
Vlastimil Babka <vbabka@suse•cz>, Will Deacon <will@kernel•org>,
x86@kernel•org, linux-alpha@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, linux-csky@vger•kernel.org,
linux-cxl@vger•kernel.org, linux-doc@vger•kernel.org,
linux-hexagon@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-m68k@lists•linux-m68k.org, linux-mips@vger•kernel.org,
linux-mm@kvack•org, linux-openrisc@vger•kernel.org,
linux-parisc@vger•kernel.org, linux-riscv@lists•infradead.org,
linux-s390@vger•kernel.org, linux-sh@vger•kernel.org,
linux-snps-arc@lists•infradead.org, linux-um@lists•infradead.org,
linuxppc-dev@lists•ozlabs.org, loongarch@lists•linux.dev,
sparclinux@vger•kernel.org
Subject: Re: [PATCH v3 17/29] s390: introduce arch_zone_limits_init()
Date: Mon, 12 Jan 2026 09:34:40 +0200 [thread overview]
Message-ID: <aWSkELL7xJ04QAct@kernel.org> (raw)
In-Reply-To: <b211f877-f9bb-4892-b67c-d2610048575a-agordeev@linux.ibm.com>
Hi,
On Mon, Jan 12, 2026 at 08:02:48AM +0100, Alexander Gordeev wrote:
> On Sun, Jan 11, 2026 at 10:20:51AM +0200, Mike Rapoport wrote:
>
> Hi Mike,
>
> ...
> > +void __init arch_zone_limits_init(unsigned long *max_zone_pfns)
> > +{
> > + max_zone_pfns[ZONE_DMA] = virt_to_pfn(MAX_DMA_ADDRESS);
> > + max_zone_pfns[ZONE_NORMAL] = max_low_pfn;
> > +}
> > +
> > /*
> > * paging_init() sets up the page tables
> > */
> > @@ -97,8 +103,7 @@ void __init paging_init(void)
> > sparse_init();
> > zone_dma_limit = DMA_BIT_MASK(31);
> > memset(max_zone_pfns, 0, sizeof(max_zone_pfns));
> > - max_zone_pfns[ZONE_DMA] = virt_to_pfn(MAX_DMA_ADDRESS);
> > - max_zone_pfns[ZONE_NORMAL] = max_low_pfn;
> > + arch_zone_limits_init(max_zone_pfns);
>
> You move initialization of max_zone_pfns[] to a function, name the
> function arch_zone_limits_init(), but leave the initializatio of
> max_zone_pfns[] to zeroes outside. Should not it be brought along?
The idea is that is the caller responsibility to initialize max_zone_pfns
to zero. After patch 24: "arch, mm: consolidate initialization of
SPARSE memory model" there is a single caller of arch_zone_limits_init()
and having initialization of max_zone_pfns() there is more optimal than
having 20-something of those.
> > free_area_init(max_zone_pfns);
> > }
>
> Thanks!
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-01-12 7:35 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 8:20 [PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 01/29] alpha: introduce arch_zone_limits_init() Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 02/29] arc: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 03/29] arm: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 04/29] arm: make initialization of zero page independent of the memory map Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 05/29] arm64: introduce arch_zone_limits_init() Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 06/29] csky: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 07/29] hexagon: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 08/29] loongarch: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 09/29] m68k: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 10/29] microblaze: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 11/29] mips: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 12/29] nios2: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 13/29] openrisc: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 14/29] parisc: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 15/29] powerpc: " Mike Rapoport
2026-01-13 12:29 ` Ritesh Harjani
2026-01-11 8:20 ` [PATCH v3 16/29] riscv: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 17/29] s390: " Mike Rapoport
2026-01-12 7:02 ` Alexander Gordeev
2026-01-12 7:34 ` Mike Rapoport [this message]
2026-01-11 8:20 ` [PATCH v3 18/29] sh: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 19/29] sparc: " Mike Rapoport
2026-01-13 12:28 ` Andreas Larsson
2026-01-11 8:20 ` [PATCH v3 20/29] um: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 21/29] x86: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 22/29] xtensa: " Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 23/29] arch, mm: consolidate initialization of nodes, zones and memory map Mike Rapoport
2026-02-27 15:14 ` Vlastimil Babka
2026-02-27 20:31 ` Mike Rapoport
2026-01-11 8:20 ` [PATCH v3 24/29] arch, mm: consolidate initialization of SPARSE memory model Mike Rapoport
2026-02-25 3:30 ` Ritesh Harjani
2026-02-25 16:25 ` Mike Rapoport
2026-02-25 17:38 ` Ritesh Harjani
2026-01-11 8:20 ` [PATCH v3 25/29] mips: drop paging_init() Mike Rapoport
2026-01-11 8:21 ` [PATCH v3 26/29] x86: don't reserve hugetlb memory in setup_arch() Mike Rapoport
2026-01-11 8:21 ` [PATCH v3 27/29] mm, arch: consolidate hugetlb CMA reservation Mike Rapoport
2026-01-11 8:21 ` [PATCH v3 28/29] mm/hugetlb: drop hugetlb_cma_check() Mike Rapoport
2026-01-11 8:21 ` [PATCH v3 29/29] Revert "mm/hugetlb: deal with multiple calls to hugetlb_bootmem_alloc" Mike Rapoport
2026-01-12 22:23 ` [PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation Andrew Morton
2026-01-13 6:50 ` Kalle Niemi
2026-01-13 8:40 ` Kalle Niemi
2026-02-20 4:10 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWSkELL7xJ04QAct@kernel.org \
--to=rppt@kernel$(echo .)org \
--cc=Liam.Howlett@oracle$(echo .)com \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexs@kernel$(echo .)org \
--cc=andreas@gaisler$(echo .)com \
--cc=bcain@kernel$(echo .)org \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=chleroy@kernel$(echo .)org \
--cc=corbet@lwn$(echo .)net \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=david@kernel$(echo .)org \
--cc=deller@gmx$(echo .)de \
--cc=dinguyen@kernel$(echo .)org \
--cc=geert@linux-m68k$(echo .)org \
--cc=glaubitz@physik$(echo .)fu-berlin.de \
--cc=gor@linux$(echo .)ibm.com \
--cc=guoren@kernel$(echo .)org \
--cc=hca@linux$(echo .)ibm.com \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=klarasmodin@gmail$(echo .)com \
--cc=linmag7@gmail$(echo .)com \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-csky@vger$(echo .)kernel.org \
--cc=linux-cxl@vger$(echo .)kernel.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-openrisc@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux-um@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=loongarch@lists$(echo .)linux.dev \
--cc=lorenzo.stoakes@oracle$(echo .)com \
--cc=mattst88@gmail$(echo .)com \
--cc=mhocko@suse$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=mpe@ellerman$(echo .)id.au \
--cc=muchun.song@linux$(echo .)dev \
--cc=osalvador@suse$(echo .)de \
--cc=palmer@dabbelt$(echo .)com \
--cc=pratyush@kernel$(echo .)org \
--cc=richard@nod$(echo .)at \
--cc=ritesh.list@gmail$(echo .)com \
--cc=shorne@gmail$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=surenb@google$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=vbabka@suse$(echo .)cz \
--cc=vgupta@kernel$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox