From: Niklas Cassel <cassel@kernel•org>
To: Koichiro Den <den@valinux•co.jp>
Cc: jingoohan1@gmail•com, mani@kernel•org, lpieralisi@kernel•org,
kwilczynski@kernel•org, robh@kernel•org, bhelgaas@google•com,
vigneshr@ti•com, s-vadapalli@ti•com, hongxing.zhu@nxp•com,
l.stach@pengutronix•de, shawnguo@kernel•org,
s.hauer@pengutronix•de, kernel@pengutronix•de,
festevam@gmail•com, minghuan.Lian@nxp•com, mingkai.hu@nxp•com,
roy.zang@nxp•com, jesper.nilsson@axis•com, heiko@sntech•de,
srikanth.thokala@intel•com, marek.vasut+renesas@gmail•com,
yoshihiro.shimoda.uh@renesas•com, geert+renesas@glider•be,
magnus.damm@gmail•com, christian.bruel@foss•st.com,
mcoquelin.stm32@gmail•com, alexandre.torgue@foss•st.com,
thierry.reding@gmail•com, jonathanh@nvidia•com,
hayashi.kunihiko@socionext•com, mhiramat@kernel•org,
kishon@kernel•org, jirislaby@kernel•org, rongqianfeng@vivo•com,
18255117159@163•com, shawn.lin@rock-chips•com,
nicolas.frattaroli@collabora•com, linux.amoon@gmail•com,
vidyas@nvidia•com, Frank.Li@nxp•com, linux-omap@vger•kernel.org,
linux-pci@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, imx@lists•linux.dev,
linuxppc-dev@lists•ozlabs.org, linux-arm-kernel@axis•com,
linux-rockchip@lists•infradead.org,
linux-arm-msm@vger•kernel.org, linux-renesas-soc@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-tegra@vger•kernel.org
Subject: Re: [PATCH v5 3/3] PCI: dwc: ep: Support BAR subrange inbound mapping via Address Match Mode iATU
Date: Mon, 12 Jan 2026 12:43:50 +0100 [thread overview]
Message-ID: <aWTedhkOclAVvktO@ryzen> (raw)
In-Reply-To: <wvb42kyfcpyii3jql2gm75dd6hqpcd32yat2yb7cg7sl3raw4l@d4mfxk47l6md>
Hello Koichiro,
On Sat, Jan 10, 2026 at 11:29:06PM +0900, Koichiro Den wrote:
(snip)
> > Your new feature (epc_features->subrange_mapping) in epc_features appears
> > to depend on epc_features->dynamic_inbound_mapping, so it is a shame that
> > we don't have a epc_features->dynamic_inbound_mapping bit, so that this new
> > feature could have depended on that bit.
> >
> > if (epf_bar->use_submap &&
> > !(epc_features->dynamic_inbound_mapping &&
> > epc_features->subrange_mapping))
> > return -EINVAL;
> >
> >
> > I think adding some documentation is a good step.
> >
> > Perhaps we should also introduce a epc_features->dynamic_inbound_mapping bit?
> > Since you are making DWC glue drivers return a mutable EPC features, we could
> > set this bit in the DWC driver after that commit. What do you think?
>
> As you pointed out, support for dynamic_inbound_mapping is needed
> independently of my series. Given that, it would make sense to handle it
> either before this series, or to fold it into the next iteration (=v6) of
> the series if that is preferred.
Please fold it into the next iteration (=v6).
It should be a one liner patch in the DWC driver, at least if you put it
after your "PCI: dwc: Allow glue drivers to return mutable EPC features"
patch.
Thank you for all your efforts on improving the endpoint framework.
Kind regards,
Niklas
next prev parent reply other threads:[~2026-01-12 11:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 17:24 [PATCH v5 0/3] PCI: endpoint: BAR subrange mapping support Koichiro Den
2026-01-08 17:24 ` [PATCH v5 1/3] PCI: endpoint: Add " Koichiro Den
2026-01-08 17:24 ` [PATCH v5 2/3] PCI: dwc: Allow glue drivers to return mutable EPC features Koichiro Den
2026-01-08 17:24 ` [PATCH v5 3/3] PCI: dwc: ep: Support BAR subrange inbound mapping via Address Match Mode iATU Koichiro Den
2026-01-08 20:55 ` Niklas Cassel
2026-01-09 7:29 ` Koichiro Den
2026-01-09 8:30 ` Niklas Cassel
2026-01-10 14:29 ` Koichiro Den
2026-01-12 11:43 ` Niklas Cassel [this message]
2026-01-13 2:40 ` Koichiro Den
2026-01-13 2:18 ` Koichiro Den
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWTedhkOclAVvktO@ryzen \
--to=cassel@kernel$(echo .)org \
--cc=18255117159@163$(echo .)com \
--cc=Frank.Li@nxp$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=bhelgaas@google$(echo .)com \
--cc=christian.bruel@foss$(echo .)st.com \
--cc=den@valinux$(echo .)co.jp \
--cc=festevam@gmail$(echo .)com \
--cc=geert+renesas@glider$(echo .)be \
--cc=hayashi.kunihiko@socionext$(echo .)com \
--cc=heiko@sntech$(echo .)de \
--cc=hongxing.zhu@nxp$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=jesper.nilsson@axis$(echo .)com \
--cc=jingoohan1@gmail$(echo .)com \
--cc=jirislaby@kernel$(echo .)org \
--cc=jonathanh@nvidia$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=kishon@kernel$(echo .)org \
--cc=kwilczynski@kernel$(echo .)org \
--cc=l.stach@pengutronix$(echo .)de \
--cc=linux-arm-kernel@axis$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linux.amoon@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lpieralisi@kernel$(echo .)org \
--cc=magnus.damm@gmail$(echo .)com \
--cc=mani@kernel$(echo .)org \
--cc=marek.vasut+renesas@gmail$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=mhiramat@kernel$(echo .)org \
--cc=minghuan.Lian@nxp$(echo .)com \
--cc=mingkai.hu@nxp$(echo .)com \
--cc=nicolas.frattaroli@collabora$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=rongqianfeng@vivo$(echo .)com \
--cc=roy.zang@nxp$(echo .)com \
--cc=s-vadapalli@ti$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawn.lin@rock-chips$(echo .)com \
--cc=shawnguo@kernel$(echo .)org \
--cc=srikanth.thokala@intel$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=vidyas@nvidia$(echo .)com \
--cc=vigneshr@ti$(echo .)com \
--cc=yoshihiro.shimoda.uh@renesas$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox