From: Niklas Cassel <cassel@kernel•org>
To: Koichiro Den <den@valinux•co.jp>
Cc: jingoohan1@gmail•com, mani@kernel•org, lpieralisi@kernel•org,
kwilczynski@kernel•org, robh@kernel•org, bhelgaas@google•com,
vigneshr@ti•com, s-vadapalli@ti•com, hongxing.zhu@nxp•com,
l.stach@pengutronix•de, shawnguo@kernel•org,
s.hauer@pengutronix•de, kernel@pengutronix•de,
festevam@gmail•com, minghuan.Lian@nxp•com, mingkai.hu@nxp•com,
roy.zang@nxp•com, jesper.nilsson@axis•com, heiko@sntech•de,
srikanth.thokala@intel•com, marek.vasut+renesas@gmail•com,
yoshihiro.shimoda.uh@renesas•com, geert+renesas@glider•be,
magnus.damm@gmail•com, christian.bruel@foss•st.com,
mcoquelin.stm32@gmail•com, alexandre.torgue@foss•st.com,
thierry.reding@gmail•com, jonathanh@nvidia•com,
hayashi.kunihiko@socionext•com, mhiramat@kernel•org,
kishon@kernel•org, jirislaby@kernel•org, rongqianfeng@vivo•com,
18255117159@163•com, shawn.lin@rock-chips•com,
nicolas.frattaroli@collabora•com, linux.amoon@gmail•com,
vidyas@nvidia•com, Frank.Li@nxp•com, linux-omap@vger•kernel.org,
linux-pci@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, imx@lists•linux.dev,
linuxppc-dev@lists•ozlabs.org, linux-arm-kernel@axis•com,
linux-rockchip@lists•infradead.org,
linux-arm-msm@vger•kernel.org, linux-renesas-soc@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-tegra@vger•kernel.org
Subject: Re: [PATCH v6 1/5] PCI: endpoint: Add BAR subrange mapping support
Date: Tue, 13 Jan 2026 11:13:59 +0100 [thread overview]
Message-ID: <aWYa59GgcB7jOfQq@ryzen> (raw)
In-Reply-To: <20260113023715.3463724-2-den@valinux.co.jp>
On Tue, Jan 13, 2026 at 11:37:11AM +0900, Koichiro Den wrote:
> Extend the PCI endpoint core to support mapping subranges within a BAR.
> Introduce a new 'submap' field and a 'use_submap' flag in struct
> pci_epf_bar so an endpoint function driver can request inbound mappings
> that fully cover the BAR.
>
> Add a subrange_mapping feature bit to struct pci_epc_features so EPC
> drivers can explicitly advertise support. Make pci_epc_set_bar() reject
> use_submap requests (-EINVAL) when the EPC does not advertise
> subrange_mapping, to avoid silently accepting a configuration that the
> controller cannot implement.
>
> The submap array describes the complete BAR layout (no overlaps and no
> gaps are allowed to avoid exposing untranslated address ranges). This
> provides the generic infrastructure needed to map multiple logical
> regions into a single BAR at different offsets, without assuming a
> controller-specific inbound address translation mechanism. Also, the
> array must be sorted in ascending order by offset.
>
> Signed-off-by: Koichiro Den <den@valinux•co.jp>
> ---
I think this patch should be after the:
"PCI: endpoint: Add dynamic_inbound_mapping EPC feature"
patch...
> drivers/pci/endpoint/pci-epc-core.c | 3 +++
> include/linux/pci-epc.h | 3 +++
> include/linux/pci-epf.h | 31 +++++++++++++++++++++++++++++
> 3 files changed, 37 insertions(+)
>
> diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c
> index ca7f19cc973a..8d809a2c3ce9 100644
> --- a/drivers/pci/endpoint/pci-epc-core.c
> +++ b/drivers/pci/endpoint/pci-epc-core.c
> @@ -596,6 +596,9 @@ int pci_epc_set_bar(struct pci_epc *epc, u8 func_no, u8 vfunc_no,
> if (!epc_features)
> return -EINVAL;
>
> + if (epf_bar->use_submap && !epc_features->subrange_mapping)
> + return -EINVAL;
...then you can change this condition to:
if (epf_bar->use_submap &&
!(epc_features->dynamic_inbound_mapping &&
epc_features->subrange_mapping))
return -EINVAL;
> +
> if (epc_features->bar[bar].type == BAR_RESIZABLE &&
> (epf_bar->size < SZ_1M || (u64)epf_bar->size > (SZ_128G * 1024)))
> return -EINVAL;
> diff --git a/include/linux/pci-epc.h b/include/linux/pci-epc.h
> index 4286bfdbfdfa..898a29e7d6f7 100644
> --- a/include/linux/pci-epc.h
> +++ b/include/linux/pci-epc.h
> @@ -223,6 +223,8 @@ struct pci_epc_bar_desc {
> /**
> * struct pci_epc_features - features supported by a EPC device per function
> * @linkup_notifier: indicate if the EPC device can notify EPF driver on link up
> + * @subrange_mapping: indicate if the EPC device can map inbound subranges for a
> + * BAR
This text should probably also mention that this feature depends on the
dynamic_inbound_mapping feature.
With those comments fixed, looks good to me:
Reviewed-by: Niklas Cassel <cassel@kernel•org>
next prev parent reply other threads:[~2026-01-13 10:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 2:37 [PATCH v6 0/5] PCI: endpoint: BAR subrange mapping support Koichiro Den
2026-01-13 2:37 ` [PATCH v6 1/5] PCI: endpoint: Add " Koichiro Den
2026-01-13 10:13 ` Niklas Cassel [this message]
2026-01-13 16:07 ` Koichiro Den
2026-01-13 2:37 ` [PATCH v6 2/5] PCI: dwc: Allow glue drivers to return mutable EPC features Koichiro Den
2026-01-13 10:14 ` Niklas Cassel
2026-01-13 2:37 ` [PATCH v6 3/5] PCI: endpoint: Add dynamic_inbound_mapping EPC feature Koichiro Den
2026-01-13 10:12 ` Niklas Cassel
2026-01-13 2:37 ` [PATCH v6 4/5] PCI: dwc: ep: Support BAR subrange inbound mapping via Address Match Mode iATU Koichiro Den
2026-01-13 10:15 ` Niklas Cassel
2026-01-13 10:27 ` Niklas Cassel
2026-01-13 2:37 ` [PATCH v6 5/5] Documentation: PCI: endpoint: Clarify pci_epc_set_bar() usage Koichiro Den
2026-01-13 10:17 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWYa59GgcB7jOfQq@ryzen \
--to=cassel@kernel$(echo .)org \
--cc=18255117159@163$(echo .)com \
--cc=Frank.Li@nxp$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=bhelgaas@google$(echo .)com \
--cc=christian.bruel@foss$(echo .)st.com \
--cc=den@valinux$(echo .)co.jp \
--cc=festevam@gmail$(echo .)com \
--cc=geert+renesas@glider$(echo .)be \
--cc=hayashi.kunihiko@socionext$(echo .)com \
--cc=heiko@sntech$(echo .)de \
--cc=hongxing.zhu@nxp$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=jesper.nilsson@axis$(echo .)com \
--cc=jingoohan1@gmail$(echo .)com \
--cc=jirislaby@kernel$(echo .)org \
--cc=jonathanh@nvidia$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=kishon@kernel$(echo .)org \
--cc=kwilczynski@kernel$(echo .)org \
--cc=l.stach@pengutronix$(echo .)de \
--cc=linux-arm-kernel@axis$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linux.amoon@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lpieralisi@kernel$(echo .)org \
--cc=magnus.damm@gmail$(echo .)com \
--cc=mani@kernel$(echo .)org \
--cc=marek.vasut+renesas@gmail$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=mhiramat@kernel$(echo .)org \
--cc=minghuan.Lian@nxp$(echo .)com \
--cc=mingkai.hu@nxp$(echo .)com \
--cc=nicolas.frattaroli@collabora$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=rongqianfeng@vivo$(echo .)com \
--cc=roy.zang@nxp$(echo .)com \
--cc=s-vadapalli@ti$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawn.lin@rock-chips$(echo .)com \
--cc=shawnguo@kernel$(echo .)org \
--cc=srikanth.thokala@intel$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=vidyas@nvidia$(echo .)com \
--cc=vigneshr@ti$(echo .)com \
--cc=yoshihiro.shimoda.uh@renesas$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox