From: Mike Rapoport <rppt@kernel•org>
To: Jinjie Ruan <ruanjinjie@huawei•com>
Cc: corbet@lwn•net, skhan@linuxfoundation•org,
catalin.marinas@arm•com, will@kernel•org, chenhuacai@kernel•org,
kernel@xen0n•name, maddy@linux•ibm.com, mpe@ellerman•id.au,
npiggin@gmail•com, chleroy@kernel•org, pjw@kernel•org,
palmer@dabbelt•com, aou@eecs•berkeley.edu, alex@ghiti•fr,
tglx@kernel•org, mingo@redhat•com, bp@alien8•de,
dave.hansen@linux•intel.com, hpa@zytor•com,
akpm@linux-foundation•org, bhe@redhat•com, vgoyal@redhat•com,
dyoung@redhat•com, rdunlap@infradead•org, kees@kernel•org,
elver@google•com, paulmck@kernel•org, arnd@arndb•de,
fvdl@google•com, thuth@redhat•com, ardb@kernel•org,
leitao@debian•org, osandov@fb•com, cfsworks@gmail•com,
sourabhjain@linux•ibm.com, ryan.roberts@arm•com,
tangyouling@kylinos•cn, eajames@linux•ibm.com,
hbathini@linux•ibm.com, ritesh.list@gmail•com,
songshuaishuai@tinylab•org, bjorn@rivosinc•com,
samuel.holland@sifive•com, kevin.brodsky@arm•com,
junhui.liu@pigmoral•tech, vishal.moola@gmail•com,
dwmw@amazon•co.uk, pbonzini@redhat•com, kai.huang@intel•com,
ubizjak@gmail•com, coxu@redhat•com, fuqiang.wang@easystack•cn,
liaoyuanhong@vivo•com, brgerst@gmail•com, jbohac@suse•cz,
x86@kernel•org, linux-doc@vger•kernel.org,
linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, loongarch@lists•linux.dev,
linuxppc-dev@lists•ozlabs.org, linux-riscv@lists•infradead.org,
kexec@lists•infradead.org
Subject: Re: [PATCH v5 1/4] powerpc/crash: sort crash memory ranges before preparing elfcorehdr
Date: Thu, 12 Feb 2026 16:43:38 +0200 [thread overview]
Message-ID: <aY3nGuredkMTCZIm@kernel.org> (raw)
In-Reply-To: <20260212101001.343158-2-ruanjinjie@huawei.com>
On Thu, Feb 12, 2026 at 06:09:58PM +0800, Jinjie Ruan wrote:
> From: Sourabh Jain <sourabhjain@linux•ibm.com>
>
> During a memory hot-remove event, the elfcorehdr is rebuilt to exclude
> the removed memory. While updating the crash memory ranges for this
> operation, the crash memory ranges array can become unsorted. This
> happens because remove_mem_range() may split a memory range into two
> parts and append the higher-address part as a separate range at the end
> of the array.
>
> So far, no issues have been observed due to the unsorted crash memory
> ranges. However, this could lead to problems once crash memory range
> removal is handled by generic code, as introduced in the upcoming
> patches in this series.
>
> Currently, powerpc uses a platform-specific function,
> remove_mem_range(), to exclude hot-removed memory from the crash memory
> ranges. This function performs the same task as the generic
> crash_exclude_mem_range() in crash_core.c. The generic helper also
> ensures that the crash memory ranges remain sorted. So remove the
> redundant powerpc-specific implementation and instead call
> crash_exclude_mem_range_guarded() (which internally calls
> crash_exclude_mem_range()) to exclude the hot-removed memory ranges.
>
> Cc: Andrew Morton <akpm@linux-foundation•org>
> Cc: Baoquan he <bhe@redhat•com>
> Cc: Jinjie Ruan <ruanjinjie@huawei•com>
> Cc: Hari Bathini <hbathini@linux•ibm.com>
> Cc: Madhavan Srinivasan <maddy@linux•ibm.com>
> Cc: Mahesh Salgaonkar <mahesh@linux•ibm.com>
> Cc: Michael Ellerman <mpe@ellerman•id.au>
> Cc: Ritesh Harjani (IBM) <ritesh.list@gmail•com>
> Cc: Shivang Upadhyay <shivangu@linux•ibm.com>
> Cc: linux-kernel@vger•kernel.org
> Signed-off-by: Sourabh Jain <sourabhjain@linux•ibm.com>
> ---
> arch/powerpc/include/asm/kexec_ranges.h | 4 +-
> arch/powerpc/kexec/crash.c | 5 +-
> arch/powerpc/kexec/ranges.c | 87 +------------------------
> 3 files changed, 7 insertions(+), 89 deletions(-)
This looks like a nice improvement!
FWIW
Acked-by: Mike Rapoport (Microsoft) <rppt@kernel•org>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-02-12 14:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 10:09 [PATCH v5 0/4] arm64/riscv: Add support for crashkernel CMA reservation Jinjie Ruan
2026-02-12 10:09 ` [PATCH v5 1/4] powerpc/crash: sort crash memory ranges before preparing elfcorehdr Jinjie Ruan
2026-02-12 14:43 ` Mike Rapoport [this message]
2026-02-12 10:09 ` [PATCH v5 2/4] crash: Exclude crash kernel memory in crash core Jinjie Ruan
2026-02-12 18:58 ` Mike Rapoport
2026-02-13 3:02 ` Jinjie Ruan
2026-02-12 10:10 ` [PATCH v5 3/4] arm64: kexec: Add support for crashkernel CMA reservation Jinjie Ruan
2026-02-12 10:10 ` [PATCH v5 4/4] riscv: " Jinjie Ruan
2026-02-13 3:10 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aY3nGuredkMTCZIm@kernel.org \
--to=rppt@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alex@ghiti$(echo .)fr \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=ardb@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=bhe@redhat$(echo .)com \
--cc=bjorn@rivosinc$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=brgerst@gmail$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=cfsworks@gmail$(echo .)com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=chleroy@kernel$(echo .)org \
--cc=corbet@lwn$(echo .)net \
--cc=coxu@redhat$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=dwmw@amazon$(echo .)co.uk \
--cc=dyoung@redhat$(echo .)com \
--cc=eajames@linux$(echo .)ibm.com \
--cc=elver@google$(echo .)com \
--cc=fuqiang.wang@easystack$(echo .)cn \
--cc=fvdl@google$(echo .)com \
--cc=hbathini@linux$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=jbohac@suse$(echo .)cz \
--cc=junhui.liu@pigmoral$(echo .)tech \
--cc=kai.huang@intel$(echo .)com \
--cc=kees@kernel$(echo .)org \
--cc=kernel@xen0n$(echo .)name \
--cc=kevin.brodsky@arm$(echo .)com \
--cc=kexec@lists$(echo .)infradead.org \
--cc=leitao@debian$(echo .)org \
--cc=liaoyuanhong@vivo$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=loongarch@lists$(echo .)linux.dev \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
--cc=osandov@fb$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=paulmck@kernel$(echo .)org \
--cc=pbonzini@redhat$(echo .)com \
--cc=pjw@kernel$(echo .)org \
--cc=rdunlap@infradead$(echo .)org \
--cc=ritesh.list@gmail$(echo .)com \
--cc=ruanjinjie@huawei$(echo .)com \
--cc=ryan.roberts@arm$(echo .)com \
--cc=samuel.holland@sifive$(echo .)com \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=songshuaishuai@tinylab$(echo .)org \
--cc=sourabhjain@linux$(echo .)ibm.com \
--cc=tangyouling@kylinos$(echo .)cn \
--cc=tglx@kernel$(echo .)org \
--cc=thuth@redhat$(echo .)com \
--cc=ubizjak@gmail$(echo .)com \
--cc=vgoyal@redhat$(echo .)com \
--cc=vishal.moola@gmail$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox