From: Yosry Ahmed <yosry@kernel•org>
To: Peter Fang <peter.fang@intel•com>
Cc: Paolo Bonzini <pbonzini@redhat•com>,
Sean Christopherson <seanjc@google•com>,
Madhavan Srinivasan <maddy@linux•ibm.com>,
Nicholas Piggin <npiggin@gmail•com>,
kvm@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-kernel@vger•kernel.org,
KarimAllah Ahmed <karahmed@amazon•de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>
Subject: Re: [PATCH] KVM: Fix kvm_vcpu_map[_readonly]() function prototypes
Date: Tue, 31 Mar 2026 02:22:47 +0000 [thread overview]
Message-ID: <acsvbxIdtlQzUw4q@google.com> (raw)
In-Reply-To: <20260325092001.613025-1-peter.fang@intel.com>
On Wed, Mar 25, 2026 at 02:15:11AM -0700, Peter Fang wrote:
> kvm_vcpu_map() and kvm_vcpu_map_readonly() should take a gfn instead of
> a gpa. This appears to be a result of the original kvm_vcpu_map() being
> declared with the wrong function prototype in kvm_host.h, even though
> it was correct in the actual implementation in kvm_main.c.
>
> No actual harm has been done yet as all of the call sites are correctly
> passing in a gfn. Plus, both gfn_t and gpa_t are typedef'd to u64 so
> this change shouldn't have any functional impact.
>
> Compile-tested on x86 and ppc, which are the current users of these
> interfaces.
>
> Fixes: e45adf665a53 ("KVM: Introduce a new guest mapping API")
> Cc: KarimAllah Ahmed <karahmed@amazon•de>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>
> Signed-off-by: Peter Fang <peter.fang@intel•com>
Most callers are converting a GPA to a GFN, I wonder if we should make
the function take in a GPA instead? But then we'll need to the GPA not
being aligned to a page boundary (either do gpa_to_gfn() in
__kvm_vcpu_map() or fail if it's not aligned).
Not sure if that's a net improvement, mostly thinking out loud here.
next prev parent reply other threads:[~2026-04-01 1:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 9:15 [PATCH] KVM: Fix kvm_vcpu_map[_readonly]() function prototypes Peter Fang
2026-03-31 2:22 ` Yosry Ahmed [this message]
2026-04-01 0:13 ` Fang, Peter
2026-04-02 23:52 ` Sean Christopherson
2026-04-03 10:18 ` Fang, Peter
2026-04-04 9:37 ` Ritesh Harjani
2026-04-06 20:19 ` Peter Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acsvbxIdtlQzUw4q@google.com \
--to=yosry@kernel$(echo .)org \
--cc=karahmed@amazon$(echo .)de \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=npiggin@gmail$(echo .)com \
--cc=pbonzini@redhat$(echo .)com \
--cc=peter.fang@intel$(echo .)com \
--cc=seanjc@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox