Subject: Re: [4/5] powerpc: PA Semi PWRficient platform support

From: Roland Dreier <[email-masked]>
Date: Tue, 05 Sep 2006 12:49:39 -0700

> +#include <linux/config.h>
 > +#include <linux/init.h>
 > +#include <linux/errno.h>
 > +#include <linux/sched.h>
 > +#include <linux/kernel.h>
 > +#include <linux/mm.h>
 > +#include <linux/stddef.h>
 > +#include <linux/unistd.h>
 > +#include <linux/ptrace.h>
 > +#include <linux/slab.h>
 > +#include <linux/user.h>
 > +#include <linux/a.out.h>
 > +#include <linux/tty.h>
 > +#include <linux/string.h>
 > +#include <linux/delay.h>
 > +#include <linux/ioport.h>
 > +#include <linux/major.h>
 > +#include <linux/initrd.h>
 > +#include <linux/vt_kern.h>
 > +#include <linux/console.h>
 > +#include <linux/ide.h>
 > +#include <linux/pci.h>
 > +#include <linux/adb.h>
 > +#include <linux/cuda.h>
 > +#include <linux/pmu.h>
 > +#include <linux/irq.h>
 > +#include <linux/seq_file.h>
 > +#include <linux/root_dev.h>
 > +#include <linux/serial.h>
 > +#include <linux/smp.h>
 > +
 > +#include <asm/processor.h>
 > +#include <asm/sections.h>
 > +#include <asm/prom.h>
 > +#include <asm/system.h>
 > +#include <asm/pgtable.h>
 > +#include <asm/bitops.h>
 > +#include <asm/io.h>
 > +#include <asm/pci-bridge.h>
 > +#include <asm/iommu.h>
 > +#include <asm/machdep.h>
 > +#include <asm/dma.h>
 > +#include <asm/cputable.h>
 > +#include <asm/time.h>
 > +#include <asm/of_device.h>
 > +#include <asm/lmb.h>
 > +#include <asm/mpic.h>
 > +#include <asm/smp.h>
 > +#include <asm/udbg.h>
 > +#include <asm/serial.h>

Are all of these really needed?  Seems rather crazy, considering there
are only 145 lines after this in the file...