public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco•com>
To: Stefan Roscher <ossrosch@linux•vnet.ibm.com>
Cc: "\"Hoang-Nam Nguyen\" @dyn-9-152-249-53"
	<Hoang-Nam.Nguyen@d01av04•pok.ibm.com>,
	linuxppc-dev@ozlabs•org, fenkes@de•ibm.com,
	linux-kernel@vger•kernel.org, openib-general@openib•org
Subject: Re: [ofa-general] [PATCH 7/7] IB/ehca: Prevent overwriting QP init attributes given by caller
Date: Thu, 16 Aug 2007 09:17:22 -0700	[thread overview]
Message-ID: <adatzqz1mjx.fsf@cisco.com> (raw)
In-Reply-To: <200708082044.38247.ossrosch@linux.vnet.ibm.com> (Stefan Roscher's message of "Wed, 8 Aug 2007 20:44:37 +0200")

I don't understand this patch.  <rdma/ib_verbs.h> says this about
ib_create_qp():

 * @qp_init_attr: A list of initial attributes required to create the
 *   QP.  If QP creation succeeds, then the attributes are updated to
 *   the actual capabilities of the created QP.

So it seems the current code is actually correct and your patch breaks
it??

  reply	other threads:[~2007-08-16 16:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-08 18:44 [PATCH 7/7] IB/ehca: Prevent overwriting QP init attributes given by caller Stefan Roscher
2007-08-16 16:17 ` Roland Dreier [this message]
2007-08-16 16:48   ` [ofa-general] " Hoang-Nam Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adatzqz1mjx.fsf@cisco.com \
    --to=rdreier@cisco$(echo .)com \
    --cc=Hoang-Nam.Nguyen@d01av04$(echo .)pok.ibm.com \
    --cc=fenkes@de$(echo .)ibm.com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=openib-general@openib$(echo .)org \
    --cc=ossrosch@linux$(echo .)vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox