From: Roland Dreier <rdreier@cisco•com>
To: Hoang-Nam Nguyen <hnguyen@linux•vnet.ibm.com>
Cc: linuxppc-dev@ozlabs•org, fenkes@de•ibm.com,
stefan.roscher@de•ibm.com, linux-kernel@vger•kernel.org,
openib-general@openib•org
Subject: Re: [ofa-general] [PATCH 5/5] ehca: Support small QP queues
Date: Fri, 20 Jul 2007 21:20:49 -0700 [thread overview]
Message-ID: <adawswu5qvy.fsf@cisco.com> (raw)
In-Reply-To: <200707201604.17991.hnguyen@linux.vnet.ibm.com> (Hoang-Nam Nguyen's message of "Fri, 20 Jul 2007 16:04:17 +0200")
thanks, applied. I fixed this up myself to work with commit 20c2df83,
which got rid of the destructor argument to kmem_cache_create() -- you
probably want to check my tree to make sure it's OK.
Also the same as I said before about checkpatch.pl's warning:
WARNING: externs should be avoided in .c files
#337: FILE: drivers/infiniband/hw/ehca/ehca_pd.c:91:
+ extern struct kmem_cache *small_qp_cache;
please fix that up when you get a chance
prev parent reply other threads:[~2007-07-21 4:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 14:04 [PATCH 5/5] ehca: Support small QP queues Hoang-Nam Nguyen
2007-07-21 4:20 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adawswu5qvy.fsf@cisco.com \
--to=rdreier@cisco$(echo .)com \
--cc=fenkes@de$(echo .)ibm.com \
--cc=hnguyen@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=openib-general@openib$(echo .)org \
--cc=stefan.roscher@de$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox