From: Easwar Hariharan <eahariha@linux•microsoft.com>
To: "Jeff Johnson" <quic_jjohnson@quicinc•com>,
"Pablo Neira Ayuso" <pablo@netfilter•org>,
"Jozsef Kadlecsik" <kadlec@netfilter•org>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Simon Horman" <horms@kernel•org>,
"Julia Lawall" <Julia.Lawall@inria•fr>,
"Nicolas Palix" <nicolas.palix@imag•fr>,
"Daniel Mack" <daniel@zonque•org>,
"Haojian Zhuang" <haojian.zhuang@gmail•com>,
"Robert Jarzmik" <robert.jarzmik@free•fr>,
"Russell King" <linux@armlinux•org.uk>,
"Heiko Carstens" <hca@linux•ibm.com>,
"Vasily Gorbik" <gor@linux•ibm.com>,
"Alexander Gordeev" <agordeev@linux•ibm.com>,
"Christian Borntraeger" <borntraeger@linux•ibm.com>,
"Sven Schnelle" <svens@linux•ibm.com>,
"Ofir Bitton" <obitton@habana•ai>,
"Oded Gabbay" <ogabbay@kernel•org>,
"Lucas De Marchi" <lucas.demarchi@intel•com>,
"Thomas Hellström" <thomas.hellstrom@linux•intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel•com>,
"Maarten Lankhorst" <maarten.lankhorst@linux•intel.com>,
"Maxime Ripard" <mripard@kernel•org>,
"Thomas Zimmermann" <tzimmermann@suse•de>,
"David Airlie" <airlied@gmail•com>,
"Simona Vetter" <simona@ffwll•ch>,
"Jeroen de Borst" <jeroendb@google•com>,
"Praveen Kaligineedi" <pkaligineedi@google•com>,
"Shailend Chand" <shailend@google•com>,
"Andrew Lunn" <andrew+netdev@lunn•ch>,
"James Smart" <james.smart@broadcom•com>,
"Dick Kennedy" <dick.kennedy@broadcom•com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership•com>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
"Roger Pau Monné" <roger.pau@citrix•com>,
"Jens Axboe" <axboe@kernel•dk>, "Kalle Valo" <kvalo@kernel•org>,
"Jeff Johnson" <jjohnson@kernel•org>,
"Catalin Marinas" <catalin.marinas@arm•com>,
"Andrew Morton" <akpm@linux-foundation•org>,
"Jack Wang" <jinpu.wang@cloud•ionos.com>,
"Marcel Holtmann" <marcel@holtmann•org>,
"Johan Hedberg" <johan.hedberg@gmail•com>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail•com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Florian Fainelli" <florian.fainelli@broadcom•com>,
"Ray Jui" <rjui@broadcom•com>,
"Scott Branden" <sbranden@broadcom•com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom•com>,
"Xiubo Li" <xiubli@redhat•com>,
"Ilya Dryomov" <idryomov@gmail•com>,
"Josh Poimboeuf" <jpoimboe@kernel•org>,
"Jiri Kosina" <jikos@kernel•org>,
"Miroslav Benes" <mbenes@suse•cz>,
"Petr Mladek" <pmladek@suse•com>,
"Joe Lawrence" <joe.lawrence@redhat•com>,
"Jaroslav Kysela" <perex@perex•cz>,
"Takashi Iwai" <tiwai@suse•com>,
"Lucas Stach" <l.stach@pengutronix•de>,
"Russell King" <linux+etnaviv@armlinux•org.uk>,
"Christian Gmeiner" <christian.gmeiner@gmail•com>,
"Louis Peens" <louis.peens@corigine•com>,
"Michael Ellerman" <mpe@ellerman•id.au>,
"Nicholas Piggin" <npiggin@gmail•com>,
"Christophe Leroy" <christophe.leroy@csgroup•eu>,
"Naveen N Rao" <naveen@kernel•org>,
"Madhavan Srinivasan" <maddy@linux•ibm.com>
Cc: eahariha@linux•microsoft.com, netfilter-devel@vger•kernel.org,
coreteam@netfilter•org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, cocci@inria•fr,
linux-arm-kernel@lists•infradead.org, linux-s390@vger•kernel.org,
dri-devel@lists•freedesktop.org, intel-xe@lists•freedesktop.org,
linux-scsi@vger•kernel.org, xen-devel@lists•xenproject.org,
linux-block@vger•kernel.org, linux-wireless@vger•kernel.org,
ath11k@lists•infradead.org, linux-mm@kvack•org,
linux-bluetooth@vger•kernel.org, linux-staging@lists•linux.dev,
linux-rpi-kernel@lists•infradead.org, ceph-devel@vger•kernel.org,
live-patching@vger•kernel.org, linux-sound@vger•kernel.org,
etnaviv@lists•freedesktop.org, oss-drivers@corigine•com,
linuxppc-dev@lists•ozlabs.org,
Anna-Maria Behnsen <anna-maria@linutronix•de>,
Michael Kelley <mhklinux@outlook•com>,
Thomas Gleixner <tglx@linutronix•de>,
Luiz Augusto von Dentz <luiz.von.dentz@intel•com>
Subject: Re: [PATCH 22/22] jiffies: Define secs_to_jiffies()
Date: Fri, 15 Nov 2024 13:34:46 -0800 [thread overview]
Message-ID: <ae1f83c3-88fe-4b75-9446-e7e711b954ae@linux.microsoft.com> (raw)
In-Reply-To: <e1ff4b71-7abf-4ac6-8b82-86aad5394de6@quicinc.com>
On 11/15/2024 1:30 PM, Jeff Johnson wrote:
> On 11/15/2024 1:22 PM, Easwar Hariharan wrote:
>> secs_to_jiffies() is defined in hci_event.c and cannot be reused by
>> other call sites. Hoist it into the core code to allow conversion of the
>> ~1150 usages of msecs_to_jiffies() that either:
>>
>> - use a multiplier value of 1000 or equivalently MSEC_PER_SEC, or
>> - have timeouts that are denominated in seconds (i.e. end in 000)
>>
>> It's implemented as a macro to allow usage in static initializers.
>>
>> This will also allow conversion of yet more sites that use (sec * HZ)
>> directly, and improve their readability.
>>
>> Suggested-by: Michael Kelley <mhklinux@outlook•com>
>> Signed-off-by: Easwar Hariharan <eahariha@linux•microsoft.com>
>> Signed-off-by: Thomas Gleixner <tglx@linutronix•de>
>> Reviewed-by: Luiz Augusto von Dentz <luiz.von.dentz@intel•com>
>> Link: https://lore.kernel.org/all/20241030-open-coded-timeouts-v3-1-9ba123facf88@linux.microsoft.com
>
> your signed-off-by should be last.
>
> and you have a patch ordering problem since this patch must come before all
> the patches that use secs_to_jiffies(), otherwise this series cannot be bisected
Thanks for the quick response, indeed this patch is already in tip[1], I
pulled it in for testing the series but missed out on removing it before
sending. Please review v2 that excludes this:
https://lore.kernel.org/all/20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com/
[1]: https://git.kernel.org/tip/b35108a51cf7bab58d7eace1267d7965978bcdb8
Thanks,
Easwar
prev parent reply other threads:[~2024-11-15 22:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 21:22 [PATCH 00/22] Converge on using secs_to_jiffies() Easwar Hariharan
2024-11-15 21:22 ` [PATCH 01/22] netfilter: conntrack: Cleanup timeout definitions Easwar Hariharan
2024-11-15 21:22 ` [PATCH 02/22] coccinelle: misc: Add secs_to_jiffies script Easwar Hariharan
2024-11-15 21:22 ` [PATCH 03/22] arm: pxa: Convert timeouts to use secs_to_jiffies() Easwar Hariharan
2024-11-15 22:38 ` Stephen Rothwell
2024-11-16 0:12 ` Easwar Hariharan
2024-11-15 21:22 ` [PATCH 04/22] s390: kernel: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 05/22] powerpc/papr_scm: Convert timeouts to secs_to_jiffies() Easwar Hariharan
2024-11-15 21:22 ` [PATCH 06/22] mm: kmemleak: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 07/22] accel/habanalabs: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 08/22] drm/xe: Convert timeout " Easwar Hariharan
2024-11-18 11:27 ` Thomas Hellström
2024-11-15 21:22 ` [PATCH 09/22] drm/etnaviv: Convert timeouts " Easwar Hariharan
2024-12-03 17:45 ` Lucas Stach
2024-11-15 21:22 ` [PATCH 10/22] scsi: lpfc: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 11/22] scsi: arcmsr: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 12/22] scsi: pm8001: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 13/22] xen/blkback: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 14/22] gve: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 15/22] wifi: ath11k: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 16/22] Bluetooth: MGMT: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 17/22] staging: vc04_services: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 18/22] ceph: " Easwar Hariharan
2024-11-28 12:29 ` Alex Markuze
2024-11-15 21:22 ` [PATCH 19/22] livepatch: " Easwar Hariharan
2024-11-16 7:59 ` Dan Carpenter
2024-11-15 21:22 ` [PATCH 20/22] ALSA: line6: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 21/22] nfp: " Easwar Hariharan
2024-11-15 21:22 ` [PATCH 22/22] jiffies: Define secs_to_jiffies() Easwar Hariharan
2024-11-15 21:30 ` Jeff Johnson
2024-11-15 21:34 ` Easwar Hariharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae1f83c3-88fe-4b75-9446-e7e711b954ae@linux.microsoft.com \
--to=eahariha@linux$(echo .)microsoft.com \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=Julia.Lawall@inria$(echo .)fr \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=airlied@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anna-maria@linutronix$(echo .)de \
--cc=ath11k@lists$(echo .)infradead.org \
--cc=axboe@kernel$(echo .)dk \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=ceph-devel@vger$(echo .)kernel.org \
--cc=christian.gmeiner@gmail$(echo .)com \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=cocci@inria$(echo .)fr \
--cc=coreteam@netfilter$(echo .)org \
--cc=daniel@zonque$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dick.kennedy@broadcom$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=edumazet@google$(echo .)com \
--cc=etnaviv@lists$(echo .)freedesktop.org \
--cc=florian.fainelli@broadcom$(echo .)com \
--cc=gor@linux$(echo .)ibm.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=haojian.zhuang@gmail$(echo .)com \
--cc=hca@linux$(echo .)ibm.com \
--cc=horms@kernel$(echo .)org \
--cc=idryomov@gmail$(echo .)com \
--cc=intel-xe@lists$(echo .)freedesktop.org \
--cc=james.smart@broadcom$(echo .)com \
--cc=jeroendb@google$(echo .)com \
--cc=jikos@kernel$(echo .)org \
--cc=jinpu.wang@cloud$(echo .)ionos.com \
--cc=jjohnson@kernel$(echo .)org \
--cc=joe.lawrence@redhat$(echo .)com \
--cc=johan.hedberg@gmail$(echo .)com \
--cc=jpoimboe@kernel$(echo .)org \
--cc=kadlec@netfilter$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@kernel$(echo .)org \
--cc=l.stach@pengutronix$(echo .)de \
--cc=linux+etnaviv@armlinux$(echo .)org.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-bluetooth@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux-sound@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=live-patching@vger$(echo .)kernel.org \
--cc=louis.peens@corigine$(echo .)com \
--cc=lucas.demarchi@intel$(echo .)com \
--cc=luiz.dentz@gmail$(echo .)com \
--cc=luiz.von.dentz@intel$(echo .)com \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=maddy@linux$(echo .)ibm.com \
--cc=marcel@holtmann$(echo .)org \
--cc=martin.petersen@oracle$(echo .)com \
--cc=mbenes@suse$(echo .)cz \
--cc=mhklinux@outlook$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=mripard@kernel$(echo .)org \
--cc=naveen@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=nicolas.palix@imag$(echo .)fr \
--cc=npiggin@gmail$(echo .)com \
--cc=obitton@habana$(echo .)ai \
--cc=ogabbay@kernel$(echo .)org \
--cc=oss-drivers@corigine$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=perex@perex$(echo .)cz \
--cc=pkaligineedi@google$(echo .)com \
--cc=pmladek@suse$(echo .)com \
--cc=quic_jjohnson@quicinc$(echo .)com \
--cc=rjui@broadcom$(echo .)com \
--cc=robert.jarzmik@free$(echo .)fr \
--cc=rodrigo.vivi@intel$(echo .)com \
--cc=roger.pau@citrix$(echo .)com \
--cc=sbranden@broadcom$(echo .)com \
--cc=shailend@google$(echo .)com \
--cc=simona@ffwll$(echo .)ch \
--cc=svens@linux$(echo .)ibm.com \
--cc=tglx@linutronix$(echo .)de \
--cc=thomas.hellstrom@linux$(echo .)intel.com \
--cc=tiwai@suse$(echo .)com \
--cc=tzimmermann@suse$(echo .)de \
--cc=xen-devel@lists$(echo .)xenproject.org \
--cc=xiubli@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox