From: Segher Boessenkool <segher@kernel•crashing.org>
To: "Mukesh Kumar Chaurasiya (IBM)" <mkchauras@gmail•com>
Cc: maddy@linux•ibm.com, mpe@ellerman•id.au, npiggin@gmail•com,
chleroy@kernel•org, peterz@infradead•org, jpoimboe@kernel•org,
jbaron@akamai•com, aliceryhl@google•com, rostedt@goodmis•org,
ardb@kernel•org, sumit.semwal@linaro•org,
christian.koenig@amd•com, ojeda@kernel•org, boqun@kernel•org,
gary@garyguo•net, bjorn3_gh@protonmail•com, lossin@kernel•org,
a.hindborg@kernel•org, tmgross@umich•edu, dakr@kernel•org,
nathan@kernel•org, nick.desaulniers+lkml@gmail•com,
morbo@google•com, justinstitt@google•com, tamird@kernel•org,
arnd@arndb•de, nsc@kernel•org, simona.vetter@ffwll•ch,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
linux-media@vger•kernel.org, dri-devel@lists•freedesktop.org,
linaro-mm-sig@lists•linaro.org, rust-for-linux@vger•kernel.org,
llvm@lists•linux.dev, Link Mauve <linkmauve@linkmauve•fr>
Subject: Re: [PATCH V13 5/7] rust: Make __udivdi3() and __umoddi3() panic
Date: Fri, 24 Apr 2026 06:54:05 -0500 [thread overview]
Message-ID: <aetZ3VX_Y9sop-SO@gate> (raw)
In-Reply-To: <20260424054742.45832-6-mkchauras@gmail.com>
Hi!
On Fri, Apr 24, 2026 at 11:17:40AM +0530, Mukesh Kumar Chaurasiya (IBM) wrote:
> The core crate currently depends on these two functions for i64/u64/
> i128/u128/core::time::Duration formatting, but we shouldn’t use that in
> the kernel so let’s panic if they are ever called.
>
> This doesn’t yet fix drm_panic_qr.rs, which also uses __udivdi3 when
> CONFIG_CC_OPTIMIZE_FOR_SIZE=y, but at least makes the rest of the kernel
> build on PPC32.
GCC uses calls to functions like even __addsi3 whenever the (sub-)target
does not implement some RTL, doesn't have a define_insn and the like for
it. When you write a new port you only *have* to implement a very few
things, the rest is done in libgcc (you might still have to write some
of that for your target, no free lunch etc.)
32-bit PowerPC has no instructions for 64-bit divisions, nor
instructions that help implementing it in software. It still very often
helps to hand-write machine code for it, it very easily can usually be
more than twice as fast for example (for example if the divisor is less
than half a word big, the common case -- it can be made tens of times
faster then).
There can be many reasons why a GCC backend decides to call a libgcc
routine. For __udivdi3 on -m32 rs6000 you'll be good AFAICS :-)
(but poisoning functions like you do is a terrible idea in general!)
Segher
next prev parent reply other threads:[~2026-04-24 11:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 5:47 [PATCH V13 0/7] Rust support for powerpc Mukesh Kumar Chaurasiya (IBM)
2026-04-24 5:47 ` [PATCH V13 1/7] rust: Fix "multiple candidates for rmeta dependency core" error Mukesh Kumar Chaurasiya (IBM)
2026-04-24 5:47 ` [PATCH V13 2/7] dma-resv: Fix undefined symbol when CONFIG_DMA_SHARED_BUFFER is disabled Mukesh Kumar Chaurasiya (IBM)
2026-04-24 7:56 ` Christian König
2026-04-24 8:06 ` Mukesh Kumar Chaurasiya
2026-04-24 8:25 ` Christian König
2026-04-24 8:34 ` Mukesh Kumar Chaurasiya
2026-04-24 8:44 ` Christian König
2026-04-24 5:47 ` [PATCH V13 3/7] powerpc/jump_label: adjust inline asm to be consistent Mukesh Kumar Chaurasiya (IBM)
2026-04-24 5:47 ` [PATCH V13 4/7] rust/powerpc: Set min rustc version for powerpc Mukesh Kumar Chaurasiya (IBM)
2026-04-24 5:47 ` [PATCH V13 5/7] rust: Make __udivdi3() and __umoddi3() panic Mukesh Kumar Chaurasiya (IBM)
2026-04-24 8:59 ` Arnd Bergmann
2026-04-24 9:14 ` David Laight
2026-04-24 9:43 ` Link Mauve
2026-04-24 10:20 ` Arnd Bergmann
2026-04-24 10:34 ` Miguel Ojeda
2026-04-24 10:26 ` Miguel Ojeda
2026-04-24 11:09 ` David Laight
2026-04-27 16:05 ` [Linaro-mm-sig] " Arnd Bergmann
2026-04-24 11:54 ` Segher Boessenkool [this message]
2026-04-24 11:57 ` Segher Boessenkool
2026-04-24 12:53 ` Segher Boessenkool
2026-04-24 12:43 ` Gary Guo
2026-04-26 7:52 ` Mukesh Kumar Chaurasiya
2026-04-26 14:20 ` Gary Guo
2026-04-26 22:04 ` David Laight
2026-04-27 13:04 ` Gary Guo
2026-04-24 5:47 ` [PATCH V13 6/7] rust: Add PowerPC support Mukesh Kumar Chaurasiya (IBM)
2026-04-24 5:47 ` [PATCH V13 7/7] powerpc: Enable Rust for ppc64le Mukesh Kumar Chaurasiya (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aetZ3VX_Y9sop-SO@gate \
--to=segher@kernel$(echo .)crashing.org \
--cc=a.hindborg@kernel$(echo .)org \
--cc=aliceryhl@google$(echo .)com \
--cc=ardb@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=bjorn3_gh@protonmail$(echo .)com \
--cc=boqun@kernel$(echo .)org \
--cc=chleroy@kernel$(echo .)org \
--cc=christian.koenig@amd$(echo .)com \
--cc=dakr@kernel$(echo .)org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=gary@garyguo$(echo .)net \
--cc=jbaron@akamai$(echo .)com \
--cc=jpoimboe@kernel$(echo .)org \
--cc=justinstitt@google$(echo .)com \
--cc=linaro-mm-sig@lists$(echo .)linaro.org \
--cc=linkmauve@linkmauve$(echo .)fr \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=llvm@lists$(echo .)linux.dev \
--cc=lossin@kernel$(echo .)org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mkchauras@gmail$(echo .)com \
--cc=morbo@google$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=nathan@kernel$(echo .)org \
--cc=nick.desaulniers+lkml@gmail$(echo .)com \
--cc=npiggin@gmail$(echo .)com \
--cc=nsc@kernel$(echo .)org \
--cc=ojeda@kernel$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=rust-for-linux@vger$(echo .)kernel.org \
--cc=simona.vetter@ffwll$(echo .)ch \
--cc=sumit.semwal@linaro$(echo .)org \
--cc=tamird@kernel$(echo .)org \
--cc=tmgross@umich$(echo .)edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox