From: Christoph Hellwig <hch@infradead•org>
To: "T.J. Mercier" <tjmercier@google•com>
Cc: maddy@linux•ibm.com, mpe@ellerman•id.au, npiggin@gmail•com,
chleroy@kernel•org, linuxppc-dev@lists•ozlabs.org,
mripard@kernel•org, sumit.semwal@linaro•org, lkp@intel•com,
linux-kernel@vger•kernel.org, iommu@lists•linux.dev,
linux-mm@kvack•org, agordeev@linux•ibm.com,
gerald.schaefer@linux•ibm.com, linux-s390@vger•kernel.org,
Dan Williams <djbw@kernel•org>,
Tom Lendacky <thomas.lendacky@amd•com>,
x86@kernel•org
Subject: Re: [PATCH] powerpc: Export set_memory_encrypted and set_memory_decrypted
Date: Sun, 24 May 2026 23:21:33 -0700 [thread overview]
Message-ID: <ahPqbfH54R3JJyaV@infradead.org> (raw)
In-Reply-To: <20260522225853.878411-1-tjmercier@google.com>
On Fri, May 22, 2026 at 03:58:53PM -0700, T.J. Mercier wrote:
> After commit fd55edff8a0a ("dma-buf: heaps: system: Turn the heap into a
> module") the system dma-buf heaps can be built as a module. The
> system_cc_shared heap uses set_memory_encrypted and set_memory_decrypted
> but those functions are not exported on powerpc. This can result in a
> build error like:
I'd much rather revert the above commit. Yes, x86 has exported these
since 2017, but that's a really bad idea, and we should fix it instead
of spreading the export.
Setting memory decrypted is a dangerous operations and should only
be available to core code. We should have various allocators for
decrypted code, but not export the functionality to random code.
next prev parent reply other threads:[~2026-05-25 6:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 22:58 [PATCH] powerpc: Export set_memory_encrypted and set_memory_decrypted T.J. Mercier
2026-05-25 6:21 ` Christoph Hellwig [this message]
2026-05-27 16:07 ` Jason Gunthorpe
2026-05-27 18:15 ` Borislav Petkov
2026-05-28 8:53 ` Christoph Hellwig
2026-06-04 5:34 ` Maxime Ripard
2026-06-04 7:21 ` Sumit Semwal
2026-06-04 7:32 ` Sumit Semwal
2026-06-04 13:57 ` Jason Gunthorpe
2026-06-08 15:17 ` Sumit Semwal
2026-06-08 15:27 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahPqbfH54R3JJyaV@infradead.org \
--to=hch@infradead$(echo .)org \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=chleroy@kernel$(echo .)org \
--cc=djbw@kernel$(echo .)org \
--cc=gerald.schaefer@linux$(echo .)ibm.com \
--cc=iommu@lists$(echo .)linux.dev \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lkp@intel$(echo .)com \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=mripard@kernel$(echo .)org \
--cc=npiggin@gmail$(echo .)com \
--cc=sumit.semwal@linaro$(echo .)org \
--cc=thomas.lendacky@amd$(echo .)com \
--cc=tjmercier@google$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox