Subject: Re: [PATCH v6 14/20] dma-direct: return struct page from dma_direct_alloc_from_pool()

From: Catalin Marinas <[email-masked]>
Date: Tue, 9 Jun 2026 14:45:37 +0100

On Thu, Jun 04, 2026 at 02:09:53PM +0530, Aneesh Kumar K.V (Arm) wrote:
> Commit 5b138c534fda ("dma-direct: factor out a dma_direct_alloc_from_pool
> helper") changed dma_direct_alloc_from_pool() to return the CPU address
> from dma_alloc_from_pool(). That fits dma_direct_alloc(), but
> dma_direct_alloc_pages() also uses the helper and expects a struct page *.
> 
> Fix this by making dma_direct_alloc_from_pool() return the struct page *
> again, and pass the CPU address back through an out-parameter for the
> dma_direct_alloc() caller.
> 
> Fixes: 5b138c534fda ("dma-direct: factor out a dma_direct_alloc_from_pool helper")
> Cc: [email-masked]
> 
> Tested-by: Michael Kelley <[email-masked]>
> Tested-by: Mostafa Saleh <[email-masked]>
> Signed-off-by: Aneesh Kumar K.V (Arm) <[email-masked]>

Nit: remove the empty line after Cc: stable. It may confuse tooling.

-- 
Catalin