From: "David Hildenbrand (Arm)" <david@kernel•org>
To: Oscar Salvador <osalvador@suse•de>
Cc: "David S. Miller" <davem@davemloft•net>,
Andreas Larsson <andreas@gaisler•com>,
Mike Rapoport <rppt@kernel•org>,
Andrew Morton <akpm@linux-foundation•org>,
Alexander Gordeev <agordeev@linux•ibm.com>,
Gerald Schaefer <gerald.schaefer@linux•ibm.com>,
Heiko Carstens <hca@linux•ibm.com>,
Vasily Gorbik <gor@linux•ibm.com>,
Christian Borntraeger <borntraeger@linux•ibm.com>,
Sven Schnelle <svens@linux•ibm.com>,
Madhavan Srinivasan <maddy@linux•ibm.com>,
Michael Ellerman <mpe@ellerman•id.au>,
Nicholas Piggin <npiggin@gmail•com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel•org>,
Lorenzo Stoakes <ljs@kernel•org>,
"Liam R. Howlett" <liam@infradead•org>,
Vlastimil Babka <vbabka@kernel•org>,
Suren Baghdasaryan <surenb@google•com>,
Michal Hocko <mhocko@suse•com>,
sparclinux@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-mm@kvack•org, linux-s390@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 4/8] mm/bootmem_info: remove call to kmemleak_free_part_phys()
Date: Tue, 12 May 2026 10:45:03 +0200 [thread overview]
Message-ID: <b2a8e918-7ed2-46b4-bf59-e65dc9359310@kernel.org> (raw)
In-Reply-To: <agLmKu3IpGS3FtmX@localhost.localdomain>
On 5/12/26 10:34, Oscar Salvador wrote:
> On Mon, May 11, 2026 at 04:05:32PM +0200, David Hildenbrand (Arm) wrote:
>> The call to kmemleak_free_part_phys() was added in 2022 in
>> commit dd0ff4d12dd2 ("bootmem: remove the vmemmap pages from kmemleak in
>> put_page_bootmem").
>>
>> In 2025, commit b2aad24b5333 ("mm/memmap: prevent double scanning of memmap
>> by kmemleak") started to use MEMBLOCK_ALLOC_NOLEAKTRACE when allocating
>> the memmap to skip the kmemleak_alloc_phys() in the buddy.
>>
>> So remove the call to kmemleak_free_part_phys(). If this would still
>> be required for other purposes, either free_reserved_page() should take
>> care of it, or selected users.
>>
>> Signed-off-by: David Hildenbrand (Arm) <david@kernel•org>
>
> Reviewed-by: Oscar Salvador <osalvador@suse•de>
>
>> ---
>> include/linux/bootmem_info.h | 1 -
>> mm/bootmem_info.c | 1 -
>> 2 files changed, 2 deletions(-)
>>
>> diff --git a/include/linux/bootmem_info.h b/include/linux/bootmem_info.h
>> index 492ceeb1cdf8..f724340755e5 100644
>> --- a/include/linux/bootmem_info.h
>> +++ b/include/linux/bootmem_info.h
>> @@ -82,7 +82,6 @@ static inline void get_page_bootmem(unsigned long info, struct page *page,
>>
>> static inline void free_bootmem_page(struct page *page)
>> {
>> - kmemleak_free_part_phys(PFN_PHYS(page_to_pfn(page)), PAGE_SIZE);
>> free_reserved_page(page);
>> }
>> #endif
>> diff --git a/mm/bootmem_info.c b/mm/bootmem_info.c
>> index 6e2aaab3dca9..74c1116626c8 100644
>> --- a/mm/bootmem_info.c
>> +++ b/mm/bootmem_info.c
>> @@ -32,7 +32,6 @@ void put_page_bootmem(struct page *page)
>>
>> if (page_ref_dec_return(page) == 1) {
>> set_page_private(page, 0);
>> - kmemleak_free_part_phys(PFN_PHYS(page_to_pfn(page)), PAGE_SIZE);
>
> A bit odd that kmemleak_free_part_phys() did not complain if we never
> did kmemleak_alloc_phys() for these pages?
delete_object_part() calls __find_and_remove_object() and essentially just skips
if it didn't find anything.
Maybe the kmemleak_warn() would trigger, but it's guarded by "#ifdef DEBUG" ...
--
Cheers,
David
next prev parent reply other threads:[~2026-05-12 8:45 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 14:05 [PATCH 0/8] mm: remove CONFIG_HAVE_BOOTMEM_INFO_NODE (Part 1) David Hildenbrand (Arm)
2026-05-11 14:05 ` [PATCH 1/8] sparc/mm: remove register_page_bootmem_info() David Hildenbrand (Arm)
2026-05-12 8:28 ` Oscar Salvador
2026-05-13 8:25 ` Mike Rapoport
2026-05-18 6:55 ` Lance Yang
2026-05-11 14:05 ` [PATCH 2/8] mm/bootmem_info: drop initialization of page->lru David Hildenbrand (Arm)
2026-05-12 8:28 ` Oscar Salvador
2026-05-13 8:27 ` Mike Rapoport
2026-05-18 7:49 ` Lance Yang
2026-05-11 14:05 ` [PATCH 3/8] mm/bootmem_info: stop using PG_private David Hildenbrand (Arm)
2026-05-12 8:30 ` Oscar Salvador
2026-05-13 8:29 ` Mike Rapoport
2026-05-19 2:56 ` Lance Yang
2026-05-11 14:05 ` [PATCH 4/8] mm/bootmem_info: remove call to kmemleak_free_part_phys() David Hildenbrand (Arm)
2026-05-12 8:34 ` Oscar Salvador
2026-05-12 8:45 ` David Hildenbrand (Arm) [this message]
2026-05-20 12:15 ` Lance Yang
2026-05-13 8:31 ` Mike Rapoport
2026-05-11 14:05 ` [PATCH 5/8] mm/bootmem_info: stop marking the pgdat as NODE_INFO David Hildenbrand (Arm)
2026-05-12 7:45 ` Michal Hocko
2026-05-12 7:47 ` David Hildenbrand (Arm)
2026-05-12 8:36 ` Oscar Salvador
2026-05-13 8:35 ` Mike Rapoport
2026-05-20 15:30 ` Lance Yang
2026-05-11 14:05 ` [PATCH 6/8] mm/bootmem_info: stop marking mem_section_usage as MIX_SECTION_INFO David Hildenbrand (Arm)
2026-05-12 8:37 ` Oscar Salvador
2026-05-13 8:38 ` Mike Rapoport
2026-05-21 5:03 ` Lance Yang
2026-05-11 14:05 ` [PATCH 7/8] s390/mm: use free_reserved_page() in vmem_free_pages() David Hildenbrand (Arm)
2026-05-11 14:21 ` Heiko Carstens
2026-05-11 14:24 ` David Hildenbrand (Arm)
2026-05-11 15:22 ` Heiko Carstens
2026-05-11 15:28 ` David Hildenbrand (Arm)
2026-05-12 8:38 ` Oscar Salvador
2026-05-13 8:40 ` Mike Rapoport
2026-05-21 8:39 ` Lance Yang
2026-05-11 14:05 ` [PATCH 8/8] powerpc/mm: remove CONFIG_HAVE_BOOTMEM_INFO_NODE David Hildenbrand (Arm)
2026-05-12 8:43 ` Oscar Salvador
2026-05-13 3:25 ` Ritesh Harjani
2026-05-13 8:41 ` Mike Rapoport
2026-05-21 8:47 ` Lance Yang
2026-05-12 7:46 ` [PATCH 0/8] mm: remove CONFIG_HAVE_BOOTMEM_INFO_NODE (Part 1) Michal Hocko
2026-05-12 7:48 ` David Hildenbrand (Arm)
2026-05-12 8:45 ` Oscar Salvador
2026-05-12 8:51 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2a8e918-7ed2-46b4-bf59-e65dc9359310@kernel.org \
--to=david@kernel$(echo .)org \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andreas@gaisler$(echo .)com \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=chleroy@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=gerald.schaefer@linux$(echo .)ibm.com \
--cc=gor@linux$(echo .)ibm.com \
--cc=hca@linux$(echo .)ibm.com \
--cc=liam@infradead$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=ljs@kernel$(echo .)org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mhocko@suse$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
--cc=osalvador@suse$(echo .)de \
--cc=rppt@kernel$(echo .)org \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=surenb@google$(echo .)com \
--cc=svens@linux$(echo .)ibm.com \
--cc=vbabka@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox