Subject: Re: [PATCH 2/5] Add legacy devices to mpc8641_hpcn.dts

From: Segher Boessenkool <[email-masked]>
Date: Wed, 16 May 2007 21:55:33 +0200

>> +			isa@f0 {

isa@1e

>> +				8042@60 {
>> +					device_type = "8042";

Drop the device_type.  A number as a name isn't
all that great, either.

>> +				rtc@70 {
>> +					device_type = "rtc";
>> +					reg = <1 70 2>;
>> +				};
>
> Is "rtc" a standard OF device,

Yes, it is defined in the "Device Support Extensions"
recommended practice.

> And is the plan to somehow use this entry in the future?

The platform code can use it to find the device.  If it
would have a proper "compatible" property, the generic
code could do that work, instead.

Segher