From: Hannes Reinecke <hare@suse•com>
To: "Matthew R. Ochs" <mrochs@linux•vnet.ibm.com>,
linux-scsi@vger•kernel.org,
James Bottomley <James.Bottomley@HansenPartnership•com>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
Uma Krishnan <ukrishn@linux•vnet.ibm.com>,
"Manoj N. Kumar" <manoj@linux•vnet.ibm.com>
Cc: Frederic Barrat <fbarrat@linux•vnet.ibm.com>,
Andrew Donnellan <andrew.donnellan@au1•ibm.com>,
Christophe Lombard <clombard@linux•vnet.ibm.com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 3/3] cxlflash: Update debug prints in reset handlers
Date: Thu, 29 Jun 2017 07:58:56 +0200 [thread overview]
Message-ID: <bd2f0bf6-b63a-ad7d-89fc-e6fbe19a2494@suse.com> (raw)
In-Reply-To: <1498670077-39845-1-git-send-email-mrochs@linux.vnet.ibm.com>
On 06/28/2017 07:14 PM, Matthew R. Ochs wrote:
> The device and host reset handler contain debug prints to help
> identify the entities being reset. Today these reset handlers
> are based on a SCSI EH design that uses a SCSI command reference
> as a means of identifying the target entity. As such, the debug
> trace includes the SCSI command pointer and associated CDB. This
> is not necessary as the SCSI command is simply the messenger in
> these scenarios.
>
> Refactor the debug prints in the host and reset handlers to only
> present information that is applicable given the function scope.
>
> Signed-off-by: Matthew R. Ochs <mrochs@linux•vnet.ibm.com>
> ---
> drivers/scsi/cxlflash/main.c | 18 +++---------------
> 1 file changed, 3 insertions(+), 15 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse•com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse•com +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2017-06-29 6:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 17:12 [PATCH 0/3] cxlflash: Minor fix and EH refactoring Matthew R. Ochs
2017-06-28 17:14 ` [PATCH 1/3] cxlflash: Avoid double free of character device Matthew R. Ochs
2017-06-29 5:58 ` Hannes Reinecke
2017-06-28 17:14 ` [PATCH 2/3] cxlflash: Update send_tmf() parameters Matthew R. Ochs
2017-06-29 5:58 ` Hannes Reinecke
2017-06-28 17:14 ` [PATCH 3/3] cxlflash: Update debug prints in reset handlers Matthew R. Ochs
2017-06-29 5:58 ` Hannes Reinecke [this message]
2017-07-01 21:02 ` [PATCH 0/3] cxlflash: Minor fix and EH refactoring Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd2f0bf6-b63a-ad7d-89fc-e6fbe19a2494@suse.com \
--to=hare@suse$(echo .)com \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=andrew.donnellan@au1$(echo .)ibm.com \
--cc=clombard@linux$(echo .)vnet.ibm.com \
--cc=fbarrat@linux$(echo .)vnet.ibm.com \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=manoj@linux$(echo .)vnet.ibm.com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=mrochs@linux$(echo .)vnet.ibm.com \
--cc=ukrishn@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox