From: David Hildenbrand <david@redhat•com>
To: Nathan Chancellor <natechancellor@gmail•com>
Cc: Michal Hocko <mhocko@suse•com>,
Wei Yang <richard.weiyang@gmail•com>,
linux-mm@kvack•org, Paul Mackerras <paulus@samba•org>,
Rashmica Gupta <rashmica.g@gmail•com>,
Dan Williams <dan.j.williams@intel•com>,
Michael Neuling <mikey@neuling•org>,
linux-acpi@vger•kernel.org, Len Brown <lenb@kernel•org>,
Pavel Tatashin <pavel.tatashin@microsoft•com>,
Anshuman Khandual <anshuman.khandual@arm•com>,
Qian Cai <cai@lca•pw>, Thomas Gleixner <tglx@linutronix•de>,
Oscar Salvador <osalvador@suse•de>,
Juergen Gross <jgross@suse•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
"Rafael J. Wysocki" <rjw@rjwysocki•net>,
linux-kernel@vger•kernel.org, Arun KS <arunks@codeaurora•org>,
Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2 4/6] mm/memory_hotplug: Rename walk_memory_range() and pass start+size instead of pfns
Date: Thu, 20 Jun 2019 18:37:10 +0200 [thread overview]
Message-ID: <bffe90e6-81fa-e8d5-5fb2-b54539f45c5d@redhat.com> (raw)
In-Reply-To: <20190620160507.GA34841@archlinux-epyc>
On 20.06.19 18:05, Nathan Chancellor wrote:
> On Thu, Jun 20, 2019 at 12:35:18PM +0200, David Hildenbrand wrote:
>> walk_memory_range() was once used to iterate over sections. Now, it
>> iterates over memory blocks. Rename the function, fixup the
>> documentation. Also, pass start+size instead of PFNs, which is what most
>> callers already have at hand. (we'll rework link_mem_sections() most
>> probably soon)
>>
>> Follow-up patches wil rework, simplify, and move walk_memory_blocks() to
>> drivers/base/memory.c.
>>
>> Note: walk_memory_blocks() only works correctly right now if the
>> start_pfn is aligned to a section start. This is the case right now,
>> but we'll generalize the function in a follow up patch so the semantics
>> match the documentation.
>>
>> Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
>> Cc: Paul Mackerras <paulus@samba•org>
>> Cc: Michael Ellerman <mpe@ellerman•id.au>
>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki•net>
>> Cc: Len Brown <lenb@kernel•org>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
>> Cc: David Hildenbrand <david@redhat•com>
>> Cc: Rashmica Gupta <rashmica.g@gmail•com>
>> Cc: Andrew Morton <akpm@linux-foundation•org>
>> Cc: Pavel Tatashin <pavel.tatashin@microsoft•com>
>> Cc: Anshuman Khandual <anshuman.khandual@arm•com>
>> Cc: Michael Neuling <mikey@neuling•org>
>> Cc: Thomas Gleixner <tglx@linutronix•de>
>> Cc: Oscar Salvador <osalvador@suse•de>
>> Cc: Michal Hocko <mhocko@suse•com>
>> Cc: Wei Yang <richard.weiyang@gmail•com>
>> Cc: Juergen Gross <jgross@suse•com>
>> Cc: Qian Cai <cai@lca•pw>
>> Cc: Arun KS <arunks@codeaurora•org>
>> Signed-off-by: David Hildenbrand <david@redhat•com>
>> ---
>> arch/powerpc/platforms/powernv/memtrace.c | 22 ++++++++++-----------
>> drivers/acpi/acpi_memhotplug.c | 19 ++++--------------
>> drivers/base/node.c | 5 +++--
>> include/linux/memory_hotplug.h | 2 +-
>> mm/memory_hotplug.c | 24 ++++++++++++-----------
>> 5 files changed, 32 insertions(+), 40 deletions(-)
>>
>> diff --git a/arch/powerpc/platforms/powernv/memtrace.c b/arch/powerpc/platforms/powernv/memtrace.c
>> index 5e53c1392d3b..8c82c041afe6 100644
>> --- a/arch/powerpc/platforms/powernv/memtrace.c
>> +++ b/arch/powerpc/platforms/powernv/memtrace.c
>> @@ -70,23 +70,24 @@ static int change_memblock_state(struct memory_block *mem, void *arg)
>> /* called with device_hotplug_lock held */
>> static bool memtrace_offline_pages(u32 nid, u64 start_pfn, u64 nr_pages)
>> {
>> + const unsigned long start = PFN_PHYS(start_pfn);
>> + const unsigned long size = PFN_PHYS(nr_pages);
>> u64 end_pfn = start_pfn + nr_pages - 1;
>
> This variable should be removed:
>
> arch/powerpc/platforms/powernv/memtrace.c:75:6: warning: unused variable 'end_pfn' [-Wunused-variable]
> u64 end_pfn = start_pfn + nr_pages - 1;
> ^
> 1 warning generated.
>
> https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/209576737
>
> Cheers,
> Nathan
>
Indeed, thanks!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-06-20 16:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 10:35 [PATCH v2 0/6] mm: Further memory block device cleanups David Hildenbrand
2019-06-20 10:35 ` [PATCH v2 1/6] mm: Section numbers use the type "unsigned long" David Hildenbrand
2019-06-20 10:35 ` [PATCH v2 2/6] drivers/base/memory: Use "unsigned long" for block ids David Hildenbrand
2019-06-20 10:35 ` [PATCH v2 3/6] mm: Make register_mem_sect_under_node() static David Hildenbrand
2019-06-20 10:35 ` [PATCH v2 4/6] mm/memory_hotplug: Rename walk_memory_range() and pass start+size instead of pfns David Hildenbrand
2019-06-20 16:05 ` Nathan Chancellor
2019-06-20 16:37 ` David Hildenbrand [this message]
2019-06-20 10:35 ` [PATCH v2 5/6] mm/memory_hotplug: Move and simplify walk_memory_blocks() David Hildenbrand
2019-06-20 10:35 ` [PATCH v2 6/6] drivers/base/memory.c: Get rid of find_memory_block_hinted() David Hildenbrand
2019-06-20 18:25 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bffe90e6-81fa-e8d5-5fb2-b54539f45c5d@redhat.com \
--to=david@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anshuman.khandual@arm$(echo .)com \
--cc=arunks@codeaurora$(echo .)org \
--cc=cai@lca$(echo .)pw \
--cc=dan.j.williams@intel$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jgross@suse$(echo .)com \
--cc=lenb@kernel$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mhocko@suse$(echo .)com \
--cc=mikey@neuling$(echo .)org \
--cc=natechancellor@gmail$(echo .)com \
--cc=osalvador@suse$(echo .)de \
--cc=paulus@samba$(echo .)org \
--cc=pavel.tatashin@microsoft$(echo .)com \
--cc=rashmica.g@gmail$(echo .)com \
--cc=richard.weiyang@gmail$(echo .)com \
--cc=rjw@rjwysocki$(echo .)net \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox