From: "Christophe Leroy (CS GROUP)" <chleroy@kernel•org>
To: adubey@linux•ibm.com, bpf@vger•kernel.org
Cc: hbathini@linux•ibm.com, linuxppc-dev@lists•ozlabs.org,
maddy@linux•ibm.com, ast@kernel•org, andrii@kernel•org,
daniel@iogearbox•net, shuah@kernel•org,
linux-kselftest@vger•kernel.org, stable@vger•kernel.org
Subject: Re: [PATCH v4 0/5] powerpc/bpf: Add support for verifier selftest
Date: Mon, 18 May 2026 13:44:50 +0200 [thread overview]
Message-ID: <cf5f932b-6586-4f64-ad2f-c9a6ff81affe@kernel.org> (raw)
In-Reply-To: <20260517214043.12975-1-adubey@linux.ibm.com>
Le 17/05/2026 à 23:40, adubey@linux•ibm.com a écrit :
> From: Abhishek Dubey <adubey@linux•ibm.com>
>
> The verifier selftest validates JITed instructions by matching expected
> disassembly output. The first two patches fix issues in powerpc instruction
> disassembly that were causing test flow failures. The fix is common for
> 64-bit & 32-bit powerpc. Add support for the powerpc-specific "__powerpc64"
> architecture tag in the third patch, enabling proper test filtering in
> verifier test files. Introduce verifier testcases for tailcalls on powerpc64
> in the final patch.
Build fails:
DESCEND objtool
INSTALL libsubcmd_headers
CC arch/powerpc/net/bpf_jit_comp32.o
arch/powerpc/net/bpf_jit_comp32.c:232:6: error: conflicting types for
'bpf_jit_build_epilogue'; have 'void(u32 *, struct codegen_context *)'
{aka 'void(unsigned int *, struct codegen_context *)'}
232 | void bpf_jit_build_epilogue(u32 *image, struct codegen_context
*ctx)
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from arch/powerpc/net/bpf_jit_comp32.c:19:
arch/powerpc/net/bpf_jit.h:217:6: note: previous declaration of
'bpf_jit_build_epilogue' with type 'void(u32 *, u32 *, struct
codegen_context *)' {aka 'void(unsigned int *, unsigned int *, struct
codegen_context *)'}
217 | void bpf_jit_build_epilogue(u32 *image, u32 *fimage, struct
codegen_context *ctx);
| ^~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/net/bpf_jit_comp32.c: In function 'bpf_jit_build_epilogue':
arch/powerpc/net/bpf_jit_comp32.c:240:43: error: passing argument 2 of
'bpf_jit_build_fentry_stubs' from incompatible pointer type
[-Wincompatible-pointer-types]
240 | bpf_jit_build_fentry_stubs(image, ctx);
| ^~~
| |
| struct codegen_context *
arch/powerpc/net/bpf_jit.h:218:50: note: expected 'u32 *' {aka 'unsigned
int *'} but argument is of type 'struct codegen_context *'
218 | void bpf_jit_build_fentry_stubs(u32 *image, u32 *fimage, struct
codegen_context *ctx);
| ~~~~~^~~~~~
arch/powerpc/net/bpf_jit_comp32.c:240:9: error: too few arguments to
function 'bpf_jit_build_fentry_stubs'; expected 3, have 2
240 | bpf_jit_build_fentry_stubs(image, ctx);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/net/bpf_jit.h:218:6: note: declared here
218 | void bpf_jit_build_fentry_stubs(u32 *image, u32 *fimage, struct
codegen_context *ctx);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
make[4]: *** [scripts/Makefile.build:289:
arch/powerpc/net/bpf_jit_comp32.o] Error 1
make[3]: *** [scripts/Makefile.build:548: arch/powerpc/net] Error 2
make[2]: *** [scripts/Makefile.build:548: arch/powerpc] Error 2
make[1]: *** [/home/chleroy/linux-powerpc/Makefile:2143: .] Error 2
make: *** [Makefile:248: __sub-make] Error 2
Christophe
prev parent reply other threads:[~2026-05-18 11:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 21:40 [PATCH v4 0/5] powerpc/bpf: Add support for verifier selftest adubey
2026-05-17 21:40 ` [PATCH v4 1/5] powerpc/bpf: fix alignment of long branch trampoline address adubey
2026-05-17 18:30 ` bot+bpf-ci
2026-05-18 7:18 ` Hari Bathini
2026-05-17 21:40 ` [PATCH v4 2/5] powerpc/bpf: Move out dummy_tramp_addr after Long branch stub adubey
2026-05-17 18:30 ` bot+bpf-ci
2026-05-18 7:25 ` Hari Bathini
2026-05-18 7:53 ` Hari Bathini
2026-05-17 21:40 ` [PATCH v4 3/5] selftest/bpf: Fixing powerpc JIT disassembly failure adubey
2026-05-17 18:18 ` bot+bpf-ci
2026-05-17 21:40 ` [PATCH v4 4/5] selftest/bpf: Enable verifier selftest for powerpc64 adubey
2026-05-17 18:18 ` bot+bpf-ci
2026-05-17 21:40 ` [PATCH v4 5/5] selftest/bpf: Add tailcall " adubey
2026-05-18 11:44 ` Christophe Leroy (CS GROUP) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf5f932b-6586-4f64-ad2f-c9a6ff81affe@kernel.org \
--to=chleroy@kernel$(echo .)org \
--cc=adubey@linux$(echo .)ibm.com \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=hbathini@linux$(echo .)ibm.com \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=shuah@kernel$(echo .)org \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox