From: "Aneesh Kumar K.V" <aneesh.kumar@linux•ibm.com>
To: Daniel Henrique Barboza <danielhb413@gmail•com>,
linuxppc-dev@lists•ozlabs.org, mpe@ellerman•id.au
Cc: Nathan Lynch <nathanl@linux•ibm.com>,
David Gibson <david@gibson•dropbear.id.au>
Subject: Re: [PATCH v5 0/6] Add support for FORM2 associativity
Date: Tue, 13 Jul 2021 20:00:37 +0530 [thread overview]
Message-ID: <d0ef189e-1558-eac3-5fda-3c55eb27860c@linux.ibm.com> (raw)
In-Reply-To: <ad91ae4e-7c2d-26d6-1a6e-88f2c365fade@gmail.com>
On 7/13/21 7:57 PM, Daniel Henrique Barboza wrote:
> Aneesh,
>
> This series compiles with a configuration made with "pseries_le_defconfig"
> but fails with a config based on an existing RHEL8 config.
>
> The reason, which is hinted in the robot replies in patch 4, is that you
> defined
> a "__vphn_get_associativity" inside a #ifdef CONFIG_PPC_SPLPAR guard but
> didn't
> define how the function would behave without the config, and you ended up
> using the function elsewhere.
>
> This fixes the compilation but I'm not sure if this is what you intended
> for this function:
>
>
> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
> index c68846fc9550..6e8551d16b7a 100644
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@ -680,6 +680,11 @@ static int vphn_get_nid(long lcpu)
>
> }
> #else
> +static int __vphn_get_associativity(long lcpu, __be32 *associativity)
> +{
> + return -1;
> +}
> +
> static int vphn_get_nid(long unused)
> {
> return NUMA_NO_NODE;
>
>
> I'll post a new version of the QEMU FORM2 changes using these patches as
> is (with
> the above fixup), but I guess you'll want to post a v6.
>
kernel test robot did report that earlier and I have that fixed in my
local tree. I haven't posted v6 yet because I want to close the review
on the approach with v5 patchset.
-aneesh
prev parent reply other threads:[~2021-07-13 14:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 15:11 [PATCH v5 0/6] Add support for FORM2 associativity Aneesh Kumar K.V
2021-06-28 15:11 ` [PATCH v5 1/6] powerpc/pseries: rename min_common_depth to primary_domain_index Aneesh Kumar K.V
2021-07-22 1:59 ` David Gibson
2021-07-22 2:36 ` David Gibson
2021-07-22 5:17 ` Aneesh Kumar K.V
2021-07-26 2:28 ` David Gibson
2021-06-28 15:11 ` [PATCH v5 2/6] powerpc/pseries: rename distance_ref_points_depth to max_associativity_domain_index Aneesh Kumar K.V
2021-07-22 0:59 ` David Gibson
2021-07-22 1:19 ` David Gibson
2021-06-28 15:11 ` [PATCH v5 3/6] powerpc/pseries: Rename TYPE1_AFFINITY to FORM1_AFFINITY Aneesh Kumar K.V
2021-06-28 15:11 ` [PATCH v5 4/6] powerpc/pseries: Consolidate different NUMA distance update code paths Aneesh Kumar K.V
2021-06-28 20:21 ` kernel test robot
2021-06-28 20:40 ` kernel test robot
2021-07-22 1:40 ` David Gibson
2021-07-22 7:07 ` Aneesh Kumar K.V
2021-07-26 2:37 ` David Gibson
2021-07-27 3:32 ` Aneesh Kumar K.V
2021-07-27 5:59 ` David Gibson
2021-06-28 15:11 ` [PATCH v5 5/6] powerpc/pseries: Add a helper for form1 cpu distance Aneesh Kumar K.V
2021-07-22 1:42 ` David Gibson
2021-07-22 7:09 ` Aneesh Kumar K.V
2021-07-26 2:38 ` David Gibson
2021-06-28 15:11 ` [PATCH v5 6/6] powerpc/pseries: Add support for FORM2 associativity Aneesh Kumar K.V
2021-07-22 2:28 ` David Gibson
2021-07-22 7:34 ` Aneesh Kumar K.V
2021-07-26 2:41 ` David Gibson
2021-07-13 14:27 ` [PATCH v5 0/6] " Daniel Henrique Barboza
2021-07-13 14:30 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0ef189e-1558-eac3-5fda-3c55eb27860c@linux.ibm.com \
--to=aneesh.kumar@linux$(echo .)ibm.com \
--cc=danielhb413@gmail$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=nathanl@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox