Subject: Re: [PATCH] ppc32: Fix SCC Uart write problem after 2. open()

From: Dan Malek <[email-masked]>
Date: Tue, 1 Nov 2005 11:08:30 -0500

On Nov 1, 2005, at 2:17 AM, Heiko Schocher wrote:

> The following Patch will fix this problem.

This is wrong.  We should never have to reinitialize the
buffer descriptors (which I see the driver does in some cases)
and we certainly should never have to reinitialize the
SCC or SMC peripherals like this.

Once the driver has initialized the SCC or SMC and set up
the buffer descriptors during kernel start up, it should never
be done again.  The only thing we should do is stop/start
the transmitter or receiver, and they should continue operation
with the next buffer descriptor in the ring.

This patch just covers up a driver bug, find and fix the real bug.

Thanks.

	-- Dan