Subject: Re: [PATCH V2] powerpc: Fix Book-E watchdog timer interval setting

From: "Timur Tabi" <[email-masked]>
Date: Tue, 23 Sep 2008 11:31:55 -0500

On Tue, Sep 23, 2008 at 10:04 AM, Matthias Fuchs
<[email-masked]> wrote:
>  #ifdef CONFIG_FSL_BOOKE
>  #define WDTP(x)                ((((63-x)&0x3)<<30)|(((63-x)&0x3c)<<15))
> +#define WDTP_MASK      (WDTP(63))

WDTP(63) is "((((63-63)&0x3)<<30)|(((63-63)&0x3c)<<15))", which is
equal to 0.  Shouldn't WDTP_MASK be equal to "(3 << 30) | (15 << 15)"?

-- 
Timur Tabi
Linux kernel developer at Freescale