public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed

From: Kumar Gala <kumar.gala@freescale•com>
To: Paul Mackerras <paulus@samba•org>
Cc: ppcembed Linux list <linuxppc-embedded@ozlabs•org>
Subject: Allowing i-side updates of TLB on 4xx/book-e
Date: Thu, 3 Mar 2005 19:03:51 -0600	[thread overview]
Message-ID: <fd5eb84defe2c51141e872390eefc9a1@freescale.com> (raw)

Paul,

I know its been forever since you looked at ppc32 and even longer for 
4xx/booke :)  I did have a question regarding some code on the i-side 
TLB faults in do_page_fault:

                 /* Since 4xx/Book-E supports per-page execute 
permission,
                  * we lazily flush dcache to icache. */
                 ptep = NULL;
                 if (get_pteptr(mm, address, &ptep) && 
pte_present(*ptep)) {
                         struct page *page = pte_page(*ptep);

                         if (! test_bit(PG_arch_1, &page->flags)) {
                                 flush_dcache_icache_page(page);
                                 set_bit(PG_arch_1, &page->flags);
                         }
                         pte_update(ptep, 0, _PAGE_HWEXEC);
                         _tlbie(address);
                         pte_unmap(ptep);
                         up_read(&mm->mmap_sem);
                         return 0;
                 }

Is there a reason we don't allow preloading of the I-side TLB entry 
that we just updated, rather than doing the _tlbie?  We have to figure 
that we are about to take another I-TLB miss to reload the entry we 
just got this InstructionStorage fault for.  Is there something I'm 
missing?

thanks

- kumar

                 reply	other threads:[~2005-03-04  1:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd5eb84defe2c51141e872390eefc9a1@freescale.com \
    --to=kumar.gala@freescale$(echo .)com \
    --cc=linuxppc-embedded@ozlabs$(echo .)org \
    --cc=paulus@samba$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox