From: Andreas Schwab <schwab@suse•de>
To: Jeff Garzik <jeff@garzik•org>
Cc: Jens Axboe <axboe@kernel•dk>,
"James E.J. Bottomley" <James.Bottomley@SteelEye•com>,
linux-scsi@vger•kernel.org, Jens Axboe <jens.axboe@oracle•com>,
linux-kernel@vger•kernel.org,
Alessandro Rubini <rubini@vision•unipv.it>,
linuxppc-dev@ozlabs•org, Paul Mackerras <paulus@samba•org>,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom•com>,
Andrew Morton <akpm@linux-foundation•org>
Subject: Re: [patch 1/3] ps3: Disk Storage Driver
Date: Tue, 24 Jul 2007 14:52:32 +0200 [thread overview]
Message-ID: <je3aze6k1b.fsf@sykes.suse.de> (raw)
In-Reply-To: <46A5F275.7060905@garzik.org> (Jeff Garzik's message of "Tue\, 24 Jul 2007 08\:37\:09 -0400")
Jeff Garzik <jeff@garzik•org> writes:
> Andy Whitcroft wrote:
>> Andrew Morton wrote:
>>
>>>> + start_sector = req->sector*priv->blocking_factor;
>>>> + sectors = req->nr_sectors*priv->blocking_factor;
>>> s/*/ * /. checkpatch missed this.
>>
>> Ok, this is something we need to decide on. Currently we only ask for
>> consistent spacing on all the mathematic operators. This is mostly as
>> we do see a large number of non-spaced uses in defines and the like.
>>
>> I am happy to expand these tests so they are always spaced on both sides
>> style if that is the preference.
>
> That is most definitely the preference: spaces surround operators.
^binary
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse•de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2007-07-24 12:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 16:15 [patch 0/3] PS3 Storage Drivers for 2.6.23, take 5 Geert Uytterhoeven
2007-07-16 16:15 ` [patch 1/3] ps3: Disk Storage Driver Geert Uytterhoeven
2007-07-18 14:32 ` Jan Engelhardt
2007-07-18 15:36 ` Geert Uytterhoeven
2007-07-18 23:36 ` Andrew Morton
2007-07-19 5:33 ` Jens Axboe
2007-07-19 7:15 ` Geert Uytterhoeven
2007-07-19 8:57 ` Geert Uytterhoeven
2007-07-19 9:10 ` Andrew Morton
2007-07-19 13:52 ` [patch 0/4] PS3 storage driver updates (was: Re: [patch 1/3] ps3: Disk Storage Driver) Geert Uytterhoeven
2007-07-19 13:53 ` [patch 1/4] ps3disk: use correct bio vector size Geert Uytterhoeven
2007-07-19 13:54 ` [patch 2/4] ps3disk: updates after final review Geert Uytterhoeven
2007-07-19 13:54 ` [patch 3/4] ps3rom: " Geert Uytterhoeven
2007-07-19 13:55 ` [patch 4/4] ps3flash: " Geert Uytterhoeven
2007-07-19 9:26 ` [patch 1/3] ps3: Disk Storage Driver Cornelia Huck
2007-07-19 9:36 ` Geert Uytterhoeven
2007-07-19 12:00 ` Cornelia Huck
2007-07-19 12:13 ` Geert Uytterhoeven
2007-07-19 12:52 ` Cornelia Huck
2007-07-24 11:44 ` Andy Whitcroft
2007-07-24 12:37 ` Jeff Garzik
2007-07-24 12:52 ` Andreas Schwab [this message]
2007-07-24 13:44 ` Jeff Garzik
2007-07-24 16:43 ` Andrew Morton
2007-07-25 1:09 ` Paul Mackerras
2007-07-25 1:21 ` Andrew Morton
2007-07-16 16:15 ` [patch 2/3] ps3: BD/DVD/CD-ROM " Geert Uytterhoeven
2007-07-18 23:43 ` Andrew Morton
2007-07-19 9:02 ` Geert Uytterhoeven
2007-07-19 9:17 ` Andrew Morton
2007-07-19 9:39 ` Geert Uytterhoeven
2007-07-19 9:41 ` Jens Axboe
2007-07-19 9:47 ` Andrew Morton
2007-07-19 17:56 ` Rene Herman
2007-07-16 16:15 ` [patch 3/3] ps3: FLASH ROM " Geert Uytterhoeven
2007-07-18 23:52 ` Andrew Morton
2007-07-19 11:25 ` Geert Uytterhoeven
2007-07-19 6:40 ` [patch 0/3] PS3 Storage Drivers for 2.6.23, take 5 Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=je3aze6k1b.fsf@sykes.suse.de \
--to=schwab@suse$(echo .)de \
--cc=Geert.Uytterhoeven@sonycom$(echo .)com \
--cc=James.Bottomley@SteelEye$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=axboe@kernel$(echo .)dk \
--cc=jeff@garzik$(echo .)org \
--cc=jens.axboe@oracle$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=rubini@vision$(echo .)unipv.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox