Subject: Re: [PATCH] PS3: fix the bug the major version part is not compared

From: Andreas Schwab <[email-masked]>
Date: Tue, 28 Aug 2007 15:26:50 +0200

Masakazu Mokuno <[email-masked]> writes:

> Fix the bug that the major version part of the firmware 
> is not compared.
>
> Signed-off-by: Masakazu Mokuno <[email-masked]>
> CC: Geoff Levand <[email-masked]>
> ---
>  arch/powerpc/platforms/ps3/setup.c |    2 +-
>  include/asm-powerpc/ps3.h          |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> --- a/arch/powerpc/platforms/ps3/setup.c
> +++ b/arch/powerpc/platforms/ps3/setup.c
> @@ -54,7 +54,7 @@ void ps3_get_firmware_version(union ps3_
>  }
>  EXPORT_SYMBOL_GPL(ps3_get_firmware_version);
>  
> -int ps3_compare_firmware_version(u16 major, u16 minor, u16 rev)
> +s64 ps3_compare_firmware_version(u16 major, u16 minor, u16 rev)
>  {
>  	union ps3_firmware_version x;
>  

Better yet: normalize the return value.

	return (ps3_firmware_version.raw > x.raw) -
               (ps3_firmware_version.raw < x.raw);

Andreas.

-- 
Andreas Schwab, SuSE Labs, [email-masked]
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."