From: Andreas Schwab <schwab@suse•de>
To: Takashi Iwai <tiwai@suse•de>
Cc: linuxppc-dev@ozlabs•org,
Johannes Berg <johannes@sipsolutions•net>,
alsa-devel@alsa-project•org
Subject: Re: [Alsa-devel] [RFC 3/8] snd-aoa: add soundbus
Date: Fri, 02 Jun 2006 16:41:14 +0200 [thread overview]
Message-ID: <jeu073aad1.fsf@sykes.suse.de> (raw)
In-Reply-To: <s5hslmn4p00.wl%tiwai@suse.de> (Takashi Iwai's message of "Fri, 02 Jun 2006 16:21:35 +0200")
Takashi Iwai <tiwai@suse•de> writes:
> At Fri, 02 Jun 2006 16:07:05 +0200,
> Johannes Berg wrote:
>>
>> On Fri, 2006-06-02 at 15:53 +0200, Takashi Iwai wrote:
>> > > + if (strlen(sdev->modalias)) {
>> > > + length = snprintf (buf, 34, "%s\n", sdev->modalias);
>> >
>> > sizeof(sdev->modalias) + 2? But still strange if modalias has no
>> > nul-end.
>>
>> Hm, how would I handle that if modalias has no nul?
>
> Well, I'm not sure whether modalias is always nul-terminated.
If modalias is not nul-terminated then strlen will already fail.
> Otherwise (if not nul-terminated), I'd implement like:
>
> strlcpy(buf, sdev->modalias, sizeof(sdev->modalias) + 1);
> strcpy(buf, "\n");
strcat?
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse•de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-06-02 14:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-01 11:58 [RFC 0/8] snd-aoa: add snd-aoa Johannes Berg
2006-06-01 11:58 ` [RFC 1/8] snd-aoa: add aoa header files Johannes Berg
2006-06-01 11:58 ` [RFC 2/8] snd-aoa: add aoa core Johannes Berg
2006-06-02 13:42 ` [Alsa-devel] " Takashi Iwai
2006-06-02 13:46 ` Johannes Berg
2006-06-01 11:58 ` [RFC 3/8] snd-aoa: add soundbus Johannes Berg
2006-06-02 13:53 ` [Alsa-devel] " Takashi Iwai
2006-06-02 14:07 ` Johannes Berg
2006-06-02 14:21 ` Takashi Iwai
2006-06-02 14:41 ` Andreas Schwab [this message]
2006-06-02 14:44 ` Johannes Berg
2006-06-02 14:45 ` Takashi Iwai
2006-06-01 11:58 ` [RFC 4/8] snd-aoa: add i2sbus Johannes Berg
2006-06-02 14:23 ` [Alsa-devel] " Takashi Iwai
2006-06-06 11:17 ` Johannes Berg
2006-06-06 14:00 ` Takashi Iwai
2006-06-07 11:40 ` Johannes Berg
2006-06-07 12:41 ` Takashi Iwai
2006-06-07 12:45 ` Johannes Berg
2006-06-07 12:49 ` Takashi Iwai
2006-06-07 12:52 ` Johannes Berg
2006-06-07 12:58 ` Takashi Iwai
2006-06-07 13:01 ` Johannes Berg
2006-06-01 11:58 ` [RFC 5/8] snd-aoa: add codecs Johannes Berg
2006-06-02 14:31 ` [Alsa-devel] " Takashi Iwai
2006-06-06 11:36 ` Johannes Berg
2006-06-01 11:58 ` [RFC 6/8] snd-aoa: add layout-id fabric Johannes Berg
2006-06-01 11:58 ` [RFC 7/8] snd-aoa: add Kconfig and Makefile Johannes Berg
2006-06-01 11:58 ` [RFC 8/8] snd-aoa: wire up aoa in sound/ Johannes Berg
2006-06-02 14:43 ` [Alsa-devel] [RFC 0/8] snd-aoa: add snd-aoa Takashi Iwai
2006-06-02 14:56 ` Johannes Berg
2006-06-02 15:23 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jeu073aad1.fsf@sykes.suse.de \
--to=schwab@suse$(echo .)de \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=tiwai@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox