From: Ilya Yanok <yanok@emcraft•com>
To: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c
Date: Sun, 19 Sep 2010 20:00:30 +0000 (UTC) [thread overview]
Message-ID: <loom.20100919T215645-646@post.gmane.org> (raw)
In-Reply-To: 1284774145-14543-1-git-send-email-tmarri@apm.com
Hi Tirumala,
> drivers/dma/ppc4xx/adma.c | 4370 +++-----------------------------------
> drivers/dma/ppc4xx/adma.h | 116 +-
> drivers/dma/ppc4xx/ppc4xx-adma.h | 4020 +++++++++++++++++++++++++++++++++++
You've moved tons of code to the header file. Why?
Regards, Ilya.
next prev parent reply other threads:[~2010-09-19 20:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-18 1:42 [PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c tmarri
2010-09-18 21:09 ` Wolfgang Denk
2010-09-20 18:00 ` Tirumala Marri
2010-09-20 21:31 ` Wolfgang Denk
2010-09-19 20:00 ` Ilya Yanok [this message]
2010-09-21 16:51 ` Tirumala Marri
2010-09-23 20:22 ` Dan Williams
2010-09-23 22:39 ` Tirumala Marri
2010-09-24 6:58 ` Stefan Roese
2010-09-24 18:52 ` Tirumala Marri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20100919T215645-646@post.gmane.org \
--to=yanok@emcraft$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox