From: Stewart Smith <stewart@linux•vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>, sam.mj@au1•ibm.com
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [RFC PATCH] powerpc/kexec: Wait 1s for secondaries to enter OPAL
Date: Wed, 29 Jul 2015 17:24:33 +1000 [thread overview]
Message-ID: <m3io93ifym.fsf@oc8180480414.ibm.com> (raw)
In-Reply-To: <1438077498.7562.130.camel@kernel.crashing.org>
Benjamin Herrenschmidt <benh@kernel•crashing.org> writes:
> On Tue, 2015-07-28 at 16:13 +1000, Samuel Mendoza-Jonas wrote:
>
>> "It sounds reasonable" was more or less the inspiration :)
>> While I was going over some of the code relating to the previous kexec
>> fix with Ben he pointed this out and suggested there wasn't
>> much of a reason to differentiate between a crashing/non-crashing
>> cpu as far as the timeout goes - if we're not 'crashing' we still
>> don't want to spin forever.
>>
>> I'll let Ben comment on whether 1s per cpu is enough.
>
> Well, if the scheduler doesn't give us the CPU at the point of kexec
> within a second, I think we are in pretty bad shape already, don't you
> think ?
Quite likely, I think my dislike of magic timeouts just kicked in :)
next prev parent reply other threads:[~2015-07-29 7:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 5:54 [RFC PATCH] powerpc/kexec: Wait 1s for secondaries to enter OPAL Samuel Mendoza-Jonas
2015-07-27 5:56 ` Stewart Smith
2015-07-28 6:13 ` Samuel Mendoza-Jonas
2015-07-28 9:58 ` Benjamin Herrenschmidt
2015-07-29 7:24 ` Stewart Smith [this message]
2015-10-12 11:21 ` [RFC] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3io93ifym.fsf@oc8180480414.ibm.com \
--to=stewart@linux$(echo .)vnet.ibm.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sam.mj@au1$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox