public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed

From: "Alexandros Kostopoulos" <akostop@inaccessnetworks•com>
To: linuxppc-dev@ozlabs•org
Subject: cpm_uart non-console problem with write on 2nd open..
Date: Thu, 14 Sep 2006 16:30:44 +0300	[thread overview]
Message-ID: <op.tfvehinanhx3hy@draco> (raw)

I'm experiencing a problem with the 2.6.13 cpm_uart driver. When opening=
  =

the device for the second time after the driver was inserted, if only a =
 =

few bytes are sent for transmission and the device is then closed, the  =

tx_empty routine called by shutdown returns 0 and the latter hangs in th=
e  =

while loop with the call to cpm_uart_tx_empty. No bytes are actually  =

transmitted from the uart.

I found out that the difference between the first and subsequent open  =

calls is that during the first time (and until the first shutdown) the  =

transmitter is enabled in GSMRL. From this point on, the transmitter is =
 =

initially disabled on startup. Thus, if only a few bytes are queued for =
 =

transmission before shutdown and a TX interrupt is not triggered, the  =

bytes are never sent, and thus the shutdown function hangs on the  =

cpm_uart_tx_empty loop.

The fix that works for me is the following:

Index: drivers/serial/cpm_uart/cpm_uart_core.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- drivers/serial/cpm_uart/cpm_uart_core.c     (revision 106)
+++ drivers/serial/cpm_uart/cpm_uart_core.c     (working copy)

@@ -394,7 +394,7 @@ static int cpm_uart_startup(struct uart_
                 pinfo->smcp->smc_smcmr |=3D SMCMR_REN;
         } else {
                 pinfo->sccp->scc_sccm |=3D UART_SCCM_RX;
-        pinfo->sccp->scc_gsmrl |=3D (SCC_GSMRL_ENR);
+        pinfo->sccp->scc_gsmrl |=3D (SCC_GSMRL_ENR | SCC_GSMRL_ENT);

         }

Any comments would be greatly appreciated

thank you

Alex

next             reply	other threads:[~2006-09-14 13:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-14 13:30 Alexandros Kostopoulos [this message]
2006-09-14 13:37 ` cpm_uart non-console problem with write on 2nd open Vitaly Bordug

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.tfvehinanhx3hy@draco \
    --to=akostop@inaccessnetworks$(echo .)com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox