From: Takashi Iwai <tiwai@suse•de>
To: " Maciej S. Szmigiero " <mail@maciej•szmigiero.name>
Cc: "Nicolin Chen" <nicoleotsuka@gmail•com>,
"Xiubo Li" <Xiubo.Lee@gmail•com>,
"Jaroslav Kysela" <perex@perex•cz>, "Timur Tabi" <timur@tabi•org>,
<alsa-devel@alsa-project•org>,
"Liam Girdwood" <lgirdwood@gmail•com>,
"Mark Brown" <broonie@kernel•org>,
<linuxppc-dev@lists•ozlabs.org>,
"Fabio Estevam" <fabio.estevam@nxp•com>,
"Takashi Sakamoto" <o-takashi@sakamocchi•jp>,
"linux-kernel" <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH v4 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S,U}20
Date: Wed, 29 Nov 2017 09:36:50 +0100 [thread overview]
Message-ID: <s5hd141pjkt.wl-tiwai@suse.de> (raw)
In-Reply-To: <3a279ea2-8098-d5a4-a53e-b0e3585fa9bf@maciej.szmigiero.name>
On Mon, 27 Nov 2017 23:33:29 +0100,
Maciej S. Szmigiero wrote:
>
> This format is similar to existing SNDRV_PCM_FORMAT_{S,U}20_3 that keep
> 20-bit PCM samples in 3 bytes, however i.MX6 platform SSI FIFO does not
> allow 3-byte accesses (including DMA) so a 4-byte (more conventional)
> format is needed for it.
>
> Signed-off-by: Maciej S. Szmigiero <mail@maciej•szmigiero.name>
> ---
> Changes from v1: Drop "_4" suffix from these formats since they aren't
> non-standard ones, use empty format slots starting from format number 25
> for them, add information that they are LSB justified formats.
>
> Changes from v2: Adapt a comment in sound/core/pcm_misc.c so it still
> refers to the same sample formats as before.
>
> Changes from v3: Make the comment style in include/uapi/sound/asound.h
> match the style of comments at other sample formats.
>
> Corresponding alsa-lib changes will be posted as soon as this patch is
> merged on the kernel side, to keep alsa-lib and kernel synchronized.
Applied to topic/pcm-20bit, also included in for-next.
Mark, please pull topic/pcm-20bit branch if you need to apply fsl_ssi
patch into your tree.
thanks,
Takashi
next prev parent reply other threads:[~2017-11-29 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 22:33 [PATCH v4 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S,U}20 Maciej S. Szmigiero
2017-11-29 8:36 ` Takashi Iwai [this message]
2017-11-29 19:00 ` Applied "ALSA: pcm: add SNDRV_PCM_FORMAT_{S,U}20" to the asoc tree Mark Brown
2017-11-29 21:23 ` [alsa-devel] Applied "ALSA: pcm: add SNDRV_PCM_FORMAT_{S, U}20" " Takashi Iwai
2017-11-30 10:41 ` Mark Brown
2017-11-30 10:49 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hd141pjkt.wl-tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=Xiubo.Lee@gmail$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=fabio.estevam@nxp$(echo .)com \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mail@maciej$(echo .)szmigiero.name \
--cc=nicoleotsuka@gmail$(echo .)com \
--cc=o-takashi@sakamocchi$(echo .)jp \
--cc=perex@perex$(echo .)cz \
--cc=timur@tabi$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox