From: "Martin K. Petersen" <martin.petersen@oracle•com>
To: Tyrel Datwyler <tyreld@linux•vnet.ibm.com>
Cc: martin.petersen@oracle•com, linux-scsi@vger•kernel.org,
stable@vger•kernel.org, james.bottomley@hansenpartnership•com,
brking@linux•vnet.ibm.com, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 2/2] ibmvscsi: Fix empty event pool access during host removal
Date: Wed, 20 Mar 2019 20:14:13 -0400 [thread overview]
Message-ID: <yq11s316q3u.fsf@oracle.com> (raw)
In-Reply-To: <20190320184151.31321-2-tyreld@linux.vnet.ibm.com> (Tyrel Datwyler's message of "Wed, 20 Mar 2019 13:41:51 -0500")
Tyrel,
> The event pool used for queueing commands is destroyed fairly early in
> the ibmvscsi_remove() code path. Since, this happens prior to the call
> so scsi_remove_host() it is possible for further calls to queuecommand
> to be processed which manifest as a panic due to a NULL pointer
> dereference as seen here:
Applied to 5.1/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-03-21 1:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 18:41 [PATCH 1/2] ibmvscsi: Protect ibmvscsi_head from concurrent modificaiton Tyrel Datwyler
2019-03-20 18:41 ` [PATCH 2/2] ibmvscsi: Fix empty event pool access during host removal Tyrel Datwyler
2019-03-21 0:14 ` Martin K. Petersen [this message]
2019-03-21 0:13 ` [PATCH 1/2] ibmvscsi: Protect ibmvscsi_head from concurrent modificaiton Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11s316q3u.fsf@oracle.com \
--to=martin.petersen@oracle$(echo .)com \
--cc=brking@linux$(echo .)vnet.ibm.com \
--cc=james.bottomley@hansenpartnership$(echo .)com \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=stable@vger$(echo .)kernel.org \
--cc=tyreld@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox