From: "Martin K. Petersen" <martin.petersen@oracle•com>
To: Brian King <brking@linux•vnet.ibm.com>
Cc: tyreld@linux•ibm.com, linuxppc-dev@lists•ozlabs.org,
martin.petersen@oracle•com, linux-scsi@vger•kernel.org
Subject: Re: [PATCH] ibmvfc: Protect vhost->task_set increment by the host lock
Date: Tue, 22 Sep 2020 17:39:34 -0400 [thread overview]
Message-ID: <yq1blhxpk36.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <1600286999-22059-1-git-send-email-brking@linux.vnet.ibm.com> (Brian King's message of "Wed, 16 Sep 2020 15:09:59 -0500")
Brian,
> In the discovery thread, ibmvfc does a vhost->task_set++ without any
> lock held. This could result in two targets getting the same cancel
> key, which could have strange effects in error recovery. The actual
> probability of this occurring should be extremely small, since this
> should all be done in a single threaded loop from the discovery
> thread, but let's fix it up anyway to be safe.
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-09-22 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 20:09 [PATCH] ibmvfc: Protect vhost->task_set increment by the host lock Brian King
2020-09-22 21:39 ` Martin K. Petersen [this message]
2020-09-30 3:34 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1blhxpk36.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle$(echo .)com \
--cc=brking@linux$(echo .)vnet.ibm.com \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=tyreld@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox